# frozen_string_literal: true module RuboCop module Cop module Style # Checks for uses of if/then/else/end constructs on a single line. # AlwaysCorrectToMultiline config option can be set to true to auto-convert all offenses to # multi-line constructs. When AlwaysCorrectToMultiline is false (default case) the # autocorrect will first try converting them to ternary operators. # # @example # # bad # if foo then bar else baz end # # # bad # unless foo then baz else bar end # # # good # foo ? bar : baz # # # good # bar if foo # # # good # if foo then bar end # # # good # if foo # bar # else # baz # end class OneLineConditional < Base include ConfigurableEnforcedStyle include OnNormalIfUnless extend AutoCorrector MSG = 'Favor the ternary operator (`?:`) or multi-line constructs ' \ 'over single-line `%s/then/else/end` constructs.' def on_normal_if_unless(node) return unless node.single_line? return unless node.else_branch return if node.elsif? message = message(node) add_offense(node, message: message) do |corrector| autocorrect(corrector, node) end end private def message(node) format(MSG, keyword: node.keyword) end def autocorrect(corrector, node) if always_multiline? || cannot_replace_to_ternary?(node) IfThenCorrector.new(node, indentation: indentation_width).call(corrector) else corrector.replace(node, ternary_correction(node)) end end def ternary_correction(node) replaced_node = ternary_replacement(node) return replaced_node unless node.parent return "(#{replaced_node})" if %i[and or].include?(node.parent.type) return "(#{replaced_node})" if node.parent.send_type? && node.parent.operator_method? replaced_node end def always_multiline? @config.for_cop('Style/OneLineConditional')['AlwaysCorrectToMultiline'] end def cannot_replace_to_ternary?(node) node.elsif_conditional? end def ternary_replacement(node) condition, if_branch, else_branch = *node "#{expr_replacement(condition)} ? " \ "#{expr_replacement(if_branch)} : " \ "#{expr_replacement(else_branch)}" end def expr_replacement(node) return 'nil' if node.nil? requires_parentheses?(node) ? "(#{node.source})" : node.source end def requires_parentheses?(node) return true if %i[and or if].include?(node.type) return true if node.assignment? return true if method_call_with_changed_precedence?(node) keyword_with_changed_precedence?(node) end def method_call_with_changed_precedence?(node) return false unless node.send_type? && node.arguments? return false if node.parenthesized_call? !node.operator_method? end def keyword_with_changed_precedence?(node) return false unless node.keyword? return true if node.respond_to?(:prefix_not?) && node.prefix_not? node.respond_to?(:arguments?) && node.arguments? && !node.parenthesized_call? end def indentation_width @config.for_cop('Layout/IndentationWidth')['Width'] end end end end end