Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Style
      # This cop checks for unparenthesized method calls in the argument list
      # of a parenthesized method call.
      #
      # @example
      #   # good
      #   method1(method2(arg))
      #
      #   # bad
      #   method1(method2 arg)
      class NestedParenthesizedCalls < Base
        include RangeHelp
        include AllowedMethods
        extend AutoCorrector

        MSG = 'Add parentheses to nested method call `%<source>s`.'

        def self.autocorrect_incompatible_with
          [Style::MethodCallWithArgsParentheses]
        end

        def on_send(node)
          return unless node.parenthesized?

          node.each_child_node(:send, :csend) do |nested|
            next if allowed_omission?(nested)

            message = format(MSG, source: nested.source)
            add_offense(nested.source_range, message: message) do |corrector|
              autocorrect(corrector, nested)
            end
          end
        end
        alias on_csend on_send

        private

        def autocorrect(corrector, nested)
          first_arg = nested.first_argument.source_range
          last_arg = nested.last_argument.source_range

          leading_space =
            range_with_surrounding_space(range: first_arg.begin,
                                         side: :left,
                                         whitespace: true,
                                         continuations: true)

          corrector.replace(leading_space, '(')
          corrector.insert_after(last_arg, ')')
        end

        def allowed_omission?(send_node)
          !send_node.arguments? || send_node.parenthesized? ||
            send_node.setter_method? || send_node.operator_method? ||
            allowed?(send_node)
        end

        def allowed?(send_node)
          send_node.parent.arguments.one? &&
            allowed_method?(send_node.method_name) &&
            send_node.arguments.one?
        end
      end
    end
  end
end

Version data entries

46 entries across 46 versions & 6 rubygems

Version	Path
rubocop-1.11.0	lib/rubocop/cop/style/nested_parenthesized_calls.rb
rubocop-1.10.0	lib/rubocop/cop/style/nested_parenthesized_calls.rb
rubocop-1.9.1	lib/rubocop/cop/style/nested_parenthesized_calls.rb
rubocop-1.9.0	lib/rubocop/cop/style/nested_parenthesized_calls.rb
rubocop-1.8.1	lib/rubocop/cop/style/nested_parenthesized_calls.rb
rubocop-1.8.0	lib/rubocop/cop/style/nested_parenthesized_calls.rb