Sha256: 968d230040bd4336f89f5dc7f34c797ebf8ec67d27c7f55d19f592a930d16e31
Contents?: true
Size: 1.79 KB
Versions: 10
Compression:
Stored size: 1.79 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Performance
# In Ruby 2.3 or later, use unary plus operator to unfreeze a string
# literal instead of `String#dup` and `String.new`.
# Unary plus operator is faster than `String#dup`.
#
# NOTE: `String.new` (without operator) is not exactly the same as `+''`.
# These differ in encoding. `String.new.encoding` is always `ASCII-8BIT`.
# However, `(+'').encoding` is the same as script encoding(e.g. `UTF-8`).
# Therefore, auto-correction is unsafe.
# So, if you expect `ASCII-8BIT` encoding, disable this cop.
#
# @example
# # bad
# ''.dup
# "something".dup
# String.new
# String.new('')
# String.new('something')
#
# # good
# +'something'
# +''
class UnfreezeString < Base
extend AutoCorrector
MSG = 'Use unary plus to get an unfrozen string literal.'
RESTRICT_ON_SEND = %i[dup new].freeze
def_node_matcher :dup_string?, <<~PATTERN
(send {str dstr} :dup)
PATTERN
def_node_matcher :string_new?, <<~PATTERN
{
(send (const nil? :String) :new {str dstr})
(send (const nil? :String) :new)
}
PATTERN
def on_send(node)
return unless dup_string?(node) || string_new?(node)
add_offense(node) do |corrector|
corrector.replace(node, "+#{string_value(node)}")
end
end
private
def string_value(node)
if node.receiver.source == 'String' && node.method?(:new)
node.arguments.empty? ? "''" : node.first_argument.source
else
node.receiver.source
end
end
end
end
end
end
Version data entries
10 entries across 10 versions & 1 rubygems