Contents

require 'brakeman/checks/base_check'

#Reports any calls to +validates_format_of+ which do not use +\A+ and +\z+
#as anchors in the given regular expression.
#
#For example:
#
# #Allows anything after new line
# validates_format_of :user_name, :with => /^\w+$/
class Brakeman::CheckValidationRegex < Brakeman::BaseCheck
  Brakeman::Checks.add self

  @description = "Report uses of validates_format_of with improper anchors"

  WITH = Sexp.new(:lit, :with)

  def run_check
    tracker.models.each do |name, model|
      @current_model = name
      format_validations = model[:options][:validates_format_of]
      if format_validations
        format_validations.each do |v|
          process_validator v
        end
      end
    end
  end

  #Check validates_format_of
  def process_validator validator
    hash_iterate(validator[-1]) do |key, value|
      if key == WITH
        check_regex value, validator
      end
    end
  end

  #Issue warning if the regular expression does not use
  #+\A+ and +\z+
  def check_regex value, validator
    return unless regexp? value

    regex = value[1].inspect
    if regex =~ /^\/(.{2}).*(.{2})\/(m|i|x|n|e|u|s|o)*\z/
      if $1 != "\\A" or ($2 != "\\Z" and $2 != "\\z")
        warn :model => @current_model,
          :warning_type => "Format Validation", 
          :message => "Insufficient validation for '#{get_name validator}' using #{value[1].inspect}. Use \\A and \\z as anchors",
          :line => value.line,
          :confidence => CONFIDENCE[:high] 
      end
    end
  end

  #Get the name of the attribute being validated.
  def get_name validator
    name = validator[1]
    if sexp? name
      name[1]
    else
      name
    end
  end
end

Version data entries

6 entries across 6 versions & 1 rubygems

Version	Path
brakeman-1.5.3	lib/brakeman/checks/check_validation_regex.rb
brakeman-1.5.2	lib/brakeman/checks/check_validation_regex.rb
brakeman-1.5.1	lib/brakeman/checks/check_validation_regex.rb
brakeman-1.5.0	lib/brakeman/checks/check_validation_regex.rb
brakeman-1.4.0	lib/brakeman/checks/check_validation_regex.rb
brakeman-1.3.0	lib/brakeman/checks/check_validation_regex.rb