Sha256: 9378d48dafb3931db4a1959e588ba296729f0c63b62e515fcb64ff4858280b44
Contents?: true
Size: 1.44 KB
Versions: 9
Compression:
Stored size: 1.44 KB
Contents
# frozen_string_literal: true
require_relative 'base_detector'
module Reek
module SmellDetectors
#
# Subclassing core classes in Ruby can lead to unexpected side effects.
# Knowing that Ruby has a core library, which is written in C, and a standard
# library, which is written in Ruby, if you do not know exactly how these core
# classes operate at the C level, you are gonna have a bad time.
#
# Source: http://words.steveklabnik.com/beware-subclassing-ruby-core-classes
#
class SubclassedFromCoreClass < BaseDetector
CORE_CLASSES = ['Array', 'Hash', 'String'].freeze
def self.contexts
[:class, :casgn]
end
# Checks +ctx+ for either expressions:
#
# Foo = Class.new(Bar)
#
# class Foo < Bar; end;
#
# @return [Array<SmellWarning>]
def sniff
superclass = expression.superclass
return [] unless superclass
sniff_superclass superclass.name
end
private
def sniff_superclass(superclass_name)
return [] unless CORE_CLASSES.include?(superclass_name)
[build_smell_warning(superclass_name)]
end
def build_smell_warning(ancestor_name)
smell_attributes = {
lines: [source_line],
message: "inherits from core class '#{ancestor_name}'",
parameters: { ancestor: ancestor_name }
}
smell_warning(smell_attributes)
end
end
end
end
Version data entries
9 entries across 7 versions & 2 rubygems