Sha256: 93468035e43283319fe73f3e3e8bd1219f771144f395c548aa5303874b763baf

Contents?: true

Size: 907 Bytes

Versions: 42

Compression:

Stored size: 907 Bytes

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Lint
      # This cop checks for `rand(1)` calls.
      # Such calls always return `0`.
      #
      # @example
      #
      #   # bad
      #
      #   rand 1
      #   Kernel.rand(-1)
      #   rand 1.0
      #   rand(-1.0)
      #
      # @example
      #
      #   # good
      #
      #   0 # just use 0 instead
      class RandOne < Cop
        MSG = '`%<method>s` always returns `0`. ' \
              'Perhaps you meant `rand(2)` or `rand`?'

        def_node_matcher :rand_one?, <<~PATTERN
          (send {(const nil? :Kernel) nil?} :rand {(int {-1 1}) (float {-1.0 1.0})})
        PATTERN

        def on_send(node)
          return unless rand_one?(node)

          add_offense(node)
        end

        private

        def message(node)
          format(MSG, method: node.source)
        end
      end
    end
  end
end

Version data entries

42 entries across 31 versions & 5 rubygems

Version Path
grape-extra_validators-2.0.0 vendor/bundle/ruby/2.6.0/gems/rubocop-0.79.0/lib/rubocop/cop/lint/rand_one.rb
rubocop-0.86.0 lib/rubocop/cop/lint/rand_one.rb
files.com-1.0.1 vendor/bundle/ruby/2.5.0/gems/rubocop-0.85.1/lib/rubocop/cop/lint/rand_one.rb
rbhint-0.85.1.rc2 lib/rubocop/cop/lint/rand_one.rb
rbhint-0.85.1.rc1 lib/rubocop/cop/lint/rand_one.rb
rubocop-0.85.1 lib/rubocop/cop/lint/rand_one.rb
rbhint-0.8.5.rc1 lib/rubocop/cop/lint/rand_one.rb
rubocop-0.85.0 lib/rubocop/cop/lint/rand_one.rb
rubocop-0.84.0 lib/rubocop/cop/lint/rand_one.rb
rubocop-0.83.0 lib/rubocop/cop/lint/rand_one.rb
rubocop-0.82.0 lib/rubocop/cop/lint/rand_one.rb
rubocop-0.81.0 lib/rubocop/cop/lint/rand_one.rb
rubocop-0.80.1 lib/rubocop/cop/lint/rand_one.rb
rubocop-0.80.0 lib/rubocop/cop/lint/rand_one.rb
grape-extra_validators-1.0.0 vendor/bundle/ruby/2.6.0/gems/rubocop-0.79.0/lib/rubocop/cop/lint/rand_one.rb
grape-extra_validators-1.0.0 vendor/bundle/ruby/2.4.0/gems/rubocop-0.79.0/lib/rubocop/cop/lint/rand_one.rb
rubocop-0.79.0 lib/rubocop/cop/lint/rand_one.rb
rubocop-0.78.0 lib/rubocop/cop/lint/rand_one.rb
zuora_connect_ui-0.10.0 vendor/ruby/2.6.0/gems/rubocop-0.77.0/lib/rubocop/cop/lint/rand_one.rb
zuora_connect_ui-0.10.0 vendor/ruby/2.6.0/gems/rubocop-0.75.1/lib/rubocop/cop/lint/rand_one.rb