Sha256: 8ffd31498b902586ff8beb54f822668ee582d6e43b3a9e5eab64dce62a67eda8
Contents?: true
Size: 1.3 KB
Versions: 38
Compression:
Stored size: 1.3 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Lint
# This cop checks for `return` from an `ensure` block.
# `return` from an ensure block is a dangerous code smell as it
# will take precedence over any exception being raised,
# and the exception will be silently thrown away as if it were rescued.
#
# If you want to rescue some (or all) exceptions, best to do it explicitly
#
# @example
#
# # bad
#
# def foo
# do_something
# ensure
# cleanup
# return self
# end
#
# @example
#
# # good
#
# def foo
# do_something
# self
# ensure
# cleanup
# end
#
# # also good
#
# def foo
# begin
# do_something
# rescue SomeException
# # Let's ignore this exception
# end
# self
# ensure
# cleanup
# end
class EnsureReturn < Base
extend AutoCorrector
include RangeHelp
MSG = 'Do not return from an `ensure` block.'
def on_ensure(node)
node.body&.each_node(:return) { |return_node| add_offense(return_node) }
end
end
end
end
end
Version data entries
38 entries across 38 versions & 6 rubygems