SQLite format 3@ ïEï-â% ˜ Ò _$˜ WD 11‚3tablehubification_reposhubification_reposCREATE TABLE "hubification_repos" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL)ƒu77‡ tablehubification_commentshubification_commentsCREATE TABLE "hubification_comments" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "html_url" varchar(255), "url" varchar(255), "pull_request_url" varchar(255), "diff_hunk" varchar(255), "path" integer, "position" integer, "original_position" varchar(255), "line" varchar(255), "commit_id" varchar(255), "original_commit_id" varchar(255), "body" varchar(255), "user_id" integer, "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL)„x 11‰tablehubification_usershubification_usersCREATE TABLE "hubification_users" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "login" varchar(255), "avatar_url" varchar(255), "gravatar_id" varchar(255), "url" varchar(255), "html_url" varchar(255), "followers_url" varchar(255), "following_url" varchar(255), "gists_url" varchar(255), "starred_url" varchar(255), "subscriptions_url" varchar(255), "organizations_url" varchar(255), "repos_url" varchar(255), "events_url" varchar(255), "received_events_url" varchar(255), "role" varchar(255), "site_admin" boolean, "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL)P++Ytablesqlite_sequencesqlite_sequenceCREATE TABLE sqlite_sequence(name,seq)\ AA‚Ctablehubification_pull_requestshubification_pull_requestsCREATE TABLE "hubification_pull_requests" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL)=//indexunique_schema_migrationsschema_migrationsCREATE UNIQUE INDEX "unique_schema_migrations" ON "schema_migrations" ("version")q//tableschema_migrationsschema_migrationsCREATE TABLE "schema_migrations" ("version" varchar(255) NOT NULL) ¸îÜʸ)20140604130550)20140604130504)20140604130457)20140604130339 µîÛȵ)20140604130550)20140604130504)20140604130457) 20140604130339  ÉÉã3hubification_usersŒ1hubification_usersk7hubification_commentsbÓvÇBùòÖÝëäÇο…‚ŠiMS?gso]_usAApbyrnehttps://avatars.githubusercontent.com/u/34053?9ebda660f4816d6db73033d8a0b75db2https://api.github.com/users/pbyrnehttps://github.com/pbyrnehttps://api.github.com/users/pbyrne/followershttps://api.github.com/users/pbyrne/following{/other_user}https://api.github.com/users/pbyrne/gists{/gist_id}https://api.github.com/users/pbyrne/starred{/owner}{/repo}https://api.github.com/users/pbyrne/subscriptionshttps://api.github.com/users/pbyrne/orgshttps://api.github.com/users/pbyrne/reposhttps://api.github.com/users/pbyrne/events{/privacy}https://api.github.com/users/pbyrne/received_eventsUserf2014-06-05 15:35:55.5471492014-06-05 15:35:55.547149…4‚ðfiMWCkwsacywAAjonkarnahttps://avatars.githubusercontent.com/u/47206?8fee954d5185211670914d7d4dc48d7dhttps://api.github.com/users/jonkarnahttps://github.com/jonkarnahttps://api.github.com/users/jonkarna/followershttps://api.github.com/users/jonkarna/following{/other_user}https://api.github.com/users/jonkarna/gists{/gist_id}https://api.github.com/users/jonkarna/starred{/owner}{/repo}https://api.github.com/users/jonkarna/subscriptionshttps://api.github.com/users/jonkarna/orgshttps://api.github.com/users/jonkarna/reposhttps://api.github.com/users/jonkarna/events{/privacy}https://api.github.com/users/jonkarna/received_eventsUserf2014-06-05 15:35:55.5394752014-06-05 15:35:55.539475…Y°©#kM]Iq } ygi}AAtstnoahwenzhttps://avatars.githubusercontent.com/u/791703?9251ab4d6f603a7e5158bf30463a8847https://api.github.com/users/tstnoahwenzhttps://github.com/tstnoahwenzhttps://api.github.com/users/tstnoahwenz/followershttps://api.github.com/users/tstnoahwenz/following{/other_user}https://api.github.com/users/tstnoahwenz/gists{/gist_id}https://api.github.com/users/tstnoahwenz/starred{/owner}{/repo}https://api.github.com/users/tstnoahwenz/subscriptionshttps://api.github.com/users/tstnoahwenz/orgshttps://api.github.com/users/tstnoahwenz/reposhttps://api.github.com/users/tstnoahwenz/events{/privacy}https://api.github.com/users/tstnoahwenz/received_eventsUserf2014-06-05 15:35:55.5315662014-06-05 15:35:55.531566…5¢˜?kMWCkwsacywAAbryceschhttps://avatars.githubusercontent.com/u/560191?e736e1465215cd0582fe8dc263692904https://api.github.com/users/bryceschhttps://github.com/bryceschhttps://api.github.com/users/brycesch/followershttps://api.github.com/users/brycesch/following{/other_user}https://api.github.com/users/brycesch/gists{/gist_id}https://api.github.com/users/brycesch/starred{/owner}{/repo}https://api.github.com/users/brycesch/subscriptionshttps://api.github.com/users/brycesch/orgshttps://api.github.com/users/brycesch/reposhttps://api.github.com/users/brycesch/events{/privacy}https://api.github.com/users/brycesch/received_eventsUserf2014-06-05 15:35:55.5167582014-06-05 15:35:55.516758…s¦S'iMaMu}kmAAmrDarcyMurphyhttps://avatars.githubusercontent.com/u/21331?a0625ccfc630618784aaa58a37914dffhttps://api.github.com/users/mrDarcyMurphyhttps://github.com/mrDarcyMurphyhttps://api.github.com/users/mrDarcyMurphy/followershttps://api.github.com/users/mrDarcyMurphy/following{/other_user}https://api.github.com/users/mrDarcyMurphy/gists{/gist_id}https://api.github.com/users/mrDarcyMurphy/starred{/owner}{/repo}https://api.github.com/users/mrDarcyMurphy/subscriptionshttps://api.github.com/users/mrDarcyMurphy/orgshttps://api.github.com/users/mrDarcyMurphy/reposhttps://api.github.com/users/mrDarcyMurphy/events{/privacy}https://api.github.com/users/mrDarcyMurphy/receive‚†—f+ë¤m:´Ÿ:“½~¬ýp3ÏÍ­= ŠÑ ‚ðf3xEùòëäÝÖÏÈÁº³¬¥ž—ˆ€xph`XPH@80( øðèàØÐÈÀ¸°¨ ˜ˆ€x‚4·î@Y]QAAhttps://github.com/sportngin/ngin/commit/94e97b0ceee701466398da74cf5a2c16791c82a2#commitcomment-915264https://api.github.com/repos/sportngin/ngin/comments/91526494e97b0ceee701466398da74cf5a2c16791c82a2Can we get tests around this, Jon?¨“2012-01-30 19:05:30.0000002012-01-30 19:05:30.000000‚³ÈTY]!AAhttps://github.com/sportngin/ngin/commit/85cc0c2430afb03387971e62b94dc6011792d949#commitcomment-844884https://api.github.com/repos/sportngin/ngin/comments/84488485cc0c2430afb03387971e62b94dc6011792d949@pbyrne +1º†2012-01-06 20:42:03.0000002012-01-06 20:42:03.000000ƒ<³ÈAY]‚_AAhttps://github.com/sportngin/ngin/commit/85cc0c2430afb03387971e62b94dc6011792d949#commitcomment-844865https://api.github.com/repos/sportngin/ngin/comments/84486585cc0c2430afb03387971e62b94dc6011792d949RAAAGE. ```ruby live_games = Game.where("updated_at > ? and updated_at < ? and scoring_type = 'live' and status = 'completed'", args.start_date, args.end_date) ```…2012-01-06 20:35:49.0000002012-01-06 20:35:49.000000ƒ¦å5Y]}AAhttps://github.com/sportngin/ngin/commit/a720acc07b7b55c8fa7b2b23cac2fb620307a1fb#commitcomment-635573https://api.github.com/repos/sportngin/ngin/comments/63557328a720acc07b7b55c8fa7b2b23cac2fb620307a1fbYou can use @photo_gallery.aspect_ratio_display if you want to use the description "Panerama 4:1" instead of just "4:1".…2011-10-06 20:04:04.0000002011-10-06 20:04:04.000000ƒ  ’]Y]}AAhttps://github.com/sportngin/ngin/commit/10aaf1479304c07617b546c31c83525954f406e8#commitcomment-526685https://api.github.com/repos/sportngin/ngin/comments/52668510aaf1479304c07617b546c31c83525954f406e8When layout_column_id is updated, layout_column still returns the cached layout_column unless force_reload is specified.¸f2011-08-11 17:57:55.0000002011-08-11 17:57:55.000000ƒ¦YY]iAAhttps://github.com/sportngin/ngin/commit/d29856c6a8674bbccd5ad6c97817ecfbdc82034b#commitcomment-480089https://api.github.com/repos/sportngin/ngin/comments/480089d29856c6a8674bbccd5ad6c97817ecfbdc82034bThis commit was labeled improperly. These were small style edits to the Play-by-Play Tab on the game/show page —2011-07-15 21:29:54.0000002011-07-15 21:29:54.000000ƒ”†Y]‚!AAhttps://github.com/sportngin/ngin/commit/bcacbb55ff38ec25fa5f4ffb813bb9db48014b5f#commitcomment-328453https://api.github.com/repos/sportngin/ngin/comments/328453bcacbb55ff38ec25fa5f4ffb813bb9db48014b5fthis is separate from the payment_plan_failure_admin_notice master bug. It was correct in master, but someone changed it since in rails3. Œ?2011-04-04 15:30:53.0000002011-04-04 15:30:53.000000‚’ÝhY]AAhttps://github.com/sportngin/ngin/commit/a527b9cc7a5f9edf778631c0a02147e4d2631108#commitcomment-306920https://api.github.com/repos/sportngin/ngin/comments/306920a527b9cc7a5f9edf778631c0a02147e4d2631108bug 10574Œ?2011-03-18 16:48:10.0000002011-03-18 16:48:10.000000‚?ˆƒY]iAAhttps://github.com/sportngin/ngin/commit/eb6f0833a07c66c0b99d32a2fce1ebb41a890541#commitcomment-131463https://api.github.com/repos/sportngin/ngin/comments/131463eb6f0833a07c66c0b99d32a2fce1ebb41a890541I used pngout: http://www.jonof.id.au/kenutilsSS2010-08-19 16:57:42.0000002010-08-19 16:57:42.000000‚_ˆƒY]'AAhttps://github.com/sportngin/ngin/commit/eb6f0833a07c66c0b99d32a2fce1ebb41a890541#commitcomment-131462https://api.github.com/repos/sportngin/ngin/comments/131462eb6f0833a07c66c0b99d32a2fce1ebb41a890541No appreciable difference Dƒ‡õ.C‚è”A‚ßÌ;@‚Þ„]?‚ªþz>‚ª¥l=‚Ÿ±"<ÿÏ1;ùüH9ïÆ@8äúb7Þ‡6Ñõ+5͉4þ2¾ê1ºåm0º–/º•y.º•-º”,¹×k*¹›^)·ù(·–7'¶ÿ2&­í1%«í$¥åo#¥®)"¡ãh!šôn ”ú/Ž÷a‹¾0ú²xôû í¡|ã½ݧmÔqÓ”*б-ÏÖÎÑË–É–8ÅÂ6 Áìp ¼ñ\ ·î@  00(É v G…‚ŠiMS?g…s¦S'iMaM…s¦S'iMaMu}kmAAmrDarcyMurphyhttps://avatars.githubusercontent.com/u/21331?a0625ccfc630618784aaa58a37914dffhttps://api.github.com/users/mrDarcyMurphyhttps://github.com/mrDarcyMurphyhttps://api.github.com/users/mrDarcyMurphy/followershttps://api.github.com/users/mrDarcyMurphy/following{/other_user}https://api.github.com/users/mrDarcyMurphy/gists{/gist_id}https://api.github.com/users/mrDarcyMurphy/starred{/owner}{/repo}https://api.github.com/users/mrDarcyMurphy/subscriptionshttps://api.github.com/users/mrDarcyMurphy/orgshttps://api.github.com/users/mrDarcyMurphy/reposhttps://api.github.com/users/mrDarcyMurphy/events{/privacy}https://api.github.com/users/mrDarcyMurphy/received_eventsUserf2014-06-05 15:35:55.4718502014-06-05 15:35:55.471850…‚ŠiMS?gso]_usAApbyrnehttps://avatars.githubusercontent.com/u/34053?9ebda660f4816d6db73033d8a0b75db2https://api.github.com/users/pbyrnehttps://github.com/pbyrnehttps://api.github.com/users/pbyrne/followershttps://api.github.com/users/pbyrne/following{/other_user}https://api.github.com/users/pbyrne/gists{/gist_id}https://api.github.com/users/pbyrne/starred{/owner}{/repo}https://api.github.com/users/pbyrne/subscriptionshttps://api.github.com/users/pbyrne/orgshttps://api.github.com/users/pbyrne/reposhttps://api.github.com/users/pbyrne/events{/privacy}https://api.github.com/users/pbyrne/received_eventsUserf2014-06-05 15:35:55.5471492014-06-05 15:35:55.547149…(‚Ò]iMUAiuq_awuAAgblaskohttps://avatars.githubusercontent.com/u/43357?3a9bc3f89a137936f6be3b036be31fbfhttps://api.github.com/users/gblaskohttps://github.com/gblaskohttps://api.github.com/users/gblasko/followershttps://api.github.com/users/gblasko/following{/other_user}https://api.github.com/users/gblasko/gists{/gist_id}https://api.github.com/users/gblasko/starred{/owner}{/repo}https://api.github.com/users/gblasko/subscriptionshttps://api.github.com/users/gblasko/orgshttps://api.github.com/users/gblasko/reposhttps://api.github.com/users/gblasko/events{/privacy}https://api.github.com/users/gblasko/received_eventsUserf2014-06-05 15:35:56.5426922014-06-05 15:35:56.542692…L‚Òi!iM[Go { weg}{AAlukeludwighttps://avatars.githubusercontent.com/u/43369?5e9e54adc9f7665abdeb894c475953aehttps://api.github.com/users/lukeludwighttps://github.com/lukeludwighttps://api.github.com/users/lukeludwig/followershttps://api.github.com/users/lukeludwig/following{/other_user}https://api.github.com/users/lukeludwig/gists{/gist_id}https://api.github.com/users/lukeludwig/starred{/owner}{/repo}https://api.github.com/users/lukeludwig/subscriptionshttps://api.github.com/users/lukeludwig/orgshttps://api.github.com/users/lukeludwig/reposhttps://api.github.com/users/lukeludwig/events{/privacy}https://api.github.com/users/lukeludwig/received_eventsUserf2014-06-05 15:35:55.7209012014-06-05 15:35:55.720901…4‚ðfiMWCkwsacywAAjonkarnahttps://avatars.githubusercontent.com/u/47206?8fee954d5185211670914d7d4dc48d7dhttps://api.github.com/users/jonkarnahttps://github.com/jonkarnahttps://api.github.com/users/jonkarna/followershttps://api.github.com/users/jonkarna/following{/other_user}https://api.github.com/users/jonkarna/gists{/gist_id}https://api.github.com/users/jonkarna/starred{/owner}{/repo}https://api.github.com/users/jonkarna/subscriptionshttps://api.github.com/users/jonkarna/orgshttps://api.github.com/users/jonkarna/reposhttps://api.github.com/users/jonkarna/events{/privacy}https://api.github.com/users/jonkarna/received_eventsUserf2014-06-05 15:35:55.5394752014-06-05 15:35:55.539475 >>÷¼ F†&ÏÍ/mMiU} su AAJustinChristensenhttps://avatars.githubusercontent.com/u/1304220?f6326bee4e1bd683a75789ddf9042861https://api.github.com/users/JustinC…4…4‚õiMWCkwsacywAAanfleenehttps://avatars.githubusercontent.com/u/47750?c2f4585135c0d731c95797805ff35adfhttps://api.github.com/users/anfleenehttps://github.com/anfleenehttps://api.github.com/users/anfleene/followershttps://api.github.com/users/anfleene/following{/other_user}https://api.github.com/users/anfleene/gists{/gist_id}https://api.github.com/users/anfleene/starred{/owner}{/repo}https://api.github.com/users/anfleene/subscriptionshttps://api.github.com/users/anfleene/orgshttps://api.github.com/users/anfleene/reposhttps://api.github.com/users/anfleene/events{/privacy}https://api.github.com/users/anfleene/received_eventsUserf2014-06-05 15:35:55.5600302014-06-05 15:35:55.560030…@…‚qiMYEmyuce{yAAdougrohdehttps://avatars.githubusercontent.com/u/82289?dd45239ae35102880128975c581b9930https://api.github.com/users/dougrohdehttps://github.com/dougrohdehttps://api.github.com/users/dougrohde/followershttps://api.github.com/users/dougrohde/following{/other_user}https://api.github.com/users/dougrohde/gists{/gist_id}https://api.github.com/users/dougrohde/starred{/owner}{/repo}https://api.github.com/users/dougrohde/subscriptionshttps://api.github.com/users/dougrohde/orgshttps://api.github.com/users/dougrohde/reposhttps://api.github.com/users/dougrohde/events{/privacy}https://api.github.com/users/dougrohde/received_eventsUserf2014-06-05 15:35:55.7656302014-06-05 15:35:55.765630…@…ÄGiMYEmyuce{yAAcarlallenhttps://avatars.githubusercontent.com/u/90695?8932131f8e76415dd55a92c8ac4588efhttps://api.github.com/users/carlallenhttps://github.com/carlallenhttps://api.github.com/users/carlallen/followershttps://api.github.com/users/carlallen/following{/other_user}https://api.github.com/users/carlallen/gists{/gist_id}https://api.github.com/users/carlallen/starred{/owner}{/repo}https://api.github.com/users/carlallen/subscriptionshttps://api.github.com/users/carlallen/orgshttps://api.github.com/users/carlallen/reposhttps://api.github.com/users/carlallen/events{/privacy}https://api.github.com/users/carlallen/received_eventsUserf2014-06-05 15:35:59.1768202014-06-05 15:35:59.176820…@…ÐYiMYEmyuce{yAAjericksonhttps://avatars.githubusercontent.com/u/92249?d99a434423bae320eb025bd2fb94c973https://api.github.com/users/jericksonhttps://github.com/jericksonhttps://api.github.com/users/jerickson/followershttps://api.github.com/users/jerickson/following{/other_user}https://api.github.com/users/jerickson/gists{/gist_id}https://api.github.com/users/jerickson/starred{/owner}{/repo}https://api.github.com/users/jerickson/subscriptionshttps://api.github.com/users/jerickson/orgshttps://api.github.com/users/jerickson/reposhttps://api.github.com/users/jerickson/events{/privacy}https://api.github.com/users/jerickson/received_eventsUserf2014-06-05 15:36:00.4428952014-06-05 15:36:00.442895…5ŠÑkMWCkwsacywAAehlertijhttps://avatars.githubusercontent.com/u/174227?11c1fcb84ab1fdf769cbc3f7c8466528https://api.github.com/users/ehlertijhttps://github.com/ehlertijhttps://api.github.com/users/ehlertij/followershttps://api.github.com/users/ehlertij/following{/other_user}https://api.github.com/users/ehlertij/gists{/gist_id}https://api.github.com/users/ehlertij/starred{/owner}{/repo}https://api.github.com/users/ehlertij/subscriptionshttps://api.github.com/users/ehlertij/orgshttps://api.github.com/users/ehlertij/reposhttps://api.github.com/users/ehlertij/events{/privacy}https://api.github.com/users/ehlertij/received_eventsUserf2014-06-05 15:35:55.5687212014-06-05 15:35:55.568721 ³á } 9  wñaÎ 쳂4·î@Y]QAAhttps://github.com/sportngin/ngin/commit/94e97b0ceee701466398da74cf5a2c16791c82a2#commitcomment-915264https://api.github.com/repos/sportngin/ngin/comments/91526494e97b0ceee701466398da74cf5a2c16791c82a2Can we get tests around this, Jon?¨“2012-01-30 19:05:30.0000002012-01-30 19:05:30.000000‚³ÈTY]!AAhttps://github.com/sportngin/ngin/commit/85cc0c2430afb03387971e62b94dc6011792d949#commitcomment-844884https://api.github.com/repos/sportngin/ngin/comments/84488485cc0c2430afb03387971e62b94dc6011792d949@pbyrne +1º†2012-01-06 20:42:03.0000002012-01-06 20:42:03.000000ƒ<³ÈAY]‚_AAhttps://github.com/sportngin/ngin/commit/85cc0c2430afb03387971e62b94dc6011792d949#commitcomment-844865https://api.github.com/repos/sportngin/ngin/comments/84486585cc0c2430afb03387971e62b94dc6011792d949RAAAGE. ```ruby live_games = Game.where("updated_at > ? and updated_at < ? and scoring_type = 'live' and status = 'completed'", args.start_date, args.end_date) ```…2012-01-06 20:35:49.0000002012-01-06 20:35:49.000000ƒ¦å5Y]}AAhttps://github.com/sportngin/ngin/commit/a720acc07b7b55c8fa7b2b23cac2fb620307a1fb#commitcomment-635573https://api.github.com/repos/sportngin/ngin/comments/63557328a720acc07b7b55c8fa7b2b23cac2fb620307a1fbYou can use @photo_gallery.aspect_ratio_display if you want to use the description "Panerama 4:1" instead of just "4:1".…2011-10-06 20:04:04.0000002011-10-06 20:04:04.000000ƒ  ’]Y]}AAhttps://github.com/sportngin/ngin/commit/10aaf1479304c07617b546c31c83525954f406e8#commitcomment-526685https://api.github.com/repos/sportngin/ngin/comments/52668510aaf1479304c07617b546c31c83525954f406e8When layout_column_id is updated, layout_column still returns the cached layout_column unless force_reload is specified.¸f2011-08-11 17:57:55.0000002011-08-11 17:57:55.000000ƒ¦YY]iAAhttps://github.com/sportngin/ngin/commit/d29856c6a8674bbccd5ad6c97817ecfbdc82034b#commitcomment-480089https://api.github.com/repos/sportngin/ngin/comments/480089d29856c6a8674bbccd5ad6c97817ecfbdc82034bThis commit was labeled improperly. These were small style edits to the Play-by-Play Tab on the game/show page —2011-07-15 21:29:54.0000002011-07-15 21:29:54.000000ƒ”†Y]‚!AAhttps://github.com/sportngin/ngin/commit/bcacbb55ff38ec25fa5f4ffb813bb9db48014b5f#commitcomment-328453https://api.github.com/repos/sportngin/ngin/comments/328453bcacbb55ff38ec25fa5f4ffb813bb9db48014b5fthis is separate from the payment_plan_failure_admin_notice master bug. It was correct in master, but someone changed it since in rails3. Œ?2011-04-04 15:30:53.0000002011-04-04 15:30:53.000000‚’ÝhY]AAhttps://github.com/sportngin/ngin/commit/a527b9cc7a5f9edf778631c0a02147e4d2631108#commitcomment-306920https://api.github.com/repos/sportngin/ngin/comments/306920a527b9cc7a5f9edf778631c0a02147e4d2631108bug 10574Œ?2011-03-18 16:48:10.0000002011-03-18 16:48:10.000000‚?ˆƒY]iAAhttps://github.com/sportngin/ngin/commit/eb6f0833a07c66c0b99d32a2fce1ebb41a890541#commitcomment-131463https://api.github.com/repos/sportngin/ngin/comments/131463eb6f0833a07c66c0b99d32a2fce1ebb41a890541I used pngout: http://www.jonof.id.au/kenutilsSS2010-08-19 16:57:42.0000002010-08-19 16:57:42.000000‚_ˆƒY]'AAhttps://github.com/sportngin/ngin/commit/eb6f0833a07c66c0b99d32a2fce1ebb41a890541#commitcomment-131462https://api.github.com/repos/sportngin/ngin/comments/131462eb6f0833a07c66c0b99d32a2fce1ebb41a890541No appreciable difference in quality, but saved 1000-2000 bytes on each file.SS2010-08-19 16:57:17.0000002010-08-19 16:57:17.000000‚…±lW]AAhttps://github.com/sportngin/ngin/commit/49090fee09dc64d84e920edb907a3e93563ec2fe#commitcomment-88300https://api.github.com/repos/sportngin/ngin/comments/883002649090fee09dc64d84e920edb907a3e93563ec2feToo low!SS2010-06-02 17:36:20.0000002010-06-02 17:36:20.000000 ; c Ô ÈÔY;ƒX¼ñ\Y]ƒAAhttps://github.com/sportngin/ngin/commit/74c97718287a4f9584cf5a85b0092fa737359226#commitcomment-997596https://api.github.com/repos/sportngin/ngin/comments/99759674c97718287a4f9584cf5a85b0092fa737359226A couple unit tests for this would be awesome. They should be pretty easy to throw together too. - one testing sorting of normal answers with display columns - one testing sorting of date answers¨“2012-02-22 19:14:36.0000002012-02-22 19:14:36.000000‚<¼œwY]aAAhttps://github.com/sportngin/ngin/commit/d3fdda8325c3ca28c8dfd78b4ebc153b8058375e#commitcomment-986743https://api.github.com/repos/sportngin/ngin/comments/986743d3fdda8325c3ca28c8dfd78b4ebc153b8058375eOops. Correct. To disable system messages.…2012-02-20 18:02:05.0000002012-02-20 18:02:05.000000‚v¼œ[Y]SAAhttps://github.com/sportngin/ngin/commit/d3fdda8325c3ca28c8dfd78b4ebc153b8058375e#commitcomment-986715https://api.github.com/repos/sportngin/ngin/comments/986715d3fdda8325c3ca28c8dfd78b4ebc153b8058375eSounds like a paradox. I think you meant "Add site setting to disable system messages on the site" >ð2012-02-20 17:54:09.0000002012-02-20 17:54:09.000000‚C»¹ Y]gAAhttps://github.com/sportngin/ngin/commit/349426c9b1846ae1059b2de476304a89d3d56e2a#commitcomment-973984https://api.github.com/repos/sportngin/ngin/comments/973984113349426c9b1846ae1059b2de476304a89d3d56e2anope, I did not. thanks for pointing it out. Œ?2012-02-16 15:03:06.0000002012-02-16 15:03:06.000000ƒ'»¸=Y]‚-AAhttps://github.com/sportngin/ngin/commit/8aca71a88e06658b608f3f3dc1f18ecc89a6a2a6#commitcomment-973885https://api.github.com/repos/sportngin/ngin/comments/973885 1078aca71a88e06658b608f3f3dc1f18ecc89a6a2a6You could go a step further and wrap the whole thing in a `if params[:game][:extra_game_details]` to remove that duplication from the two lines.…2012-02-16 14:38:53.0000002012-02-16 14:38:53.000000‚M»µSY]{AAhttps://github.com/sportngin/ngin/commit/349426c9b1846ae1059b2de476304a89d3d56e2a#commitcomment-973523https://api.github.com/repos/sportngin/ngin/comments/973523113349426c9b1846ae1059b2de476304a89d3d56e2aDid you mean to call set_layout_template a second time?…2012-02-16 12:09:31.0000002012-02-16 12:09:31.000000…5¸yY]†QAAhttps://github.com/sportngin/ngin/commit/71c362b288f757b676bb4ef33d02e3e94c126007#commitcomment-921337https://api.github.com/repos/sportngin/ngin/comments/92133771c362b288f757b676bb4ef33d02e3e94c126007Yes. I created a HelpSpot ticket for it too. On Tue, Jan 31, 2012 at 9:54 PM, Ian Ehlert < reply@reply.github.com > wrote: > Is this the error you were fixing, Ed? > https://rpm.newrelic.com/accounts/875/applications/16731/traced_errors/146963567 > > --- > Reply to this email directly or view it on GitHub: > > https://github.com/tstmedia/ngin/commit/71c362b288f757b676bb4ef33d02e3e94c126007#commitcomment-921282 >êâ2012-02-01 04:38:11.0000002012-02-01 04:38:11.000000ƒ ¸BY]{AAhttps://github.com/sportngin/ngin/commit/71c362b288f757b676bb4ef33d02e3e94c126007#commitcomment-921282https://api.github.com/repos/sportngin/ngin/comments/92128271c362b288f757b676bb4ef33d02e3e94c126007Is this the error you were fixing, Ed? https://rpm.newrelic.com/accounts/875/applications/16731/traced_errors/146963567¨“2012-02-01 03:54:33.0000002012-02-01 03:54:33.000000…¸‹Y]†AAhttps://github.com/sportngin/ngin/commit/6bf99924725451763dc35c9f52beb2fec5417320#commitcomment-918919https://api.github.com/repos/sportngin/ngin/comments/9189196bf99924725451763dc35c9f52beb2fec5417320When updating the survey, does the user change? If so, the change to the validation will work. If not, the validation check will go against the user who created the survey, rather than the user who is updating the survey. In either case, the change to the view should be undone, because that's also checking against the user associated with the survey, not the currently logged-in user.…2012-01-31 16:32:22.0000002012-01-31 16:32:22.000000 }á …  Ç,fHÙ}„WÁìp[]…AAhttps://github.com/sportngin/ngin/commit/1135dcb5c7cc3099d56f8f8705d76e1743fa2a16#commitcomment-1078896https://api.github.com/repos/sportngin/ngin/comments/10788961135dcb5c7cc3099d56f8f8705d76e1743fa2a16Looks good Zheng. One other thought... what if we skipped joining in team_instances and page_nodes and removed the page_nodes.display_status = 'public' condition? This would mean we might return Teams that don't have any page_nodes or Teams that don't have public pages.... but I wonder how much it would help performance?©i2012-03-13 16:55:23.0000002012-03-13 16:55:23.000000‚jÁé0[]1AAhttps://github.com/sportngin/ngin/commit/2d741fc3677051706f1e5cd0071a43754a6a518c#commitcomment-1078448https://api.github.com/repos/sportngin/ngin/comments/1078448332d741fc3677051706f1e5cd0071a43754a6a518cGood suggestion. Changed this for summary answer and date answer, and added tests.Aq2012-03-13 15:28:49.0000002012-03-13 15:28:49.000000‚Áä^[]AAhttps://github.com/sportngin/ngin/commit/2d741fc3677051706f1e5cd0071a43754a6a518c#commitcomment-1077854https://api.github.com/repos/sportngin/ngin/comments/1077854332d741fc3677051706f1e5cd0071a43754a6a518c+1º†2012-03-13 13:32:47.0000002012-03-13 13:32:47.000000ƒAÁäS[]‚_AAhttps://github.com/sportngin/ngin/commit/2d741fc3677051706f1e5cd0071a43754a6a518c#commitcomment-1077843https://api.github.com/repos/sportngin/ngin/comments/1077843332d741fc3677051706f1e5cd0071a43754a6a518cExcept for the == operator, some duplication could be eliminated with something like: when '>', '>=', '<', '<=' value.send(condition_operator, condition.to_i)…2012-03-13 13:28:53.0000002012-03-13 13:28:53.000000ƒÀ¸ []‚AAhttps://github.com/sportngin/ngin/commit/50b69a30e8760fe5fbdb5c6fd3cb14bbd4151887#commitcomment-1055754https://api.github.com/repos/sportngin/ngin/comments/105575450b69a30e8760fe5fbdb5c6fd3cb14bbd4151887Looks like answer_persona_id is now unused. Should remove line 69 of dependent_condition.rb where answer_persona_id is being set.©i2012-03-07 21:30:37.0000002012-03-07 21:30:37.000000‚5¿ãO[]OAAhttps://github.com/sportngin/ngin/commit/59e9e242f4e1ac30f06a84d1051fe1cbb60c9e0a#commitcomment-1044943https://api.github.com/repos/sportngin/ngin/comments/104494359e9e242f4e1ac30f06a84d1051fe1cbb60c9e0aThose changes look great. Thanks!…2012-03-05 21:53:43.0000002012-03-05 21:53:43.000000‚¿ã?[]aAAhttps://github.com/sportngin/ngin/commit/59e9e242f4e1ac30f06a84d1051fe1cbb60c9e0a#commitcomment-1044927https://api.github.com/repos/sportngin/ngin/comments/104492759e9e242f4e1ac30f06a84d1051fe1cbb60c9e0a@pbyrne, I updated it in https://github.com/tstmedia/ngin/commit/e56c77f1aa74ce3bd84f9d7d0160943982a2b833.ñ¥2012-03-05 21:49:14.0000002012-03-05 21:49:14.000000„W¾þ9[]…AAhttps://github.com/sportngin/ngin/commit/59e9e242f4e1ac30f06a84d1051fe1cbb60c9e0a#commitcomment-1031993https://api.github.com/repos/sportngin/ngin/comments/103199359e9e242f4e1ac30f06a84d1051fe1cbb60c9e0aZheng, can you update this to a couple of INSERT SELECTs (don't forget to include an ORDER BY)? In its current form, it took over 3 hours to complete on staging 3. The logic checking whether the page node is in the trash and whether there's an existing photo or video gallery can be emulated in the JOIN and WHERE clauses.…2012-03-01 16:56:16.0000002012-03-01 16:56:16.000000‚¼òY]AAhttps://github.com/sportngin/ngin/commit/74c97718287a4f9584cf5a85b0092fa737359226#commitcomment-997653https://api.github.com/repos/sportngin/ngin/comments/99765374c97718287a4f9584cf5a85b0092fa737359226Will do.æœ2012-02-22 19:29:43.0000002012-02-22 19:29:43.000000 º € R …ZÖ€5#mM]Iq } ygi}AAnatejgreenehttps://avatars.githubusercontent.com/u/1409077?eceec7f2ab131f810402d3593b8bcfb7https://api.githu…)“½~kMUAi…A–PkMYEmyuce{yAAtetsuharuhttps://avatars.githubusercontent.com/u/248656?4ae4b19f1362ae962e838a7e1f3a5ef7https://api.github.com/users/tetsuharuhttps://github.com/tetsuharuhttps://api.github.com/users/tetsuharu/followershttps://api.github.com/users/tetsuharu/following{/other_user}https://api.github.com/users/tetsuharu/gists{/gist_id}https://api.github.com/users/tetsuharu/starred{/owner}{/repo}https://api.github.com/users/tetsuharu/subscriptionshttps://api.github.com/users/tetsuharu/orgshttps://api.github.com/users/tetsuharu/reposhttps://api.github.com/users/tetsuharu/events{/privacy}https://api.github.com/users/tetsuharu/received_eventsUserf2014-06-05 15:36:00.4304542014-06-05 15:36:00.430454…M“•!kM[Go { weg}{AANickLaMurohttps://avatar…5‹ã%kMWCkwsacywAAzhengjiahttps://avatars.githubusercontent.com/u/192933?a434c7b2837e1d09bc1a32b17e3ca2a6https://api.github.com/users/zhengjiahttps://github.com/zhengjiahttps://api.github.com/users/zhengjia/followershttps://api.github.com/users/zhengjia/following{/other_user}https://api.github.com/users/zhengjia/gists{/gist_id}https://api.github.com/users/zhengjia/starred{/owner}{/repo}https://api.github.com/users/zhengjia/subscriptionshttps://api.github.com/users/zhengjia/orgshttps://api.github.com/users/zhengjia/reposhttps://api.github.com/users/zhengjia/events{/privacy}https://api.github.com/users/zhengjia/received_eventsUserf2014-06-05 15:35:55.6912772014-06-05 15:35:55.691277…A–PkMYEmyuce{yAAtetsuharuhttps://avatars.githubusercontent.com/u/248656?4ae4b19f1362ae962e838a7e1f3a5ef7https://api.github.com/users/tetsuharuhttps://github.com/tetsuharuhttps://api.github.com/users/tetsuharu/followershttps://api.github.com/users/tetsuharu/following{/other_user}https://api.github.com/users/tetsuharu/gists{/gist_id}https://api.github.com/users/tetsuharu/starred{/owner}{/repo}https://api.github.com/users/tetsuharu/subscriptionshttps://api.github.com/users/tetsuharu/orgshttps://api.github.com/users/tetsuharu/reposhttps://api.github.com/users/tetsuharu/events{/privacy}https://api.github.com/users/tetsuharu/received_eventsUserf2014-06-05 15:36:00.4304542014-06-05 15:36:00.430454…M“•!kM[Go { weg}{AANickLaMurohttps://avatars.githubusercontent.com/u/314014?9d49804b4c96a1fa8a7a18381994eadbhttps://api.github.com/users/NickLaMurohttps://github.com/NickLaMurohttps://api.github.com/users/NickLaMuro/followershttps://api.github.com/users/NickLaMuro/following{/other_user}https://api.github.com/users/NickLaMuro/gists{/gist_id}https://api.github.com/users/NickLaMuro/starred{/owner}{/repo}https://api.github.com/users/NickLaMuro/subscriptionshttps://api.github.com/users/NickLaMuro/orgshttps://api.github.com/users/NickLaMuro/reposhttps://api.github.com/users/NickLaMuro/events{/privacy}https://api.github.com/users/NickLaMuro/received_eventsUserf2014-06-05 15:35:56.1001942014-06-05 15:35:56.100194…)“½~kMUAiuq_awuAAjphenowhttps://avatars.githubusercontent.com/u/319230?76bb44a71bc3f3a7037a39d69ae026e7https://api.github.com/users/jphenowhttps://github.com/jphenowhttps://api.github.com/users/jphenow/followershttps://api.github.com/users/jphenow/following{/other_user}https://api.github.com/users/jphenow/gists{/gist_id}https://api.github.com/users/jphenow/starred{/owner}{/repo}https://api.github.com/users/jphenow/subscriptionshttps://api.github.com/users/jphenow/orgshttps://api.github.com/users/jphenow/reposhttps://api.github.com/users/jphenow/events{/privacy}https://api.github.com/users/jphenow/received_eventsUserf2014-06-05 15:35:55.8191142014-06-05 15:35:55.819114  Ù Kÿ?ò‚PÅÂ6[]}AAhttps://github.com/sportngin/ngin/commit/5084ae9a399e53f0cb83319d5d7a80c9df0fb41e#commitcomment-1138998https://api.github.com/repos/sportngin/ngin/comments/1138998 3535084ae9a399e53f0cb83319d5d7a80c9df0fb41eThis can be simplified to just `controller == 'season'`.…2012-03-27 18:50:32.0000002012-03-27 18:50:32.000000„Hîy[]„sAAhttps://github.com/sportngin/ngin/commit/6cbf9b1cd18487ef43e945ab0de65930de7cb20c#commitcomment-1103737https://api.github.com/repos/sportngin/ngin/comments/11037376cbf9b1cd18487ef43e945ab0de65930de7cb20cThe permission check looks good. Lets tweak the warning message to mention user account as well as profile, so something like: "You are about to disconnect the user and profile from this registration entry. The user <%= @survey_result.user.name %> will no longer be able to access this registration entry."©i2012-03-19 16:32:05.0000002012-03-19 16:32:05.000000ƒ;îY[]‚YAAhttps://github.com/sportngin/ngin/commit/270c129fec7e002c196702822dd96c8df0401e39#commitcomment-1103705https://api.github.com/repos/sportngin/ngin/comments/1103705270c129fec7e002c196702822dd96c8df0401e39The notice/error messages should not use the term "orphanized" here. Use disconnected instead, so "Survey Result was successfully disconnected from the user account."©i2012-03-19 16:27:39.0000002012-03-19 16:27:39.000000‚GÂû@[]sAAhttps://github.com/sportngin/ngin/commit/92b035f1ea5ee57f67879ed1ae21d5e9f7969e73#commitcomment-1097152https://api.github.com/repos/sportngin/ngin/comments/109715292b035f1ea5ee57f67879ed1ae21d5e9f7969e73I will revert this commit for now so I don't forgetñ¥2012-03-17 04:50:26.0000002012-03-17 04:50:26.000000ƒ2Âû2[]‚GAAhttps://github.com/sportngin/ngin/commit/92b035f1ea5ee57f67879ed1ae21d5e9f7969e73#commitcomment-1097138https://api.github.com/repos/sportngin/ngin/comments/109713892b035f1ea5ee57f67879ed1ae21d5e9f7969e73Why is this changed? I intend to set standings_aggregation_level on standing_preferences table. The subseason settings should all be on the preference table.ñ¥2012-03-17 04:37:02.0000002012-03-17 04:37:02.000000ƒRÁú/[]ƒAAhttps://github.com/sportngin/ngin/commit/2d741fc3677051706f1e5cd0071a43754a6a518c#commitcomment-1080623https://api.github.com/repos/sportngin/ngin/comments/1080623332d741fc3677051706f1e5cd0071a43754a6a518cWe have a number of FormBuilder models that have a similar condition passer. I know that at least DateAnswer uses a similar case block. Would we want to be pulling this up at some point?Þþ2012-03-13 22:01:16.0000002012-03-13 22:02:17.000000†5Áí[]ˆMAAhttps://github.com/sportngin/ngin/commit/1135dcb5c7cc3099d56f8f8705d76e1743fa2a16#commitcomment-1078942https://api.github.com/repos/sportngin/ngin/comments/10789421135dcb5c7cc3099d56f8f8705d76e1743fa2a16We can go through team_sites like this, which for me is cutting the time down in half from 1 second to 1/2 a second: SELECT teams.* FROM sites INNER JOIN team_sites on sites.id = team_sites.site_id INNER JOIN teams on teams.id = team_sites.team_id WHERE (CONCAT_WS(' ', sites.name, sites.short_name, sites.domain_name, teams.name) like "%bantams%valley%hockey%" OR CONCAT_WS(' ', teams.name, sites.name, sites.short_name, sites.domain_name) like "%bantams%valley%hockey%") LIMIT 50©i2012-03-13 17:01:16.0000002012-03-13 17:01:16.000000ƒhÁí[]ƒ3AAhttps://github.com/sportngin/ngin/commit/1135dcb5c7cc3099d56f8f8705d76e1743fa2a16#commitcomment-1078926https://api.github.com/repos/sportngin/ngin/comments/10789261135dcb5c7cc3099d56f8f8705d76e1743fa2a16Removing page_nodes would prevent us from joining in sites, so I'm not sure that we can do that. However, removing those joins did drop the response time in my (unscientific) tests from 300–500ms to 200-300ms.…2012-03-13 16:59:36.0000002012-03-13 16:59:36.000000 ZÑ   –å¿œá£Z‚DÉ–8[]gAAhttps://github.com/sportngin/ngin/commit/9909f018b3169151a80d0131f7a6cf2f42120663#commitcomment-1198904https://api.github.com/repos/sportngin/ngin/comments/1198904 769909f018b3169151a80d0131f7a6cf2f42120663Not critical, but brokeen is spelled wrong :)©i2012-04-11 18:36:00.0000002012-04-11 18:36:00.000000‚9É&[]WAAhttps://github.com/sportngin/ngin/commit/21d1c4b209484c2bb9ef886e897f5564fb98e06c#commitcomment-1197734https://api.github.com/repos/sportngin/ngin/comments/119773421d1c4b209484c2bb9ef886e897f5564fb98e06cCode reviewed and QA'd . Looks good.€52012-04-11 14:27:30.0000002012-04-11 14:27:30.000000ƒ6Èêi[]‚OAAhttps://github.com/sportngin/ngin/commit/6c2448a2f2cfa3ac79a36801c95f53eb4f05aa0e#commitcomment-1193321https://api.github.com/repos/sportngin/ngin/comments/11933216c2448a2f2cfa3ac79a36801c95f53eb4f05aa0eI looked at using page_node.expire_page_cache, but this expires all the pages on the site since when a page_node. Went with this for now which is used elsewhere.©i2012-04-10 15:36:53.0000002012-04-10 15:36:53.000000‚È’I[]!AAhttps://github.com/sportngin/ngin/commit/ba554f64e3c8a6127bed363ee54131b6a8f512a6#commitcomment-1182025https://api.github.com/repos/sportngin/ngin/comments/1182025ba554f64e3c8a6127bed363ee54131b6a8f512a6Looks good©i2012-04-06 16:27:07.0000002012-04-06 16:27:07.000000„!È’A[]„!AAhttps://github.com/sportngin/ngin/commit/91e83a3d8864df035990d9aebf7820f70dc3dc35#commitcomment-1182017https://api.github.com/repos/sportngin/ngin/comments/1182017 491e83a3d8864df035990d9aebf7820f70dc3dc35All other things being equal, I'd prefer to see this as a regular table with an ID, and using `has_many :through`j rather than a `has_and_belogns_to_many`. This gives us the flexibility down the line to push logic into the join model if we want to, with no downside.…2012-04-06 16:23:13.0000002012-04-06 16:23:13.000000ƒ,È’$[]‚7AAhttps://github.com/sportngin/ngin/commit/2b22716c0834dabf951db87b19828e60f8b1c463#commitcomment-1181988https://api.github.com/repos/sportngin/ngin/comments/118198842b22716c0834dabf951db87b19828e60f8b1c463This could be updated to an image_tag (for html sanitation and to get the appropriate asset server host), a la `image_tag('/app_images/spacer.gif')`.…2012-04-06 16:09:38.0000002012-04-06 16:09:38.000000„È&[]ƒmAAhttps://github.com/sportngin/ngin/commit/ddc27676bd4f72860e0a156b92b01833142bac59#commitcomment-1181606https://api.github.com/repos/sportngin/ngin/comments/1181606ddc27676bd4f72860e0a156b92b01833142bac59Justin, is there a corresponding pull request for Stat NGIN? It looks like the team_stats/scores API endpoint is new. Also, I would consider moving the undo_http_mock! class into our test_helper.rb file so it is available to other tests.Aq2012-04-06 13:45:24.0000002012-04-06 13:45:24.000000„,ǃ[]„;AAhttps://github.com/sportngin/ngin/commit/f6cfa984d2a5e93841d690ef37d6aa3365054915#commitcomment-1163775https://api.github.com/repos/sportngin/ngin/comments/1163775f6cfa984d2a5e93841d690ef37d6aa3365054915Nate, If you run this rake task now I think it will fail. Two issues on line 42... respond_to? instead of responds_to? and it takes a string or a symbol as an argument, so pn.node.respond_to?(:games) is what you want. And spacing on lines 44 and 46 is off a bit.©i2012-04-02 18:53:37.0000002012-04-02 18:53:37.000000‚*Åç[]9AAhttps://github.com/sportngin/ngin/commit/2db7b9dd0373e74ac3858cd0e93abcdb12287c99#commitcomment-1143687https://api.github.com/repos/sportngin/ngin/comments/11436872db7b9dd0373e74ac3858cd0e93abcdb12287c99Looks good, nice work.©i2012-03-28 15:25:31.0000002012-03-28 15:25:31.000000 $ É Œ ] yƒdË–[]ƒ%AAhttps://github.com/sportngin/ngin/commit/88bb6d10873a2fe2115ae0b7c8d69c4f9a35bfcb#commitcomment-1231618https://api.github.com/repos/sportngin/ngin/comments/12316183388bb6d10873a2fe2115ae0b7c8d69c4f9a35bfcbinstead of creating a method for this that wont be used anywhere else a proc would work really well here. ```ruby after_update :cascade_name, :if => lambda { name_changed? || button_title_changed? } ``` º†2012-04-19 13:44:53.0000002012-04-19 13:44:53.000000‰ÊŸ%[]ŽAAhttps://github.com/sportngin/ngin/commit/d1e0f6036aeaa0da091abbb53c3de23ba97ffcd1#commitcomment-1216421https://api.github.com/repos/sportngin/ngin/comments/1216421>451d1e0f6036aeaa0da091abbb53c3de23ba97ffcd1So here is whats up with the current code: Say we have three dib items in a session: * Dib1 has a credit value of 1 * Dib2 has a credit value of 1.5 * Dib3 has a credit value of 1.9 Now the current form uses just a single value for filtering via credit value, and it will take that value and anything less than one value more. So if I want to filter all the Dibs in this where the credit value is 1, then I would get all of the dibs mentioned above back. If I search by 2 or 0, I would get no dib items back. But if I were to search by 0.9 credits (silly, I know), you would get the first two back, and the third would be left off. Because the credits we are searching for are already in float style, you don't have to change it for the conditions string so I don't think that this is necessary for this line. But again, I am the new guy, so let me know if you think otherwise.Êž2012-04-16 15:02:10.0000002012-04-16 15:15:40.000000ƒ_ÊZ[]ƒAAhttps://github.com/sportngin/ngin/commit/d1e0f6036aeaa0da091abbb53c3de23ba97ffcd1#commitcomment-1216218https://api.github.com/repos/sportngin/ngin/comments/1216218>451d1e0f6036aeaa0da091abbb53c3de23ba97ffcd1Oh, now that I am looking at it again, I am not really sure. I feel like changing it from what it was will break something... and since there are no tests, I have nothing to go off of... Thoughts?Êž2012-04-16 14:36:20.0000002012-04-16 14:36:20.000000‚XÊ0[] AAhttps://github.com/sportngin/ngin/commit/d1e0f6036aeaa0da091abbb53c3de23ba97ffcd1#commitcomment-1216176https://api.github.com/repos/sportngin/ngin/comments/1216176>451d1e0f6036aeaa0da091abbb53c3de23ba97ffcd1Yeah, it probably should. Not sure how I missed that. Thanks.Êž2012-04-16 14:27:16.0000002012-04-16 14:27:16.000000‚*Ê.[]1AAhttps://github.com/sportngin/ngin/commit/d1e0f6036aeaa0da091abbb53c3de23ba97ffcd1#commitcomment-1216174https://api.github.com/repos/sportngin/ngin/comments/1216174=450d1e0f6036aeaa0da091abbb53c3de23ba97ffcd1Right, good catch.Êž2012-04-16 14:26:54.0000002012-04-16 14:26:54.000000‚8ʇ;[]MAAhttps://github.com/sportngin/ngin/commit/d1e0f6036aeaa0da091abbb53c3de23ba97ffcd1#commitcomment-1213371https://api.github.com/repos/sportngin/ngin/comments/1213371>451d1e0f6036aeaa0da091abbb53c3de23ba97ffcd1Should this have a to_f as well?€52012-04-15 23:54:39.0000002012-04-15 23:54:39.000000‚Vʇ:[]AAhttps://github.com/sportngin/ngin/commit/d1e0f6036aeaa0da091abbb53c3de23ba97ffcd1#commitcomment-1213370https://api.github.com/repos/sportngin/ngin/comments/1213370=450d1e0f6036aeaa0da091abbb53c3de23ba97ffcd1Remove the AND from this string as the JOIN below will add it€52012-04-15 23:54:08.0000002012-04-15 23:54:08.000000ƒWÉ–L[]ƒ AAhttps://github.com/sportngin/ngin/commit/9909f018b3169151a80d0131f7a6cf2f42120663#commitcomment-1198924https://api.github.com/repos/sportngin/ngin/comments/1198924869909f018b3169151a80d0131f7a6cf2f42120663I think we want to be very careful here and err on the side of not deleting stuff. To this end lets change this line to be: if team_instance && team_instance.all_page_nodes.in_trash.count > 0©i2012-04-11 18:40:56.0000002012-04-11 18:40:56.000000 ÊÊ„} 7 …g­=%mM_Ks  {ikAAdustinfarrishttps://avatars.githubusercontent.co…5—ÕbkMWCkwsacywAAedleberthttps://avatars.githubusercontent.com/u/387810?34e92ab37b405e5abed7e7c8bf7ba5b7https://api.github.com/users/edleberthttps://github.com/edleberthttps://api.github.com/users/edlebert/followershttps://api.github.com/users/edlebert/following{/other_user}https://api.github.com/users/edlebert/gists{/gist_id}https://api.github.com/users/edlebert/starred{/owner}{/repo}https://api.github.com/users/edlebert/subscriptionshttps://api.github.com/users/edlebert/orgshttps://api.github.com/users/edlebert/reposhttps://api.github.com/users/edlebert/events{/privacy}https://api.github.com/users/edlebert/received_eventsUserf2014-06-05 15:35:55.5853042014-06-05 15:35:55.585304…t˜Ë9'kMaMu}kmAAjessehouchinshttps://avatars.githubusercontent.com/u/402873?8d30b149d2010f0960482826bcc1d008https://api.github.com/users/jessehouchinshttps://github.com/jessehouchinshttps://api.github.com/users/jessehouchins/followershttps://api.github.com/users/jessehouchins/following{/other_user}https://api.github.com/users/jessehouchins/gists{/gist_id}https://api.github.com/users/jessehouchins/starred{/owner}{/repo}https://api.github.com/users/jessehouchins/subscriptionshttps://api.github.com/users/jessehouchins/orgshttps://api.github.com/users/jessehouchins/reposhttps://api.github.com/users/jessehouchins/events{/privacy}https://api.github.com/users/jessehouchins/received_eventsUserf2014-06-05 15:35:56.8038322014-06-05 15:35:56.803832…5¢˜?kMWCkwsacywAAbryceschhttps://avatars.githubusercontent.com/u/560191?e736e1465215cd0582fe8dc263692904https://api.github.com/users/bryceschhttps://github.com/bryceschhttps://api.github.com/users/brycesch/followershttps://api.github.com/users/brycesch/following{/other_user}https://api.github.com/users/brycesch/gists{/gist_id}https://api.github.com/users/brycesch/starred{/owner}{/repo}https://api.github.com/users/brycesch/subscriptionshttps://api.github.com/users/brycesch/orgshttps://api.github.com/users/brycesch/reposhttps://api.github.com/users/brycesch/events{/privacy}https://api.github.com/users/brycesch/received_eventsUserf2014-06-05 15:35:55.5167582014-06-05 15:35:55.516758…Yª„ #kM]Iq } ygi}AAmagedmakledhttps://avatars.githubusercontent.com/u/688652?b73a57e56227d78b19437ae9f219f681https://api.github.com/users/magedmakledhttps://github.com/magedmakledhttps://api.github.com/users/magedmakled/followershttps://api.github.com/users/magedmakled/following{/other_user}https://api.github.com/users/magedmakled/gists{/gist_id}https://api.github.com/users/magedmakled/starred{/owner}{/repo}https://api.github.com/users/magedmakled/subscriptionshttps://api.github.com/users/magedmakled/orgshttps://api.github.com/users/magedmakled/reposhttps://api.github.com/users/magedmakled/events{/privacy}https://api.github.com/users/magedmakled/received_eventsUserf2014-06-05 15:36:02.3502622014-06-05 15:36:02.350262…f¬ýp%kM_Ks  {ikAAtravisdahlkehttps://avatars.githubusercontent.com/u/737008?adaba90f7b5c911aea99b1f3568f6eb2https://api.github.com/users/travisdahlkehttps://github.com/travisdahlkehttps://api.github.com/users/travisdahlke/followershttps://api.github.com/users/travisdahlke/following{/other_user}https://api.github.com/users/travisdahlke/gists{/gist_id}https://api.github.com/users/travisdahlke/starred{/owner}{/repo}https://api.github.com/users/travisdahlke/subscriptionshttps://api.github.com/users/travisdahlke/orgshttps://api.github.com/users/travisdahlke/reposhttps://api.github.com/users/travisdahlke/events{/privacy}https://api.github.com/users/travisdahlke/received_eventsUserf2014-06-05 15:35:55.6049282014-06-05 15:35:55.604928 ô¡ >  £œppô‚wÎÑ[]QAAhttps://github.com/sportngin/ngin/commit/e1836388fdd5bdb20dd637b93df1c7b1336ab6a7#commitcomment-1288347https://api.github.com/repos/sportngin/ngin/comments/1288347e1836388fdd5bdb20dd637b93df1c7b1336ab6a7My layman eyes can't tell but it looks ok. I'm told Ian has also reviewed. If he's good, I'm good.ðž2012-05-03 16:30:47.0000002012-05-03 16:30:47.000000ƒ{ΨA[]ƒYAAhttps://github.com/sportngin/ngin/commit/f2b76021a57ad001a51089603f83b3090bbf2785#commitcomment-1283137https://api.github.com/repos/sportngin/ngin/comments/1283137f2b76021a57ad001a51089603f83b3090bbf2785Bryce ... I'm not sure I like this solution of downloading the original. What is this image_proxy action used for? Generally we don't want to use original photos anywhere unless specifically requested as they could be quite large.©i2012-05-02 15:44:52.0000002012-05-02 15:44:52.000000„'ÎŽ'[]„1AAhttps://github.com/sportngin/ngin/commit/0e9cc5c7cbde72e514183c344eebb0aed34aa696#commitcomment-1279783https://api.github.com/repos/sportngin/ngin/comments/12797830e9cc5c7cbde72e514183c344eebb0aed34aa696I'm concerned about the change from "that" to "this". When you deal with timers and ajaxy thingies, "this" can often become something you don't expect. The reason there was a "that" was to avoid problems when "this" becomes something else (like an XMLHTTP object or a Timer)ðž2012-05-01 21:42:30.0000002012-05-01 21:42:30.000000‚|Î1[][AAhttps://github.com/sportngin/ngin/commit/ea9bed92e93db39ea36c972523901da447ab3356#commitcomment-1278129https://api.github.com/repos/sportngin/ngin/comments/1278129ea9bed92e93db39ea36c972523901da447ab3356code looks good. as far as I can tell, donation and monetary question elements are working as intended.Œ?2012-05-01 14:36:06.0000002012-05-01 14:36:06.000000…Íå"[]…_AAhttps://github.com/sportngin/ngin/commit/7ec74f323c0b173171b715ceb1a8f10fb2e4b106#commitcomment-1274530https://api.github.com/repos/sportngin/ngin/comments/1274530 277ec74f323c0b173171b715ceb1a8f10fb2e4b106The comment isn't quite right here. Maybe the code is still sound, not sure. There could be two team instance page_nodes in the season, the playoff one might be in the trash and the regular season might not be. If we simply need a nil check on team_instances.first.season then this is probably fine, but lets rephrase or remove the comment which is not correct.©i2012-04-30 16:40:28.0000002012-04-30 16:40:28.000000‚ZÍá []AAhttps://github.com/sportngin/ngin/commit/f6ddb17622bea5c2f4d9353448d2a3d87d621c93#commitcomment-1273993https://api.github.com/repos/sportngin/ngin/comments/1273993f6ddb17622bea5c2f4d9353448d2a3d87d621c93This one is ready for deploy and the Star Tribune needs it out today.©i2012-04-30 14:37:57.0000002012-04-30 14:37:57.000000‚7Í­[]SAAhttps://github.com/sportngin/ngin/commit/65a2189cf7e162424df3e088a602c1f5396a4e31#commitcomment-1267328https://api.github.com/repos/sportngin/ngin/comments/126732865a2189cf7e162424df3e088a602c1f5396a4e31qa'd and code reviewed. good to go.Œ?2012-04-27 16:18:08.0000002012-04-27 16:18:08.000000‚^ͬH[]AAhttps://github.com/sportngin/ngin/commit/1d897d80b7b26e985d236fef616ecaf91eb0c561#commitcomment-1267272https://api.github.com/repos/sportngin/ngin/comments/1267272841d897d80b7b26e985d236fef616ecaf91eb0c561picky, picky. onSchedulePage variable doesn't follow ruby style guidesðž2012-04-27 16:03:03.0000002012-04-27 16:03:03.000000‚ZÍc[]AAhttps://github.com/sportngin/ngin/commit/37ace9e19f4bd102e12f74b13d9fd8e04df86011#commitcomment-1263331https://api.github.com/repos/sportngin/ngin/comments/126333137ace9e19f4bd102e12f74b13d9fd8e04df86011maybe get rid of the magic number. but apart from that it looks good.Œ?2012-04-26 20:38:25.0000002012-04-26 20:38:25.000000 ÃÍ £ y ÇÈŒÀ- ÂAÏÖ[]gAAhttps://github.com/sportngin/ngin/commit/7178a7d7af5e0a37679270d7a3b027f968e434aa#commitcomment-1305361https://api.github.com/repos/sportngin/ngin/comments/13053617178a7d7af5e0a37679270d7a3b027f968e434aaLooks good, verified on staging. Makes sense.ðž2012-05-08 14:04:04.0000002012-05-08 14:04:04.000000‚Ï°c[]#AAhttps://github.com/sportngin/ngin/commit/91713efdabc0f822da8aa2408411acad1eed53fd#commitcomment-1300579https://api.github.com/repos/sportngin/ngin/comments/130057991713efdabc0f822da8aa2408411acad1eed53fdGood to go.€52012-05-07 14:55:23.0000002012-05-07 14:55:23.000000ƒÎú[]AAhttps://github.com/sportngin/ngin/commit/ff78b7f335ead36e093e29c471e21bebacfd83fe#commitcomment-1293585https://api.github.com/repos/sportngin/ngin/comments/1293585ff78b7f335ead36e093e29c471e21bebacfd83feMakes sense as sub_survey_result belongs_to :persona. Can't reproduce in staging because data does not exist. Good to goðž2012-05-04 17:32:14.0000002012-05-04 17:32:14.000000…GÎö([]†iAAhttps://github.com/sportngin/ngin/commit/eb9fe48384f2fb6da8abf66fe135686f451a1a1a#commitcomment-1293096https://api.github.com/repos/sportngin/ngin/comments/1293096Q275eb9fe48384f2fb6da8abf66fe135686f451a1a1aTravis, I believe @leagues is used in two places. When creating a new team (which is the bug you are looking at) and in app/views/team/_form.html.erb which I'm guessing the logic to remove the league that the team is already in was done for. Let me know if that doesn't make sense and I can explain further. Basically I'm guessing that this line: @leagues = @leagues - [league] is correct for one scenario but not for the other.©i2012-05-04 15:37:56.0000002012-05-04 15:37:56.000000‚7Îö%[]SAAhttps://github.com/sportngin/ngin/commit/9bcce58200fc8f6aa39c545437c84ce137e79fa0#commitcomment-1293093https://api.github.com/repos/sportngin/ngin/comments/12930939bcce58200fc8f6aa39c545437c84ce137e79fa0qa'd and code reviewed. good to go.Œ?2012-05-04 15:37:19.0000002012-05-04 15:37:19.000000ƒzÎö"[]ƒWAAhttps://github.com/sportngin/ngin/commit/89e509b80d698d2a741995ed5643f51373729b32#commitcomment-1293090https://api.github.com/repos/sportngin/ngin/comments/129309089e509b80d698d2a741995ed5643f51373729b32Recreation of error on stage3 and fix on stage1 verified. Code that read :site => options stands out as incorrect. as you want :site to equal a @site. The options hash here contains a :site => @site, so this works. Good to go.ðž2012-05-04 15:36:59.0000002012-05-04 15:36:59.000000ƒ-Îõ[]‚5AAhttps://github.com/sportngin/ngin/commit/eb9fe48384f2fb6da8abf66fe135686f451a1a1a#commitcomment-1293055https://api.github.com/repos/sportngin/ngin/comments/1293055Q275eb9fe48384f2fb6da8abf66fe135686f451a1a1a@zhengjia What is this intended to do? The effect is the current league is being hidden in the team selector when trying to add a team to a league. >ð2012-05-04 15:27:53.0000002012-05-04 15:28:23.000000‚%Îõ[]/AAhttps://github.com/sportngin/ngin/commit/198f27ddee2748381a45885bcd6f3465c488fbff#commitcomment-1292952https://api.github.com/repos/sportngin/ngin/comments/1292952198f27ddee2748381a45885bcd6f3465c488fbfflooks good to go.Œ?2012-05-04 15:04:32.0000002012-05-04 15:04:32.000000‚%Îô{[]/AAhttps://github.com/sportngin/ngin/commit/ce48e0dcc383a10693116f55ded82dd53aa33504#commitcomment-1292923https://api.github.com/repos/sportngin/ngin/comments/1292923ce48e0dcc383a10693116f55ded82dd53aa33504ready for deploy.Œ?2012-05-04 15:00:14.0000002012-05-04 15:00:14.000000‚.Îô-[]AAAhttps://github.com/sportngin/ngin/commit/cdd5980305f34316b7d76e87c612c23c58491b1d#commitcomment-1292845https://api.github.com/repos/sportngin/ngin/comments/1292845cdd5980305f34316b7d76e87c612c23c58491b1dqa'd and code reviewed. +1Œ?2012-05-04 14:43:37.0000002012-05-04 14:43:37.000000 Rf  Õ º†+±R‚Zб-[]AAhttps://github.com/sportngin/ngin/commit/d21c3ebec92cade99a8a5cb470ce982924b0dc02#commitcomment-1317037https://api.github.com/repos/sportngin/ngin/comments/131703712d21c3ebec92cade99a8a5cb470ce982924b0dc02sorry i forgot a comma "no, subseason is required for a season"º†2012-05-10 18:49:32.0000002012-05-10 18:49:32.000000‚uб'[]GAAhttps://github.com/sportngin/ngin/commit/d21c3ebec92cade99a8a5cb470ce982924b0dc02#commitcomment-1317031https://api.github.com/repos/sportngin/ngin/comments/131703112d21c3ebec92cade99a8a5cb470ce982924b0dc02You're the one that said it was possible: "no subseason is required for a season", not me. :)…2012-05-10 18:48:19.0000002012-05-10 18:48:19.000000‚Vб[] AAhttps://github.com/sportngin/ngin/commit/d21c3ebec92cade99a8a5cb470ce982924b0dc02#commitcomment-1317022https://api.github.com/repos/sportngin/ngin/comments/131702212d21c3ebec92cade99a8a5cb470ce982924b0dc02i suppose but how can you have a season without any subseasonsº†2012-05-10 18:46:29.0000002012-05-10 18:46:29.000000„/б []„;AAhttps://github.com/sportngin/ngin/commit/d21c3ebec92cade99a8a5cb470ce982924b0dc02#commitcomment-1317003https://api.github.com/repos/sportngin/ngin/comments/131700312d21c3ebec92cade99a8a5cb470ce982924b0dc02Separate from the conversation you two are having, if `s.subeasons.first` is nil, this will throw a warning (now with Ruby 1.8) and an exception (once we deploy Ruby 1.9) when you try to access `NilClass#id`. Wrap it in a `try(:id)` or check that `s.subseasons.first` is present.…2012-05-10 18:40:52.0000002012-05-10 18:40:52.000000„Zа|[]…AAhttps://github.com/sportngin/ngin/commit/d21c3ebec92cade99a8a5cb470ce982924b0dc02#commitcomment-1316988https://api.github.com/repos/sportngin/ngin/comments/131698812d21c3ebec92cade99a8a5cb470ce982924b0dc02I dont think the issues surrounding subseason copy have anything to do with a season not having any subseasons. The issue here is that the league only has one season since its the last season for that solo team league and when you move it to the trash it tries to update this to another subseason but there aren't anymore.º†2012-05-10 18:36:34.0000002012-05-10 18:36:34.000000ƒ7аc[]‚KAAhttps://github.com/sportngin/ngin/commit/d21c3ebec92cade99a8a5cb470ce982924b0dc02#commitcomment-1316963https://api.github.com/repos/sportngin/ngin/comments/131696312d21c3ebec92cade99a8a5cb470ce982924b0dc02But haven't we been having all sorts of problems surrounding subseason copying which could render this nil? If you think it won't be a problem, I'll let it go.ðž2012-05-10 18:30:50.0000002012-05-10 18:30:50.000000‚<ЯM[]WAAhttps://github.com/sportngin/ngin/commit/d21c3ebec92cade99a8a5cb470ce982924b0dc02#commitcomment-1316813https://api.github.com/repos/sportngin/ngin/comments/131681312d21c3ebec92cade99a8a5cb470ce982924b0dc02no subseason is required for a seasonº†2012-05-10 18:04:09.0000002012-05-10 18:04:09.000000‚KЯ7[]uAAhttps://github.com/sportngin/ngin/commit/d21c3ebec92cade99a8a5cb470ce982924b0dc02#commitcomment-1316791https://api.github.com/repos/sportngin/ngin/comments/131679112d21c3ebec92cade99a8a5cb470ce982924b0dc02is it possible that s.subseasons.first could be nil?ðž2012-05-10 17:59:40.0000002012-05-10 17:59:40.000000ƒÏÖ4[]‚ AAhttps://github.com/sportngin/ngin/commit/7178a7d7af5e0a37679270d7a3b027f968e434aa#commitcomment-1305396https://api.github.com/repos/sportngin/ngin/comments/13053967178a7d7af5e0a37679270d7a3b027f968e434aaSpoke with Andy. He's going to ping a larger group to validate the assumption behind this change before we say it is good to go.ðž2012-05-08 14:11:17.0000002012-05-08 14:11:17.000000 —t … c *÷ÔêYÄ—‚(Ó”*[]5AAhttps://github.com/sportngin/ngin/commit/06b7751d3201f413d97b34ae2ed05e260d913c08#commitcomment-1362474https://api.github.com/repos/sportngin/ngin/comments/136247406b7751d3201f413d97b34ae2ed05e260d913c08Perfect! Good to go.©]2012-05-22 20:18:04.0000002012-05-22 20:18:04.000000…Ó‹O[]…}AAhttps://github.com/sportngin/ngin/commit/8cb197b56e05decd20be767a727b26592e7418ce#commitcomment-1361359https://api.github.com/repos/sportngin/ngin/comments/1361359228cb197b56e05decd20be767a727b26592e7418ceMinor style suggestion (using #map instead of appending to an array in an #each): ```ruby output_types = MobileNotification.notification_type_values.map do |notification_type| {:display => notification_type[0], :value => notification_type[1]} end ``` Even better, wrapping that up in a method on MobileNotification than doing it in the controller where it can't be reused.…2012-05-22 16:59:50.0000002012-05-22 17:00:33.000000ƒ Ó†[]{AAhttps://github.com/sportngin/ngin/commit/b16109a609e2cce4988db270dc00d07a7d378ea8#commitcomment-1360663https://api.github.com/repos/sportngin/ngin/comments/1360663b16109a609e2cce4988db270dc00d07a7d378ea8@NickLaMuro, not a big deal but can you wrap this migration in Rails.env.production?. The migration didn't run locally.ñ¥2012-05-22 15:06:49.0000002012-05-22 15:07:57.000000ƒeÒèW[]ƒ'AAhttps://github.com/sportngin/ngin/commit/c6152fdd1e201d27283c9ad63b9d5abb570a508d#commitcomment-1356887https://api.github.com/repos/sportngin/ngin/comments/135688785c6152fdd1e201d27283c9ad63b9d5abb570a508dThis works if `innings` is a fixed number, but when `innings` is not a fixed number (it is an array if the `away_team_stats` or `home_team_stats` are present in a non live scored game) this is not helpful.Êž2012-05-21 19:43:50.0000002012-05-21 19:43:50.000000‚Ò‹}[]!AAhttps://github.com/sportngin/ngin/commit/1f55f58179e5669a52d9b5eea6ebb6a9328d1248#commitcomment-1345021https://api.github.com/repos/sportngin/ngin/comments/13450211f55f58179e5669a52d9b5eea6ebb6a9328d1248Seriously.…2012-05-17 20:14:57.0000002012-05-17 20:14:57.000000‚.Ò‹|[]AAAhttps://github.com/sportngin/ngin/commit/1f55f58179e5669a52d9b5eea6ebb6a9328d1248#commitcomment-1345020https://api.github.com/repos/sportngin/ngin/comments/13450201f55f58179e5669a52d9b5eea6ebb6a9328d1248Dude, this was a bad idea!…2012-05-17 20:14:28.0000002012-05-17 20:14:28.000000‚4ÑÔc[]MAAhttps://github.com/sportngin/ngin/commit/342c901678be9483973b868412d63eef99dd3b4b#commitcomment-1337955https://api.github.com/repos/sportngin/ngin/comments/1337955342c901678be9483973b868412d63eef99dd3b4bLooks good, works on staging. +1ðž2012-05-16 14:13:19.0000002012-05-16 14:13:19.000000‚Ѭ[]AAhttps://github.com/sportngin/ngin/commit/80b50a3cc17e05a0c30ad9d4ebc3d83a1e7133da#commitcomment-1332863https://api.github.com/repos/sportngin/ngin/comments/133286380b50a3cc17e05a0c30ad9d4ebc3d83a1e7133daGood Ideaº†2012-05-15 13:33:55.0000002012-05-15 13:33:55.000000ƒjѬr[]ƒ7AAhttps://github.com/sportngin/ngin/commit/80b50a3cc17e05a0c30ad9d4ebc3d83a1e7133da#commitcomment-1332850https://api.github.com/repos/sportngin/ngin/comments/133285080b50a3cc17e05a0c30ad9d4ebc3d83a1e7133daCould we get some more context in this error message? You can pass some custom parameters to get logged with the error, like so: `NewRelic::Agent.notice_error(e, :custom_params => {:task => task, :args => args})`.…2012-05-15 13:32:33.0000002012-05-15 13:32:33.000000ƒÑ‹z[]qAAhttps://github.com/sportngin/ngin/commit/6dbca05f6e3be85b9639b5309fb1f80f33128d71#commitcomment-1328634https://api.github.com/repos/sportngin/ngin/comments/13286346dbca05f6e3be85b9639b5309fb1f80f33128d71Good to go. Seems straightforward. There is a check in place to ensure "resource" is available in this context. +1ðž2012-05-14 15:42:35.0000002012-05-14 15:42:35.000000 V =  ïÔ¹žÄ‘qV‚Ôq[]AAhttps://github.com/sportngin/ngin/commit/9496ad0a87c6d88caf1bb3ffbc24c07f23b024ee#commitcomment-1378417https://api.github.com/repos/sportngin/ngin/comments/13784179496ad0a87c6d88caf1bb3ffbc24c07f23b024ee+1ðž2012-05-25 20:28:22.0000002012-05-25 20:28:22.000000‚Ôp[]AAhttps://github.com/sportngin/ngin/commit/dcb82a8d2529ef73767cf2b358584457a6c26aa3#commitcomment-1378416https://api.github.com/repos/sportngin/ngin/comments/1378416dcb82a8d2529ef73767cf2b358584457a6c26aa3nice +1ðž2012-05-25 20:26:10.0000002012-05-25 20:26:10.000000‚.Ôl[]9AAhttps://github.com/sportngin/ngin/commit/dcb82a8d2529ef73767cf2b358584457a6c26aa3#commitcomment-1378412https://api.github.com/repos/sportngin/ngin/comments/1378412317dcb82a8d2529ef73767cf2b358584457a6c26aa3ah, you reverted here.ðž2012-05-25 20:25:03.0000002012-05-25 20:25:03.000000‚PÔh[]}AAhttps://github.com/sportngin/ngin/commit/8e36c2b30ee422a9f09642efc547b20c15883753#commitcomment-1378408https://api.github.com/repos/sportngin/ngin/comments/13784083178e36c2b30ee422a9f09642efc547b20c15883753Is this to keep from displaying duplicates for personas?ðž2012-05-25 20:24:08.0000002012-05-25 20:24:08.000000ƒÔX[][AAhttps://github.com/sportngin/ngin/commit/8e36c2b30ee422a9f09642efc547b20c15883753#commitcomment-1378392https://api.github.com/repos/sportngin/ngin/comments/13783922218e36c2b30ee422a9f09642efc547b20c15883753Is there a reason you removed the test self.originator.deliver_to_orphans? ? Is this handled elsewere?ðž2012-05-25 20:19:32.0000002012-05-25 20:19:32.000000‚ÔP[]AAhttps://github.com/sportngin/ngin/commit/a5d7ec36e7c4b3204bf36ce8492a9f3c51905e82#commitcomment-1378384https://api.github.com/repos/sportngin/ngin/comments/1378384a5d7ec36e7c4b3204bf36ce8492a9f3c51905e82+1ðž2012-05-25 20:17:07.0000002012-05-25 20:17:07.000000‚ÔL[]AAhttps://github.com/sportngin/ngin/commit/8b1eecb1bdaf02b3e3d45cc5f7a92d3daa5b6bc3#commitcomment-1378380https://api.github.com/repos/sportngin/ngin/comments/13783808b1eecb1bdaf02b3e3d45cc5f7a92d3daa5b6bc3+1ðž2012-05-25 20:16:32.0000002012-05-25 20:16:32.000000‚ÔŽd[]AAhttps://github.com/sportngin/ngin/commit/c5c14a6e44487406b77459028c80a1607dd2d07b#commitcomment-1378148https://api.github.com/repos/sportngin/ngin/comments/1378148c5c14a6e44487406b77459028c80a1607dd2d07bok€52012-05-25 19:15:17.0000002012-05-25 19:15:17.000000‚"ÔŠt[])AAhttps://github.com/sportngin/ngin/commit/ac125326819bf1329a320856a76022b468374402#commitcomment-1377652https://api.github.com/repos/sportngin/ngin/comments/1377652ac125326819bf1329a320856a76022b468374402makes sense +1ðž2012-05-25 17:22:20.0000002012-05-25 17:22:20.000000‚"Ô‰[])AAhttps://github.com/sportngin/ngin/commit/d66d5711df8c57de5f7f0be8cd30e5295c1889e9#commitcomment-1377431https://api.github.com/repos/sportngin/ngin/comments/1377431d66d5711df8c57de5f7f0be8cd30e5295c1889e9makes sense +1ðž2012-05-25 16:09:45.0000002012-05-25 16:09:45.000000‡>Ó­j[]Š_AAhttps://github.com/sportngin/ngin/commit/018d6e4fa5030000d290514cecc149a3ef18cd55#commitcomment-1365738https://api.github.com/repos/sportngin/ngin/comments/1365738018d6e4fa5030000d290514cecc149a3ef18cd55Crap, I knew I was forgetting something with yesterday's feedback. You can rewrite these blocks to be a little bit more clear, capturing the portions of the nested array into named variables instead of accessing the elements of that array namelessly: ```ruby output_types = MobileNotification.notification_type_values.map do |display, value| {:display => display, :value => value} end ``` Also, seeing here in this commit that the logic is duplicated in two places, I'd prefer to see this as a method on MobileNotification. If we think this is generic enough, we could also/instead add it to the enumerated_field gem itself to get this type of output for all enumerated fields.…2012-05-23 12:50:52.0000002012-05-23 12:50:52.000000 ˜q V %  ܤM˜‡0ݧm[]Š9AAhttps://github.com/sportngin/ngin/commit/1ca7ca1fd9eeb188b07a1658528845799fbca8e1#commitcomment-1528813https://api.github.com/repos/sportngin/ngin/comments/152881321171ca7ca1fd9eeb188b07a1658528845799fbca8e1I think we should remove these two lines and rely on 'home_team_score_api' and 'away_team_score_api' for performance reason. These two lines here will make games#index call stat ngin for every game. 'home_team_score_api' and 'away_team_score_api' are optimized. They are returned in the games api by default. If chaining is used we have to specify to call them explicitly. e.g ``` curl --user drivetrainapi:ME45PrAk -H "NGIN-API-TOKEN: c4ecd5d34ce10d5d77794915626e856c89055b84254f475903c3419469002930" -H "NGIN-API-VERSION: 0.1" -g "http://127.0.0.1:3000/api2/games/2154762?chaining[methods]=home_team_score_api&chaining[methods]=away_team_score_api" -k ```ñ¥2012-07-02 17:09:11.0000002012-07-02 17:09:11.000000ˆRÛòE[]Œ}AAhttps://github.com/sportngin/ngin/commit/7e666e9755cc59a91919be1815543e5a5ee30056#commitcomment-1505605https://api.github.com/repos/sportngin/ngin/comments/150560512747e666e9755cc59a91919be1815543e5a5ee30056I think this is good way to reduce the code down a bit, but the only issue I have with this route is there is an extra and unneeded database call tacked on if the `@page_sport_name` is overwritten in the following `if` block. I normally would be okay with this, but this is something that is done on almost every page. It probably is a small performance hit, but if we can save some logic on each page, I think that would be a good idea. My suggestion to avoid this is to take this line and put it under the following `if` block and change it slightly to this: ```ruby @page_sport_name = @site.sports if @page_sport_name.blank? and @site.respond_to?(:sports) ``` This will have the assignment of `@page_sport_name` assigned here if it wasn't assigned before, and the `if` will short circuit and move on if it has been.Êž2012-06-26 15:24:43.0000002012-06-26 15:25:12.000000‚3ÚÍA[]GAAhttps://github.com/sportngin/ngin/commit/7cf09409138af73fc8c967810c9cd281466c3e59#commitcomment-1484481https://api.github.com/repos/sportngin/ngin/comments/148448147cf09409138af73fc8c967810c9cd281466c3e59The id here has an extra zeroðž2012-06-20 22:13:54.0000002012-06-20 22:13:54.000000‚ ÙM[]%AAhttps://github.com/sportngin/ngin/commit/81e590d38befd51f15112755282a1ab0579238a9#commitcomment-1459917https://api.github.com/repos/sportngin/ngin/comments/145991781e590d38befd51f15112755282a1ab0579238a9looks ok. +1ðž2012-06-14 19:15:18.0000002012-06-14 19:15:18.000000‚Ù‰+[]AAhttps://github.com/sportngin/ngin/commit/3534d7737f4096d194f4e495f04b82c3344953cb#commitcomment-1459371https://api.github.com/repos/sportngin/ngin/comments/14593712673534d7737f4096d194f4e495f04b82c3344953cbPerfect.SS2012-06-14 16:58:53.0000002012-06-14 16:58:53.000000‚,Õã+[]=AAhttps://github.com/sportngin/ngin/commit/11dc22d392362abc898bd901399a13461e4aa2ca#commitcomment-1405355https://api.github.com/repos/sportngin/ngin/comments/140535511dc22d392362abc898bd901399a13461e4aa2camakes sense and works +1ðž2012-06-01 18:37:46.0000002012-06-01 18:37:46.000000‚Ô‘[]AAhttps://github.com/sportngin/ngin/commit/0ba4c46d45911f691c0a69e7db9066bb141a8c10#commitcomment-1378440https://api.github.com/repos/sportngin/ngin/comments/13784400ba4c46d45911f691c0a69e7db9066bb141a8c10+1ðž2012-05-25 20:33:24.0000002012-05-25 20:33:24.000000ƒ Ô‘[]oAAhttps://github.com/sportngin/ngin/commit/28830691eebc04e8552e06b5086b6940e1548c69#commitcomment-1378436https://api.github.com/repos/sportngin/ngin/comments/137843623428830691eebc04e8552e06b5086b6940e1548c69'resent' actually has a completely different meaning. Maybe say "Message is already in the process of being sent"ðž2012-05-25 20:32:13.0000002012-05-25 20:32:13.000000 OJ ÿ l AZ¿ôOƒ ã½[]‚AAhttps://github.com/sportngin/ngin/commit/9c3979c786704fcec4f58d1cfa715e8185658e57#commitcomment-1629840https://api.github.com/repos/sportngin/ngin/comments/1629840179c3979c786704fcec4f58d1cfa715e8185658e57using && instead of and would fix this also ruby precedence order for and operators and the equals operator is '&&' then '=' then 'and'º†2012-07-25 18:57:29.0000002012-07-25 18:58:12.000000ƒFâ«[]‚iAAhttps://github.com/sportngin/ngin/commit/cb4479ce849f160dcc6f1f722b6c8e3dbdba9734#commitcomment-1611151https://api.github.com/repos/sportngin/ngin/comments/161115110cb4479ce849f160dcc6f1f722b6c8e3dbdba9734Is this something that I should change in https://github.com/tstmedia/ngin/blob/production/app/models/email_address.rb#L97-99 as well (since it is where stole the idea from)?Êž2012-07-20 21:20:37.0000002012-07-20 21:20:37.000000ƒâªx[]‚ AAhttps://github.com/sportngin/ngin/commit/cb4479ce849f160dcc6f1f722b6c8e3dbdba9734#commitcomment-1611128https://api.github.com/repos/sportngin/ngin/comments/161112810cb4479ce849f160dcc6f1f722b6c8e3dbdba9734Or `find_by_phone_and_validated(number, true).present?` might be more explicit than the `!!` to indirectly convert to boolean.…2012-07-20 21:14:03.0000002012-07-20 21:14:03.000000ƒ>âªN[]‚YAAhttps://github.com/sportngin/ngin/commit/cb4479ce849f160dcc6f1f722b6c8e3dbdba9734#commitcomment-1611086https://api.github.com/repos/sportngin/ngin/comments/161108610cb4479ce849f160dcc6f1f722b6c8e3dbdba9734this should probably only return a boolean instead of the record adding !! to the front should do the trick ```ruby !!find_by_phone_and_validated(number, true) ``` º†2012-07-20 21:04:48.0000002012-07-20 21:04:48.000000„ßµS[]„AAhttps://github.com/sportngin/ngin/commit/110602e48b6b2a5a86a7a9367d2f3ccd82a4be6e#commitcomment-1563347https://api.github.com/repos/sportngin/ngin/comments/15633477110602e48b6b2a5a86a7a9367d2f3ccd82a4be6eremoving .includes(:question) because of the type of scope that is being used. This does not seem to affect the output of the page, though unsure what exactly this was doing in the first place. I'm presuming it was meant to pre-fetch (not lazy load) the relations.ðž2012-07-10 21:36:13.0000002012-07-10 21:36:13.000000‚&ߧN[]1AAhttps://github.com/sportngin/ngin/commit/06358303f09fd7f4219e2b46fa325b8e4b9eddff#commitcomment-1561550https://api.github.com/repos/sportngin/ngin/comments/156155006358303f09fd7f4219e2b46fa325b8e4b9eddffThis is safer? ;-)ðž2012-07-10 15:56:27.0000002012-07-10 15:56:27.000000…Þ§B[]…AAhttps://github.com/sportngin/ngin/commit/ae9e8eb4097f641d206cca618d585fed07321fa7#commitcomment-1545154https://api.github.com/repos/sportngin/ngin/comments/1545154ae9e8eb4097f641d206cca618d585fed07321fa7I don't like the looks of this... based on what I've read, the rack team doesn't seem willing to change their code... https://github.com/rack/rack/issues/365 there is likely a fork that handles this since the bug has been around since at least 2009. not sure what that will do to us though. I know Andy was playing around with pow... is that an alternative to rack? Jesse%¹2012-07-06 01:33:34.0000002012-07-06 01:33:34.000000‚FÝ×7[]iAAhttps://github.com/sportngin/ngin/commit/69fd1905f6577ec4a27119f627b56ded9c6420f2#commitcomment-1534903https://api.github.com/repos/sportngin/ngin/comments/1534903 28569fd1905f6577ec4a27119f627b56ded9c6420f2Probably don't want to leave this in the code.Êž2012-07-03 19:50:10.0000002012-07-03 19:50:10.000000ƒ1ݧy[]‚EAAhttps://github.com/sportngin/ngin/commit/ae9e8eb4097f641d206cca618d585fed07321fa7#commitcomment-1528825https://api.github.com/repos/sportngin/ngin/comments/1528825ae9e8eb4097f641d206cca618d585fed07321fa7Just curious is there a reason we can't use the quick score api for this? https://github.com/tstmedia/ngin/commit/0d6ff587d04a9270388a6ef45ecbc03293fb4e54 ñ¥2012-07-02 17:12:51.0000002012-07-02 17:12:51.000000 ZÒ  ò r ;ˆ<ëZƒ#í¡|[]‚!AAhttps://github.com/sportngin/ngin/commit/4df6df4b475e8fe6e4c017b91cb84ec24477001e#commitcomment-1790204https://api.github.com/repos/sportngin/ngin/comments/1790204 5814df6df4b475e8fe6e4c017b91cb84ec24477001e```ruby existing_route = ActionController::Routing::Routes.recognize_path("/#{friendly_name}", :method => :get)[:friendly_name].blank? ```º†2012-08-30 19:35:51.0000002012-08-30 19:38:29.000000ƒdí¡i[]ƒ#AAhttps://github.com/sportngin/ngin/commit/4df6df4b475e8fe6e4c017b91cb84ec24477001e#commitcomment-1790185https://api.github.com/repos/sportngin/ngin/comments/1790185 5814df6df4b475e8fe6e4c017b91cb84ec24477001eAt this point, we are asking Ian to do a supplemental deploy for something that has gone through about 5 different revisions. Provide a code example of what you think is better if you have a suggestion.Êž2012-08-30 19:31:38.0000002012-08-30 19:31:38.000000‚Lí¡_[]uAAhttps://github.com/sportngin/ngin/commit/4df6df4b475e8fe6e4c017b91cb84ec24477001e#commitcomment-1790175https://api.github.com/repos/sportngin/ngin/comments/1790175 5814df6df4b475e8fe6e4c017b91cb84ec24477001eplease invert this with present? dont use a ternary º†2012-08-30 19:29:56.0000002012-08-30 19:29:56.000000‚Gëš=[]kAAhttps://github.com/sportngin/ngin/commit/397aa8e9f30eb8d9b51b12ab5ef2b2cd30a6c7fd#commitcomment-1756477https://api.github.com/repos/sportngin/ngin/comments/1756477481397aa8e9f30eb8d9b51b12ab5ef2b2cd30a6c7fdwhy did seconds need a to_i but minutes didn't?º†2012-08-23 15:43:57.0000002012-08-23 15:43:57.000000ƒ.ë–?[]‚7AAhttps://github.com/sportngin/ngin/commit/13ddec630c652e64a6aea31a4ee68d18ea535d43#commitcomment-1755967https://api.github.com/repos/sportngin/ngin/comments/175596748113ddec630c652e64a6aea31a4ee68d18ea535d43sprintf? interpolate!!! ```ruby "#{self.game_state.attributes["min"].to_s.rjust(2,"0")}:#{self.game_state.attributes["sec"].to_s.rjust(2,"0")}" ```º†2012-08-23 14:18:04.0000002012-08-23 14:22:35.000000‚2ë–[]IAAhttps://github.com/sportngin/ngin/commit/13ddec630c652e64a6aea31a4ee68d18ea535d43#commitcomment-1755927https://api.github.com/repos/sportngin/ngin/comments/175592713ddec630c652e64a6aea31a4ee68d18ea535d43Makes sense. Yay for tests. +1ðž2012-08-23 14:12:12.0000002012-08-23 14:12:12.000000‚{èò[]YAAhttps://github.com/sportngin/ngin/commit/1cfe802f7b75ec2cef6324c3ab8cc0c620dc95c0#commitcomment-1718555https://api.github.com/repos/sportngin/ngin/comments/17185551cfe802f7b75ec2cef6324c3ab8cc0c620dc95c0Related to this error https://rpm.newrelic.com/accounts/875/applications/16731/traced_errors/204022420¸f2012-08-15 16:13:30.0000002012-08-15 16:13:30.000000‚$æÌ[]-AAhttps://github.com/sportngin/ngin/commit/d511543a451508a720c54803b88cdebbca105133#commitcomment-1680915https://api.github.com/repos/sportngin/ngin/comments/1680915d511543a451508a720c54803b88cdebbca105133code looks good.Œ?2012-08-07 13:56:23.0000002012-08-07 13:56:23.000000ƒ2æÌ[]‚AAAhttps://github.com/sportngin/ngin/commit/d511543a451508a720c54803b88cdebbca105133#commitcomment-1680911https://api.github.com/repos/sportngin/ngin/comments/168091187d511543a451508a720c54803b88cdebbca105133what happens if the feed has events previously, but the new one doesn't have any. the remaining events wouldn't be destroyed if imported_events.count == 0Œ?2012-08-07 13:55:48.0000002012-08-07 13:55:48.000000‚)ã½[]1AAhttps://github.com/sportngin/ngin/commit/9c3979c786704fcec4f58d1cfa715e8185658e57#commitcomment-1629842https://api.github.com/repos/sportngin/ngin/comments/1629842 229c3979c786704fcec4f58d1cfa715e8185658e57remove this pleaseº†2012-07-25 18:57:43.0000002012-07-25 18:57:43.000000 5 w †ÐP®5‚Sôû []AAhttps://github.com/sportngin/ngin/commit/1993ee7ca90efed4c7cbd0392b8f9414c05ba7a3#commitcomment-1916299https://api.github.com/repos/sportngin/ngin/comments/19162991971993ee7ca90efed4c7cbd0392b8f9414c05ba7a3This should be changed to use the site time, not datetime.ðž2012-09-27 19:11:27.0000002012-09-27 19:11:27.000000‚ôË []AAhttps://github.com/sportngin/ngin/commit/a13bb2165c6437bfaa4376e8da1b9b0c2e8e52b2#commitcomment-1910154https://api.github.com/repos/sportngin/ngin/comments/191015460a13bb2165c6437bfaa4376e8da1b9b0c2e8e52b2Done.Êž2012-09-26 19:50:29.0000002012-09-26 19:50:29.000000ƒôÈ{[]‚AAhttps://github.com/sportngin/ngin/commit/a13bb2165c6437bfaa4376e8da1b9b0c2e8e52b2#commitcomment-1909883https://api.github.com/repos/sportngin/ngin/comments/190988360a13bb2165c6437bfaa4376e8da1b9b0c2e8e52b2You could rewrite this method as: ```ruby page_node_ids.all?{|id| current_user.can_write?(PageNode.where(:id => id.to_i).first) } ```º†2012-09-26 19:00:03.0000002012-09-26 19:12:27.000000‚:ô‹5[]OAAhttps://github.com/sportngin/ngin/commit/edc939a1c10fb783336ac15aa3b30cbc44e4de26#commitcomment-1902005https://api.github.com/repos/sportngin/ngin/comments/19020051302edc939a1c10fb783336ac15aa3b30cbc44e4de26Thanks Travis... code is updated.%¹2012-09-25 14:52:36.0000002012-09-25 14:52:36.000000†<ô‡[[]ˆQAAhttps://github.com/sportngin/ngin/commit/edc939a1c10fb783336ac15aa3b30cbc44e4de26#commitcomment-1901531https://api.github.com/repos/sportngin/ngin/comments/19015311302edc939a1c10fb783336ac15aa3b30cbc44e4de26I don't really like the use of access_level here. Can we use the helpers that enum_field provides in order to make this more clear? Or it might be worth adding some additional methods to stat_preference. ```ruby if !access if !access && (stat_preference.can_edit_final_league_editor? || stat_preference.can_edit_final_team_owner? || stat_preference.can_edit_final_team_editor?) if !access && (stat_preference.can_edit_final_team_owner? || stat_preference.can_edit_final_team_editor?) if !access && stat_preference.can_edit_final_team_editor? ``` >ð2012-09-25 13:35:40.0000002012-09-25 13:35:40.000000ƒ1î¨w[]‚EAAhttps://github.com/sportngin/ngin/commit/e62c2cc93cf73adfa44296b4dbd7cb455ac7a682#commitcomment-1807479https://api.github.com/repos/sportngin/ngin/comments/1807479e62c2cc93cf73adfa44296b4dbd7cb455ac7a682The event should be triggered within the setup_gallery function on the $module object for it to fire correctly. I have already changed this and will commit.2š2012-09-04 20:36:41.0000002012-09-04 20:36:57.000000ƒlî¢v[]ƒ5AAhttps://github.com/sportngin/ngin/commit/fc04287d839441e8170a2dccbfe3e2f77f02bf48#commitcomment-1806710https://api.github.com/repos/sportngin/ngin/comments/180671095fc04287d839441e8170a2dccbfe3e2f77f02bf48Or this instead: ```ruby # if values is a Hash, then the GameTeamStat is a new record and we don't need to clear any values. unless values.is_a?(Hash) value_hash.keys.each {|k| values.send("#{k}=", 0) } end ``` >ð2012-09-04 18:09:17.0000002012-09-04 18:09:17.000000ƒ î¢[]wAAhttps://github.com/sportngin/ngin/commit/fc04287d839441e8170a2dccbfe3e2f77f02bf48#commitcomment-1806620https://api.github.com/repos/sportngin/ngin/comments/180662095fc04287d839441e8170a2dccbfe3e2f77f02bf48Need a nil check here: ```ruby value_hash.keys.each {|k| values.send("#{k}=", 0) if values.respond_to?("#{k}=") } ``` >ð2012-09-04 17:53:50.0000002012-09-04 17:53:50.000000ƒríÃu[]ƒGAAhttps://github.com/sportngin/ngin/commit/bd16f6356bffd13d1a5e0a0be4c92d1762944f5c#commitcomment-1794549https://api.github.com/repos/sportngin/ngin/comments/1794549bd16f6356bffd13d1a5e0a0be4c92d1762944f5cI want a way to get to the pre-game sheet even if the game is in progress or final. The idea here would be that we'd render a different controller action rather than having the logic within a single controller masking it.©]2012-08-31 16:45:09.0000002012-08-31 16:45:09.000000 üÐ ” G !y ëhfü‚eú²x[]%AAhttps://github.com/sportngin/ngin/commit/8f8c0086addaaca1a122db3901679d9dd588f5ff#commitcomment-2005368https://api.github.com/repos/sportngin/ngin/comments/20053681078f8c0086addaaca1a122db3901679d9dd588f5ffYes, help.sportngin.com will be redirected to our new setup in a day or two. ðk2012-10-16 20:32:20.0000002012-10-16 20:32:20.000000ƒ}ú²b[]ƒUAAhttps://github.com/sportngin/ngin/commit/8f8c0086addaaca1a122db3901679d9dd588f5ff#commitcomment-2005346https://api.github.com/repos/sportngin/ngin/comments/20053461078f8c0086addaaca1a122db3901679d9dd588f5ffThis is the only change I have a beef with because it just redirects back to the link that you changed it from. If this is a change for the future where there is going to be a new site at this address, then I am fine with this.Êž2012-10-16 20:29:27.0000002012-10-16 20:29:27.000000‚~ùû![]_AAhttps://github.com/sportngin/ngin/commit/dee3648dd176e73c0b623f7398ac1f8e2c31830d#commitcomment-1998241https://api.github.com/repos/sportngin/ngin/comments/1998241dee3648dd176e73c0b623f7398ac1f8e2c31830dWell... I was just going to suggest making the where clause a separate var... but that works too I guess.Êž2012-10-15 19:04:02.0000002012-10-15 19:04:02.000000‚ùÙO[]AAhttps://github.com/sportngin/ngin/commit/e1f893dd4f2c7e0e95f4a73de2c764271eebc647#commitcomment-1993935https://api.github.com/repos/sportngin/ngin/comments/1993935333e1f893dd4f2c7e0e95f4a73de2c764271eebc647yesÞþ2012-10-15 02:44:52.0000002012-10-15 02:44:52.000000‚iùµP[]-AAhttps://github.com/sportngin/ngin/commit/e1f893dd4f2c7e0e95f4a73de2c764271eebc647#commitcomment-1989328https://api.github.com/repos/sportngin/ngin/comments/1989328333e1f893dd4f2c7e0e95f4a73de2c764271eebc647Is claimer name set somewhere that I am missing? Is it a attribute on dib_item?Êž2012-10-12 20:34:47.0000002012-10-12 20:35:08.000000ƒ#øÞ?[]‚)AAhttps://github.com/sportngin/ngin/commit/7eb2877ae6e7abe7bff20464abbd2a2b0e70e3a9#commitcomment-1978175https://api.github.com/repos/sportngin/ngin/comments/19781757eb2877ae6e7abe7bff20464abbd2a2b0e70e3a9I think what I'll do is close this PR and do each of these in separate branches/PRs, one at a time, starting from production branch each time.ðž2012-10-11 01:04:04.0000002012-10-11 01:04:04.000000„!øÝ^[]„%AAhttps://github.com/sportngin/ngin/commit/7eb2877ae6e7abe7bff20464abbd2a2b0e70e3a9#commitcomment-1978078https://api.github.com/repos/sportngin/ngin/comments/19780787eb2877ae6e7abe7bff20464abbd2a2b0e70e3a9Lets shorten these up across the board, at least for the ones that have a date which we are already modifying. For example in game_scoreboard_stat_v2 lets for sure get rid of "stat_v2" as there is no concept of stat_v2 vs. v1 anymore. play_by_play can become pbp, etc.©i2012-10-11 00:34:08.0000002012-10-11 00:34:08.000000‚H÷ë=[]mAAhttps://github.com/sportngin/ngin/commit/88ed12270534a3d3d05ff633290d3c5705c57e82#commitcomment-1963453https://api.github.com/repos/sportngin/ngin/comments/196345378688ed12270534a3d3d05ff633290d3c5705c57e82Is this being replaced with text and a new logo?2š2012-10-08 18:43:39.0000002012-10-08 18:43:39.000000‚7÷[]MAAhttps://github.com/sportngin/ngin/commit/3bc2048fd6931a8d8656427750aaf0e239488135#commitcomment-1953409https://api.github.com/repos/sportngin/ngin/comments/1953409843bc2048fd6931a8d8656427750aaf0e239488135shouldn't that be get_with_post?º†2012-10-05 15:52:19.0000002012-10-05 15:52:31.000000‚+õ []3AAhttps://github.com/sportngin/ngin/commit/1993ee7ca90efed4c7cbd0392b8f9414c05ba7a3#commitcomment-1921038https://api.github.com/repos/sportngin/ngin/comments/19210381971993ee7ca90efed4c7cbd0392b8f9414c05ba7a3This is not crucialðž2012-09-28 16:02:18.0000002012-09-28 16:02:18.000000 ¶¶p 6  !…g­=%mM_Ks  {ikAAdustinfarrishttps://avatars.githubusercontent.com/u/1087165?4159a4fa55045a0b6b01ecb3b7279255https://api.github.com/users/dustinfarrishttps://github.com/dustinfarrishttps://api.github.com/users/dustinfarris/followershttps://api.github.com/users/dustinfarris/following{/other_user}https://api.github.com/users/dustinfarris/gists{/gist_id}https://api.github.com/users/dustinfarris/starred{/owner}{/repo}https://api.github.com/users/dustinfarris/subscriptionshttps://api.github.com/users/dustinfarris/orgshttps://api.github.com/users/dustinfarris/reposhttps://api.github.com/users/dustinfarris/events{/privacy}https://api.github.com/users/dustinfarris/received_eventsUserf2014-06-05 15:35:58.3705442014-06-05 15:35:58.370544…BÈåmMYEmyuce{yAAkevinmarxht…g­=%mM_Ks  {ikAAdustinfarrishttps://avatars.githubusercontent.com/u/1087165?415…5®³EkMWCkwsacywAAmarklarrhttps://avatars.githubusercontent.com/u/760261?9d613fc702735039195715fe18662e04https://api.github.com/users/marklarrhttps://github.com/marklarrhttps://api.github.com/users/marklarr/followershttps://api.github.com/users/marklarr/following{/other_user}https://api.github.com/users/marklarr/gists{/gist_id}https://api.github.com/users/marklarr/starred{/owner}{/repo}https://api.github.com/users/marklarr/subscriptionshttps://api.github.com/users/marklarr/orgshttps://api.github.com/users/marklarr/reposhttps://api.github.com/users/marklarr/events{/privacy}https://api.github.com/users/marklarr/received_eventsUserf2014-06-05 15:35:58.8024462014-06-05 15:35:58.802446…A¯àkkMYEmyuce{yAAdhoffmannhttps://avatars.githubusercontent.com/u/782443?1aef69ba024e7bd28379dd72b2b3ab09https://api.github.com/users/dhoffmannhttps://github.com/dhoffmannhttps://api.github.com/users/dhoffmann/followershttps://api.github.com/users/dhoffmann/following{/other_user}https://api.github.com/users/dhoffmann/gists{/gist_id}https://api.github.com/users/dhoffmann/starred{/owner}{/repo}https://api.github.com/users/dhoffmann/subscriptionshttps://api.github.com/users/dhoffmann/orgshttps://api.github.com/users/dhoffmann/reposhttps://api.github.com/users/dhoffmann/events{/privacy}https://api.github.com/users/dhoffmann/received_eventsUserf2014-06-05 15:35:57.4039342014-06-05 15:35:57.403934…Y°©#kM]Iq } ygi}AAtstnoahwenzhttps://avatars.githubusercontent.com/u/791703?9251ab4d6f603a7e5158bf30463a8847https://api.github.com/users/tstnoahwenzhttps://github.com/tstnoahwenzhttps://api.github.com/users/tstnoahwenz/followershttps://api.github.com/users/tstnoahwenz/following{/other_user}https://api.github.com/users/tstnoahwenz/gists{/gist_id}https://api.github.com/users/tstnoahwenz/starred{/owner}{/repo}https://api.github.com/users/tstnoahwenz/subscriptionshttps://api.github.com/users/tstnoahwenz/orgshttps://api.github.com/users/tstnoahwenz/reposhttps://api.github.com/users/tstnoahwenz/events{/privacy}https://api.github.com/users/tstnoahwenz/received_eventsUserf2014-06-05 15:35:55.5315662014-06-05 15:35:55.531566…g­=%mM_Ks  {ikAAdustinfarrishttps://avatars.githubusercontent.com/u/1087165?4159a4fa55045a0b6b01ecb3b7279255https://api.github.com/users/dustinfarrishttps://github.com/dustinfarrishttps://api.github.com/users/dustinfarris/followershttps://api.github.com/users/dustinfarris/following{/other_user}https://api.github.com/users/dustinfarris/gists{/gist_id}https://api.github.com/users/dustinfarris/starred{/owner}{/repo}https://api.github.com/users/dustinfarris/subscriptionshttps://api.github.com/users/dustinfarris/orgshttps://api.github.com/users/dustinfarris/reposhttps://api.github.com/users/dustinfarris/events{/privacy}https://api.github.com/users/dustinfarris/received_eventsUserf2014-06-05 15:35:58.3705442014-06-05 15:35:58.370544  ± + ? ¯·Él‚U‹¾0[]AAhttps://github.com/sportngin/ngin/commit/e611d737ed71324225b42fc37515a4ff33806530#commitcomment-2285360https://api.github.com/repos/sportngin/ngin/comments/2285360557e611d737ed71324225b42fc37515a4ff33806530That, or you can do `status_disabled?` or `status_deleted?`.Êž2012-12-11 00:48:16.0000002012-12-11 00:48:16.000000‚W„¥u[] AAhttps://github.com/sportngin/ngin/commit/bd67ced36775a67bcd373b8ee96e74ec93a6166e#commitcomment-2167541https://api.github.com/repos/sportngin/ngin/comments/2167541531bd67ced36775a67bcd373b8ee96e74ec93a6166eWe should get rid of this options hash, since we don't use it.…2012-11-16 21:08:53.0000002012-11-16 21:08:53.000000ƒhƒë[]ƒ3AAhttps://github.com/sportngin/ngin/commit/ad0273492d147e7c40cec932b175110454103fc0#commitcomment-2160127https://api.github.com/repos/sportngin/ngin/comments/2160127ad0273492d147e7c40cec932b175110454103fc0Could I suggest you do a little refactoring with this method and assign a `previous_standing_type variable` for `Standings::StandingType.find(standing_type_id_was)` since it is used a couple times in the method.Êž2012-11-15 18:04:44.0000002012-11-15 18:04:44.000000ƒrÄ`[]ƒGAAhttps://github.com/sportngin/ngin/commit/78ca2fe2d1a6dd37125df91c7d368a3ae10f7f4c#commitcomment-2122336https://api.github.com/repos/sportngin/ngin/comments/212233678ca2fe2d1a6dd37125df91c7d368a3ae10f7f4cI really hate how this is implemented, but since we don't have time to do it properly, it will have to do for now I guess. Dumping logic like this into the controller is one of the reasons our codebase is such a disaster.Aq2012-11-08 15:01:12.0000002012-11-08 15:01:12.000000‚[€ö'[]AAhttps://github.com/sportngin/ngin/commit/2ea5a406572e40a53bc1c2b3ce85e2d749ba25e4#commitcomment-2112295https://api.github.com/repos/sportngin/ngin/comments/21122952ea5a406572e40a53bc1c2b3ce85e2d749ba25e4:+1: glad someone finally took the time to figure out how to do this.Œ?2012-11-06 22:15:04.0000002012-11-06 22:15:24.000000‚*ÿ’ []3AAhttps://github.com/sportngin/ngin/commit/84a64b41bc729b8e250194a2ef2ae92a3818417d#commitcomment-2083082https://api.github.com/repos/sportngin/ngin/comments/2083082&6484a64b41bc729b8e250194a2ef2ae92a3818417dCan we remove this?Êž2012-10-31 19:31:57.0000002012-10-31 19:31:57.000000ƒgþãz[]ƒ)AAhttps://github.com/sportngin/ngin/commit/7d30e5d003a29055203161203a3aa0c31f68d3f7#commitcomment-2077178https://api.github.com/repos/sportngin/ngin/comments/2077178 1257d30e5d003a29055203161203a3aa0c31f68d3f7I don't necessarily think that this is a bad thing to have in the tests. It will give the next dev who looks at this an idea of what your end goal is with this method. But not critical, just my two cents.Êž2012-10-30 23:08:59.0000002012-10-30 23:08:59.000000ƒþ¨[]]AAhttps://github.com/sportngin/ngin/commit/35c9e44fb02fd65850b639e5309d328a17884c63#commitcomment-2069508https://api.github.com/repos/sportngin/ngin/comments/206950837335c9e44fb02fd65850b639e5309d328a17884c63Lines like these make me want to add the ActiveRelation#touch_all method that we thought existed before.…2012-10-29 20:51:21.0000002012-10-29 20:51:21.000000„JüÂ=[]„qAAhttps://github.com/sportngin/ngin/commit/6f0849e4dea8b8da71df45402fb9061e17e06a9d#commitcomment-2040125https://api.github.com/repos/sportngin/ngin/comments/2040125)626f0849e4dea8b8da71df45402fb9061e17e06a9dI almost wonder if we want to make this the else case. I guess it wouldn't be any much better with "Annual" or "Semi-Annual", but if this "fails" again, I would think that having `"Every #{bill_period}"` as the catch all case would be better then the `"#{bill_period}ly"` case. Otherwise this looks fine.Êž2012-10-23 17:11:28.0000002012-10-23 17:11:28.000000 Ô‹  #Â^.Ô‚TŽ÷a[]AAhttps://github.com/sportngin/ngin/commit/702f7ddc621083d82a99b22afe79663b756c8549#commitcomment-2341857https://api.github.com/repos/sportngin/ngin/comments/2341857785702f7ddc621083d82a99b22afe79663b756c8549Or possibly, go with a constant ORPHAN_PERSONA_TYPE_ID = 7 ©i2012-12-20 21:39:12.0000002012-12-20 21:39:12.000000„*Ž÷W[]„/AAhttps://github.com/sportngin/ngin/commit/702f7ddc621083d82a99b22afe79663b756c8549#commitcomment-2341847https://api.github.com/repos/sportngin/ngin/comments/2341847785702f7ddc621083d82a99b22afe79663b756c8549When this code was written we didn't have a persona type of "orphan". We do now. So you can remove the line persona_type = hash['survey_result']['orphan_profile_type'] and modify pt = PersonaType.find_by_name(persona_type) to be: pt = PersonaType.find_by_name "orphan"©i2012-12-20 21:37:59.0000002012-12-20 21:37:59.000000ˆ^Ž¨v[]AAhttps://github.com/sportngin/ngin/commit/399788c232bb580aac50b85fba95528f41edd377#commitcomment-2331766https://api.github.com/repos/sportngin/ngin/comments/2331766399788c232bb580aac50b85fba95528f41edd377The problem was gemfile.lock not being updated. I think i fixed it all up now On Dec 19, 2012 5:37 AM, "Patrick Byrne" wrote: > Likely because I made it directly to production and not to staging. Are > the merge conflicts you get on this line? Did you also change this line in > your branch? If so, which is it? Perfect production into your branch and > try to stage-up again. > > On Dec 18, 2012, at 10:41 PM, natejgreene > wrote: > > > @pbyrne why do I not see this on the staging branch? :) Getting merge > conflicts :( > > > > — > > Reply to this email directly or view it on GitHub. > > > > — > Reply to this email directly or view it on GitHub. > >€52012-12-19 12:23:21.0000002012-12-19 12:23:21.000000‚[Ž§7[]AAhttps://github.com/sportngin/ngin/commit/399788c232bb580aac50b85fba95528f41edd377#commitcomment-2331575https://api.github.com/repos/sportngin/ngin/comments/2331575399788c232bb580aac50b85fba95528f41edd377Oops. Fixed, @NickLaMuro, in 1fd128954bdab1ff72736bec2ea143949dcb2a43.…2012-12-19 11:49:09.0000002012-12-19 11:49:09.000000…tŽ§[]‡KAAhttps://github.com/sportngin/ngin/commit/399788c232bb580aac50b85fba95528f41edd377#commitcomment-2331527https://api.github.com/repos/sportngin/ngin/comments/2331527399788c232bb580aac50b85fba95528f41edd377Likely because I made it directly to production and not to staging. Are the merge conflicts you get on this line? Did you also change this line in your branch? If so, which is it? Perfect production into your branch and try to stage-up again. On Dec 18, 2012, at 10:41 PM, natejgreene wrote: > @pbyrne why do I not see this on the staging branch? :) Getting merge conflicts :( > > — > Reply to this email directly or view it on GitHub. > …2012-12-19 11:37:53.0000002012-12-19 11:37:53.000000‚hŽšG[]3AAhttps://github.com/sportngin/ngin/commit/399788c232bb580aac50b85fba95528f41edd377#commitcomment-2329927https://api.github.com/repos/sportngin/ngin/comments/2329927399788c232bb580aac50b85fba95528f41edd377@pbyrne why do I not see this on the staging branch? :) Getting merge conflicts :(€52012-12-19 04:41:18.0000002012-12-19 04:41:18.000000‚oŽ˜[]AAAhttps://github.com/sportngin/ngin/commit/399788c232bb580aac50b85fba95528f41edd377#commitcomment-2329621https://api.github.com/repos/sportngin/ngin/comments/2329621399788c232bb580aac50b85fba95528f41edd377:rage4: @pbyrne UPDATE THE `Gemfile.lock` IF YOU DO THIS!!!1!!1!1! :rage4: :rabbit2: Êž2012-12-19 02:53:01.0000002012-12-19 02:56:43.000000 i[ V Ÿj(Þ±i‚”ú/[]!AAhttps://github.com/sportngin/ngin/commit/02206697c6412441fa51b6167f6d01d27bcc1420#commitcomment-2440495https://api.github.com/repos/sportngin/ngin/comments/244049502206697c6412441fa51b6167f6d01d27bcc1420:thumbsup:Òm2013-01-15 20:52:54.0000002013-01-15 20:52:54.000000‚”ú%[]!AAhttps://github.com/sportngin/ngin/commit/ea08f70e99f66e0c1335bd955204c6e341b4e151#commitcomment-2440485https://api.github.com/repos/sportngin/ngin/comments/2440485ea08f70e99f66e0c1335bd955204c6e341b4e151:thumbsup:Òm2013-01-15 20:51:39.0000002013-01-15 20:51:39.000000‚'”ú[]3AAhttps://github.com/sportngin/ngin/commit/8ba42f53dcb3d5be14ad0f845697501940595301#commitcomment-2440456https://api.github.com/repos/sportngin/ngin/comments/24404568ba42f53dcb3d5be14ad0f845697501940595301code looks good Òm2013-01-15 20:47:22.0000002013-01-15 20:47:35.000000‚D”Ë[]gAAhttps://github.com/sportngin/ngin/commit/fa6c2dd93f35ffcc003f6fedb9e6d33a467bb8d3#commitcomment-2434463https://api.github.com/repos/sportngin/ngin/comments/243446391fa6c2dd93f35ffcc003f6fedb9e6d33a467bb8d3We're moving the team id to the landing page. ðk2013-01-14 23:30:53.0000002013-01-14 23:30:53.000000‚<”Ê+[]WAAhttps://github.com/sportngin/ngin/commit/fa6c2dd93f35ffcc003f6fedb9e6d33a467bb8d3#commitcomment-2434347https://api.github.com/repos/sportngin/ngin/comments/243434791fa6c2dd93f35ffcc003f6fedb9e6d33a467bb8d3@dhoffmann Why is this line removed? ñ¥2013-01-14 23:11:34.0000002013-01-14 23:11:54.000000‚/“õW[]CAAhttps://github.com/sportngin/ngin/commit/5166ed704e9ae80b0649845d7ef5320b2186accd#commitcomment-2423511https://api.github.com/repos/sportngin/ngin/comments/24235115166ed704e9ae80b0649845d7ef5320b2186accd@tst-automation good to go.©]2013-01-11 21:47:11.0000002013-01-11 21:47:11.000000„_“ï([]…AAhttps://github.com/sportngin/ngin/commit/688e03260899e3bf1af5727dbdb3b4c48c796452#commitcomment-2422696https://api.github.com/repos/sportngin/ngin/comments/242269615688e03260899e3bf1af5727dbdb3b4c48c796452I think this 3 lines of code should be moved inside the assign_question method. This will allow the hidden default to take affect when a reusable question is added by itself instead of through a question group. Assign question is where other defaults are being set on the question element from the question such as is_required.©i2013-01-11 19:11:23.0000002013-01-11 19:11:23.000000„L’•[]„{AAhttps://github.com/sportngin/ngin/commit/aaf3ce35b8f97889e3609c1e509b29e7aa69eb85#commitcomment-2394771https://api.github.com/repos/sportngin/ngin/comments/2394771aaf3ce35b8f97889e3609c1e509b29e7aa69eb85Though line 102 selects distinct messages, the subsequent left joins leave us with potentially duplicate rows in the relation. Certain methods on relations count distinct rows and others count total rows, leading to the discrepancy Andy noted. We'll just avoid the issue by elminating the dupes straight away.-º2013-01-07 17:24:56.0000002013-01-07 17:24:56.000000ƒÆ;[]ƒ[AAhttps://github.com/sportngin/ngin/commit/ca1b1e74c444728a5518249aab3ae73162c82e79#commitcomment-2351931https://api.github.com/repos/sportngin/ngin/comments/235193151ca1b1e74c444728a5518249aab3ae73162c82e79We'll want this in an initializer and load into something like `Rails.configuration.us_lacrosse_credentials` or somesuch. That way it only happens once and the value is stored, rather than happening every time the method is called.…2012-12-24 15:29:36.0000002012-12-24 15:29:36.000000ƒÆ6[]‚AAhttps://github.com/sportngin/ngin/commit/ca1b1e74c444728a5518249aab3ae73162c82e79#commitcomment-2351926https://api.github.com/repos/sportngin/ngin/comments/2351926 47ca1b1e74c444728a5518249aab3ae73162c82e79We probably can move this information into the YML file as well and remove the `Ngin.production?` check from the controller altogether.…2012-12-24 15:27:14.0000002012-12-24 15:27:14.000000 3Ü ¸¢nõt3„;šôn[]„QAAhttps://github.com/sportngin/ngin/commit/db807cf11e7373eac8acf6e874daf37e91ede507#commitcomment-2538094https://api.github.com/repos/sportngin/ngin/comments/2538094228db807cf11e7373eac8acf6e874daf37e91ede507Does the `.uniq` hinder performance at all? If not, I might just say you should keep it in there. The query is probably correct, but if this isn't going to add seconds to the query, there is no harm in tacking it on and it would ensure that this method always returns one of each persona.Êž2013-01-31 19:42:48.0000002013-01-31 19:42:48.000000‚{šôT[]QAAhttps://github.com/sportngin/ngin/commit/db807cf11e7373eac8acf6e874daf37e91ede507#commitcomment-2538068https://api.github.com/repos/sportngin/ngin/comments/2538068210db807cf11e7373eac8acf6e874daf37e91ede507http://api.rubyonrails.org/classes/ActiveSupport/Inflector.html#method-i-demodulize for more info.Êž2013-01-31 19:40:05.0000002013-01-31 19:40:05.000000‚sšôB[]AAAhttps://github.com/sportngin/ngin/commit/db807cf11e7373eac8acf6e874daf37e91ede507#commitcomment-2538050https://api.github.com/repos/sportngin/ngin/comments/2538050210db807cf11e7373eac8acf6e874daf37e91ede507The `.to_s` on this is now excessive since `.name` and `.demodulize ` both return strings.Êž2013-01-31 19:37:53.0000002013-01-31 19:37:53.000000‚.—±m[];AAhttps://github.com/sportngin/ngin/commit/f0e8b8c0069b149caf82cbc8434ddbadc443d3b2#commitcomment-2480365https://api.github.com/repos/sportngin/ngin/comments/2480365 43f0e8b8c0069b149caf82cbc8434ddbadc443d3b2I hate you right now...Êž2013-01-22 21:59:09.0000002013-01-22 21:59:09.000000Œ—£[]“{AAhttps://github.com/sportngin/ngin/commit/b59c5b57c6492834ead4400bb116a35b94a79b4a#commitcomment-2478471https://api.github.com/repos/sportngin/ngin/comments/2478471430b59c5b57c6492834ead4400bb116a35b94a79b4aThis test doesn't help us in any way. * The `DATE_VALIDATION` constant that you are passing, while is currently the same as `TstSharedTime::MDY_TIMESTAMP`, could end up being different then then the contant in `TstSharedTime` if a developer changed it for some reason. Using `TstSharedTime::MDY_TIMESTAMP` here is a better choice to avoid false postive tests from cropping up if a developer decides to change the regexp in the code. If you want to test that regexp are what we expect them to be, then create a new test to test that (in something like `test/lib/tst_time_test.rb`). This though is probably outside the scope of this ticket. * Testing that the regexp works as expected in this test doesn't help confirm if the `background_schedule_import` file is doing it's job, and just checks if the regexp is parsing some string correctly. If you want to actually test that the `TSTScheduleRow` is working correctly, run the `TSTScheduleRow.new()` method sets the date if a properly formatted string actually sets a date, and a improperly formatted date to our regexp (but not necessarily for `Time.parse`) causes the date fields (`start_dt` and `end_dt`) to not be set, or set to `nil`. That would actually confirm that the code you added is working correctly.Êž2013-01-22 17:29:08.0000002013-01-22 20:57:44.000000‚”úF[]!AAhttps://github.com/sportngin/ngin/commit/c53a38ee37151011ebfcf34d614d9510f07c8104#commitcomment-2440518https://api.github.com/repos/sportngin/ngin/comments/2440518c53a38ee37151011ebfcf34d614d9510f07c8104:thumbsup:Òm2013-01-15 20:55:13.0000002013-01-15 20:55:13.000000‚”ú8[]!AAhttps://github.com/sportngin/ngin/commit/afd0174d55f430f6c3b687db1eb425239fce3506#commitcomment-2440504https://api.github.com/repos/sportngin/ngin/comments/2440504afd0174d55f430f6c3b687db1eb425239fce3506:thumbsup:Òm2013-01-15 20:53:48.0000002013-01-15 20:53:48.000000 ?Z <ÿàç?ƒ"¡ãh[]‚AAhttps://github.com/sportngin/ngin/commit/64f4cffedfc931b1a294d5ef509ac4e184c58fa3#commitcomment-2650600https://api.github.com/repos/sportngin/ngin/comments/265060079764f4cffedfc931b1a294d5ef509ac4e184c58fa3Can we change this var to something like `full_width` or `using_full_width`? Reading this as is seems like it's saying "is there width?"Êž2013-02-19 18:00:40.0000002013-02-19 18:00:40.000000…sžâ+[]‡CAAhttps://github.com/sportngin/ngin/commit/6ebaa6345b929d2d2bb7070a796c3a0f1ffc70e1#commitcomment-2601259https://api.github.com/repos/sportngin/ngin/comments/2601259296ebaa6345b929d2d2bb7070a796c3a0f1ffc70e1Not critical if I don't find anything else, but try do avoid doing `method_1 method_2 method_2_args1` in your code. Instead, do `method_1 method_2(method_2_args`. I like no parenthesis's where ever possible, but if there is a method being called within a method, the standard practice that TST has been doing is call the inner methods with `()`'s. The ruby interpreter is pretty good about figuring this stuff out, but it's a little harder to follow for the human readers.Êž2013-02-11 20:02:20.0000002013-02-11 20:02:20.000000‚Êj[]AAhttps://github.com/sportngin/ngin/commit/52ee040ef1bc5c01fb83511f01951b86eebc856b#commitcomment-2581866https://api.github.com/repos/sportngin/ngin/comments/258186652ee040ef1bc5c01fb83511f01951b86eebc856b:+1: Êž2013-02-07 21:43:51.0000002013-02-07 21:43:51.000000Š7œÈ []KAAhttps://github.com/sportngin/ngin/commit/835766cf47746688adecce0178d9853585b172af#commitcomment-2565133https://api.github.com/repos/sportngin/ngin/comments/256513344835766cf47746688adecce0178d9853585b172afNo need to change this, but for future reference, I was only looking for some output with the asserts. See the below example for a reason why: ```ruby require 'test/unit' class Sample def addition(value_1, value_2) end end class SampleTest < Test::Unit::TestCase def test_addition assert Sample.new.addition(1,1) end def test_addition_as_well assert_equal 2, Sample.new.addition(1,1) end end ``` ```shell $ ruby sample.rb Run options: # Running tests: FF Finished tests in 0.001208s, 1655.6291 tests/s, 1655.6291 assertions/s. 1) Failure: test_addition(SampleTest) [sample.rb:10]: Failed assertion, no message given. 2) Failure: test_addition_as_well(SampleTest) [sample.rb:14]: <2> expected but was . 2 tests, 2 assertions, 2 failures, 0 errors, 0 skips ``` The regular `assert` doesn't give any helpful info, so viewing the test output of that from the CI server would not be helpful. But I think the default info from `assert_equal` gives enough info to start with.Êž2013-02-05 21:10:27.0000002013-02-05 21:10:27.000000„œ™h[]„ AAhttps://github.com/sportngin/ngin/commit/4468a0531ac83750c117371ab65d00cc6c7a9ccc#commitcomment-2559208https://api.github.com/repos/sportngin/ngin/comments/25592083004468a0531ac83750c117371ab65d00cc6c7a9cccSince you are now removing the `if` conditionals from the controller, you should add an assert to check that a quick score isn't created on this game (because I don't think we want a quick score added to a game that isn't quick score... I could be wrong).Êž2013-02-05 04:43:22.0000002013-02-05 04:43:22.000000ƒ ›«a[]‚AAhttps://github.com/sportngin/ngin/commit/b3538ed5393d54defd4e84b01f14b4b45d390445#commitcomment-2545121https://api.github.com/repos/sportngin/ngin/comments/254512115b3538ed5393d54defd4e84b01f14b4b45d390445One of these two should work: ```ruby <%= raw("style=display:none;") %> ``` ```ruby <%= "style=display:none;".html_safe %> ```Êž2013-02-01 19:28:08.0000002013-02-01 19:28:08.000000 â ãP-ß"â‚:¥®)[]SAAhttps://github.com/sportngin/ngin/commit/7e65aa17fe6f58cab49cf5fe2c9a8a1c2251d650#commitcomment-2709289https://api.github.com/repos/sportngin/ngin/comments/2709289 107e65aa17fe6f58cab49cf5fe2c9a8a1c2251d650and then reuse result_ids down hereº†2013-02-27 22:55:35.0000002013-02-27 22:55:35.000000ƒ7¥®[]‚MAAhttps://github.com/sportngin/ngin/commit/7e65aa17fe6f58cab49cf5fe2c9a8a1c2251d650#commitcomment-2709274https://api.github.com/repos/sportngin/ngin/comments/270927467e65aa17fe6f58cab49cf5fe2c9a8a1c2251d650I would only select the id here something like ```ruby if (result_ids = survey.survey_results.select(:id).all_as_hashes.map{|sr| sr[:id] }).length == 0 ```º†2013-02-27 22:53:07.0000002013-02-27 22:53:07.000000‚H¥![]uAAhttps://github.com/sportngin/ngin/commit/e8c207803f40f3d837351e15c7ebe6725d6164fa#commitcomment-2705313https://api.github.com/repos/sportngin/ngin/comments/2705313e8c207803f40f3d837351e15c7ebe6725d6164faPossibly the greatest commit ever committed to ngin.…2013-02-27 15:01:25.0000002013-02-27 15:01:25.000000„¤Û1[]„AAhttps://github.com/sportngin/ngin/commit/d43e5d0584888f8d663baf53c145e13f1a7902c0#commitcomment-2698673https://api.github.com/repos/sportngin/ngin/comments/2698673d43e5d0584888f8d663baf53c145e13f1a7902c0So i think it should be like this: ``` <%= link_to "Roster Settings", { controller: 'page', action: 'show', id: @page_node.league_access_page.id, tab: 'tool_settings'} %> located in admin tools.

```ðž2013-02-26 20:03:10.0000002013-02-26 20:03:33.000000 ¤Û []•}AAhttps://github.com/sportngin/ngin/commit/d43e5d0584888f8d663baf53c145e13f1a7902c0#commitcomment-2698656https://api.github.com/repos/sportngin/ngin/comments/2698656d43e5d0584888f8d663baf53c145e13f1a7902c0pn = PageNode.find 626911 << TEAM ROSTER PAGE => #PageNode id: 626911, site_id: 2097, content_node_id: 4792083, lft: 44, rgt: 45, parent_id: 626909, button_title: "Buffalo Bandits", page_title: "Buffalo Bandits", display_status: "public", updated_on: "2013-02-21 14:20:43", created_on: "2012-09-04 19:35:02", in_trash: false, css_id: "", node_type: "TeamInstance", node_id: 243873, has_events: true, has_news: true, extended_button_title: "Buffalo Bandits", header_code: nil, image_id: nil, cascade_header_code: nil, layout_template: "two_panel", page_element_lock_for_edit_access: nil, uses_sport_header: true, cache_timeout: 7200, ads_doubleclick_zone_id: nil, friendly_name: nil irb(main):002:0> pn.league_access_page << LEAGUE PAGE WHERE TOOL SETTINGS LIVE => #PageNode id: 626906, site_id: 2097, content_node_id: 4792069, lft: 41, rgt: 66, parent_id: 389157, button_title: "Teams", page_title: "National Lacrosse League", display_status: "public", updated_on: "2013-02-13 14:33:21", created_on: "2012-09-04 19:34:59", in_trash: false, css_id: "", node_type: "LeagueInstance", node_id: 8071, has_events: true, has_news: true, extended_button_title: "Teams (2013)", header_code: nil, image_id: nil, cascade_header_code: nil, layout_template: "two_panel", page_element_lock_for_edit_access: nil, uses_sport_header: true, cache_timeout: 7200, ads_doubleclick_zone_id: 0, friendly_name: nilðž2013-02-26 20:00:46.0000002013-02-26 20:04:25.000000„¤–[]„ AAhttps://github.com/sportngin/ngin/commit/9f89a5be4975886a5566f4f47b358ed20c052da5#commitcomment-2689792https://api.github.com/repos/sportngin/ngin/comments/2689792 3139f89a5be4975886a5566f4f47b358ed20c052da5I think I would rather see this as a `else` condition of the two if statements that call `objects_valid?` then here on it's own. Then you aren't calling `widget.widget.valid?` twice, and it will flip that variable to false when `widget` is also invalid.Êž2013-02-25 19:42:09.0000002013-02-25 19:42:09.000000 W§ S Î ³þÓ¬W‚O¥åo[]AAhttps://github.com/sportngin/ngin/commit/b9bbfc77d4a1df5f5d1a8b8b7a8b32ad55d692e7#commitcomment-2716399https://api.github.com/repos/sportngin/ngin/comments/2716399b9bbfc77d4a1df5f5d1a8b8b7a8b32ad55d692e7Does that mean I'm not needed for this for the time being?Þþ2013-02-28 19:43:42.0000002013-02-28 19:43:42.000000„!¥Ù3[]„%AAhttps://github.com/sportngin/ngin/commit/b9bbfc77d4a1df5f5d1a8b8b7a8b32ad55d692e7#commitcomment-2714803https://api.github.com/repos/sportngin/ngin/comments/2714803b9bbfc77d4a1df5f5d1a8b8b7a8b32ad55d692e7Odd. It's not clear when this got merged into production, but since this project is on hold, can you submit a pull request that deletes this stuff until we want to put it back in? There's no point in having code sitting around that isn't being used and might never be.…2013-02-28 16:15:43.0000002013-02-28 16:15:43.000000„%¥Öd[]„-AAhttps://github.com/sportngin/ngin/commit/b9bbfc77d4a1df5f5d1a8b8b7a8b32ad55d692e7#commitcomment-2714468https://api.github.com/repos/sportngin/ngin/comments/2714468b9bbfc77d4a1df5f5d1a8b8b7a8b32ad55d692e7@pbyrne Hmm. I'm not sure how this got into production in the first place. The US Lacrosse API would be failing now (for political reasons I believe), but not sure why it's hitting the API in the first place. At any rate, this really shouldn't be in production at all.–½2013-02-28 15:36:34.0000002013-02-28 15:36:34.000000…/¥Ö?[]†AAAhttps://github.com/sportngin/ngin/commit/b9bbfc77d4a1df5f5d1a8b8b7a8b32ad55d692e7#commitcomment-2714431https://api.github.com/repos/sportngin/ngin/comments/2714431b9bbfc77d4a1df5f5d1a8b8b7a8b32ad55d692e7@dustinfarris I marked this spec as pending, because it started failing today, consistently for everyone. Nothing seems to have changed on our end, and even if there was a problem on the API's end, VCR should be capturing the request and using a cassette instead of even attempting to hit the API. Can you take a look and maybe rope @jphenow in to see why this isn't working as our other external API specs do?…2013-02-28 15:31:45.0000002013-02-28 15:31:45.000000„¥®K[]„AAhttps://github.com/sportngin/ngin/commit/04c73fc142ae27a991b9651eed80b364137c8afa#commitcomment-2709323https://api.github.com/repos/sportngin/ngin/comments/27093236604c73fc142ae27a991b9651eed80b364137c8afaI think if I don't, it'll call the method even when the persona is being destroyed, which I don't want. And I can't be more explicit about firing only on `:create` and `:update` because it doesn't work that way: https://github.com/rails/rails/pull/9356-º2013-02-27 22:59:04.0000002013-02-27 23:16:56.000000‚¥®A[][AAhttps://github.com/sportngin/ngin/commit/7e65aa17fe6f58cab49cf5fe2c9a8a1c2251d650#commitcomment-2709313https://api.github.com/repos/sportngin/ngin/comments/2709313 107e65aa17fe6f58cab49cf5fe2c9a8a1c2251d650Also, I can skip the call to the display table if I didn't find any rows to delete in the survey table.-º2013-02-27 22:57:42.0000002013-02-27 22:57:42.000000‚N¥®<[]{AAhttps://github.com/sportngin/ngin/commit/04c73fc142ae27a991b9651eed80b364137c8afa#commitcomment-2709308https://api.github.com/repos/sportngin/ngin/comments/27093086604c73fc142ae27a991b9651eed80b364137c8afaany particular reason you need :if => :persisted? here?º†2013-02-27 22:57:07.0000002013-02-27 22:57:07.000000‚S¥®8[]AAhttps://github.com/sportngin/ngin/commit/7e65aa17fe6f58cab49cf5fe2c9a8a1c2251d650#commitcomment-2709304https://api.github.com/repos/sportngin/ngin/comments/2709304 107e65aa17fe6f58cab49cf5fe2c9a8a1c2251d650Crap. Yeah, that's what I intended to do with them. Oops.-º2013-02-27 22:56:17.0000002013-02-27 22:56:17.000000 †® ƒ } ËZî¶"W†ƒK«í[]‚sAAhttps://github.com/sportngin/ngin/commit/eb2760c65146c5286c964a0ae4e7705c309d7d29#commitcomment-2815743https://api.github.com/repos/sportngin/ngin/comments/281574364eb2760c65146c5286c964a0ae4e7705c309d7d29Nice, I didn't know about that one. I guess that's one way to solve it, then it gives them the feeling that they're doing something... but I still think we should change the text¨“2013-03-15 17:33:06.0000002013-03-15 17:33:06.000000ƒE«íf[]‚gAAhttps://github.com/sportngin/ngin/commit/eb2760c65146c5286c964a0ae4e7705c309d7d29#commitcomment-2815718https://api.github.com/repos/sportngin/ngin/comments/281571864eb2760c65146c5286c964a0ae4e7705c309d7d29No its for allowing an event to happen once http://api.jquery.com/one/ We can i just though we would just disable the link and they can click it as many times as they want.º†2013-03-15 17:29:56.0000002013-03-15 17:30:10.000000ƒ«íW[]yAAhttps://github.com/sportngin/ngin/commit/eb2760c65146c5286c964a0ae4e7705c309d7d29#commitcomment-2815703https://api.github.com/repos/sportngin/ngin/comments/281570364eb2760c65146c5286c964a0ae4e7705c309d7d29Shouldn't this `one` be `on`? Also, we'll want to change the text to be something like - "generating the report..."¨“2013-03-15 17:27:58.0000002013-03-15 17:27:58.000000‚2¨Í([]AAAhttps://github.com/sportngin/ngin/commit/b1fd28afd42da54c05d60014634a4c937e1a59c8#commitcomment-2762408https://api.github.com/repos/sportngin/ngin/comments/2762408267b1fd28afd42da54c05d60014634a4c937e1a59c8Need to revert this commit©]2013-03-07 21:32:18.0000002013-03-07 21:32:18.000000‚f¨™I[]/AAhttps://github.com/sportngin/ngin/commit/eb9eb22af6c69e718bfc25ae62f8ad12b97928b0#commitcomment-2755785https://api.github.com/repos/sportngin/ngin/comments/2755785eb9eb22af6c69e718bfc25ae62f8ad12b97928b0To clarify: this controller no longer defines these particular instance variables–½2013-03-07 02:57:14.0000002013-03-07 02:57:14.000000‚k§Á&[]5AAhttps://github.com/sportngin/ngin/commit/bd10b4725442698769f6796c503b567ac7b9bf16#commitcomment-2744486https://api.github.com/repos/sportngin/ngin/comments/27444863bd10b4725442698769f6796c503b567ac7b9bf16Future reference, use the helper for this: ```ruby if Rails.env.production? ```Êž2013-03-05 19:23:20.0000002013-03-05 19:24:09.000000ƒ,§‚k[]‚;AAhttps://github.com/sportngin/ngin/commit/35926dd98197b525d0de1ab084987af6610ad37a#commitcomment-2736491https://api.github.com/repos/sportngin/ngin/comments/273649135926dd98197b525d0de1ab084987af6610ad37aIs there a reason this needs to be specific to live scoring? It would be nice if we could always do the same thing when setting the game result stat. >ð2013-03-04 20:07:13.0000002013-03-04 20:07:13.000000„§W[]ƒ]AAhttps://github.com/sportngin/ngin/commit/1286bc43b13b1d5af3a20d5f5c8888c13eed431d#commitcomment-2736343https://api.github.com/repos/sportngin/ngin/comments/2736343281286bc43b13b1d5af3a20d5f5c8888c13eed431dYou might consider adding a comment here, because I had to hop into `irb` just to confirm what you have here did what I was assuming it did. It's cool, but not directly obvious what is happening here and could confuse a future dev.Êž2013-03-04 19:53:23.0000002013-03-04 19:53:23.000000‚%§?[])AAhttps://github.com/sportngin/ngin/commit/1286bc43b13b1d5af3a20d5f5c8888c13eed431d#commitcomment-2736319https://api.github.com/repos/sportngin/ngin/comments/2736319281286bc43b13b1d5af3a20d5f5c8888c13eed431dTricky tricky.Êž2013-03-04 19:51:18.0000002013-03-04 19:51:18.000000‚L¥ëm[]}AAhttps://github.com/sportngin/ngin/commit/1706fc673e56e1e0612ace5d59e182a83d28de11#commitcomment-2717165https://api.github.com/repos/sportngin/ngin/comments/27171651706fc673e56e1e0612ace5d59e182a83d28de11Damn... commit message totally didn't work... ah well...Êž2013-02-28 21:23:41.0000002013-02-28 21:23:41.000000 ½° Û ª @oÚ_I½ƒ­í1[]iAAhttps://github.com/sportngin/ngin/commit/58565b91498a1f50bc4dc5471967e5f2207c2442#commitcomment-2848433https://api.github.com/repos/sportngin/ngin/comments/2848433(4258565b91498a1f50bc4dc5471967e5f2207c2442It probably is the safer way to go to be honest, I was just making sure there was a reason for the extra code.Êž2013-03-20 23:21:22.0000002013-03-20 23:21:22.000000„­í#[]ƒ}AAhttps://github.com/sportngin/ngin/commit/58565b91498a1f50bc4dc5471967e5f2207c2442#commitcomment-2848419https://api.github.com/repos/sportngin/ngin/comments/28484191958565b91498a1f50bc4dc5471967e5f2207c2442A comment explaining what `params` is also wouldn't hurt (I had to pull this branch down just to figure out what the params object was). Also, keep in mind you can do this as well with a hash: ```ruby tabs = params.map{|key, value| value} ```Êž2013-03-20 23:19:19.0000002013-03-20 23:19:40.000000‚u­í[]MAAhttps://github.com/sportngin/ngin/commit/58565b91498a1f50bc4dc5471967e5f2207c2442#commitcomment-2848410https://api.github.com/repos/sportngin/ngin/comments/284841058565b91498a1f50bc4dc5471967e5f2207c2442Good point, I'll add tests and comments tomorrow. I was getting annoyed and wanted to be done :)¨“2013-03-20 23:18:26.0000002013-03-20 23:18:26.000000ƒ­í[]{AAhttps://github.com/sportngin/ngin/commit/58565b91498a1f50bc4dc5471967e5f2207c2442#commitcomment-2848401https://api.github.com/repos/sportngin/ngin/comments/2848401(4258565b91498a1f50bc4dc5471967e5f2207c2442I probably can change that back, it was just giving me issues when deleting tabs before, but that should be solved now.¨“2013-03-20 23:17:41.0000002013-03-20 23:17:41.000000ƒK­í[]‚sAAhttps://github.com/sportngin/ngin/commit/58565b91498a1f50bc4dc5471967e5f2207c2442#commitcomment-2848391https://api.github.com/repos/sportngin/ngin/comments/2848391(4258565b91498a1f50bc4dc5471967e5f2207c2442So just to clarify, are you doing the `.each_with_index` and using that as the `position` because you don't trust the front end to do it right? Otherwise you could just use that.Êž2013-03-20 23:16:21.0000002013-03-20 23:16:21.000000‚d­ìq[]%AAhttps://github.com/sportngin/ngin/commit/58565b91498a1f50bc4dc5471967e5f2207c2442#commitcomment-2848369https://api.github.com/repos/sportngin/ngin/comments/2848369!3758565b91498a1f50bc4dc5471967e5f2207c2442Interesting trick. A little confusing to follow, so comments wouldn't hurt.Êž2013-03-20 23:13:29.0000002013-03-20 23:13:29.000000‚+­êT[];AAhttps://github.com/sportngin/ngin/commit/58565b91498a1f50bc4dc5471967e5f2207c2442#commitcomment-2848084https://api.github.com/repos/sportngin/ngin/comments/284808458565b91498a1f50bc4dc5471967e5f2207c2442Nice tests :trollface: Êž2013-03-20 22:29:37.0000002013-03-20 22:29:37.000000ƒO¬ÉU[]ƒAAhttps://github.com/sportngin/ngin/commit/1cf6b2374aa5ae521993b8adb9a1fb96b2e45f3d#commitcomment-2827477https://api.github.com/repos/sportngin/ngin/comments/28274771cf6b2374aa5ae521993b8adb9a1fb96b2e45f3dThis is a very subtle, but great addition. It really shows the 'holes' in the stat data, and can make improving the captured at a glance really easy. And it is very safe change. :+1: Êž2013-03-18 17:07:11.0000002013-03-18 17:07:11.000000‚J«òB[]sAAhttps://github.com/sportngin/ngin/commit/2a95555534a10ef2808836cb4e0d68b1f301a4b2#commitcomment-2816322https://api.github.com/repos/sportngin/ngin/comments/2816322102a95555534a10ef2808836cb4e0d68b1f301a4b2I'd throw a comment on here, for future generations¨“2013-03-15 18:41:08.0000002013-03-15 18:41:08.000000 È H Þ þ’Sø–íÈ‚¶ÿ2[]#AAhttps://github.com/sportngin/ngin/commit/d541baeab0353fd76de6c6260c6d01818afb058d#commitcomment-2998194https://api.github.com/repos/sportngin/ngin/comments/2998194d541baeab0353fd76de6c6260c6d01818afb058dHere it is! ™Å2013-04-12 06:15:41.0000002013-04-12 06:15:41.000000ƒ#¶ÿ1[]‚#AAhttps://github.com/sportngin/ngin/commit/7a0a0537994050077234209df80bb42dac5cdfd5#commitcomment-2998193https://api.github.com/repos/sportngin/ngin/comments/2998193307a0a0537994050077234209df80bb42dac5cdfd5I'm looking at the individual commits so you probably already fixed this, but just want to point out you have a missing closing parens here ™Å2013-04-12 06:15:23.0000002013-04-12 06:15:23.000000‚\²ê[]AAhttps://github.com/sportngin/ngin/commit/5944fa55ee1afa3fff1876d0ebd45e91c6dc8d27#commitcomment-2929934https://api.github.com/repos/sportngin/ngin/comments/2929934B1155944fa55ee1afa3fff1876d0ebd45e91c6dc8d27http://apidock.com/rails/ActiveSupport/CoreExtensions/Hash/to_queryÞþ2013-04-02 18:53:57.0000002013-04-02 18:53:57.000000„U°’>[]…AAhttps://github.com/sportngin/ngin/commit/10211b2855341740696c388ba49390c75cfa43cf#commitcomment-2885950https://api.github.com/repos/sportngin/ngin/comments/2885950Z3910211b2855341740696c388ba49390c75cfa43cf@marklarr I am using the index action to get the roster player data for subseasons. It's currently in production. Which branch are you working on? Just want to make sure the index action isn't deleted in your branch. I will add this back to staging branch because I need to use it to get some data for a client today.ñ¥2013-03-26 22:14:29.0000002013-03-26 22:14:29.000000‚9¯±w[]SAAhttps://github.com/sportngin/ngin/commit/449a68b24367f45b4deba19233cf72b3eb8294c9#commitcomment-2873591https://api.github.com/repos/sportngin/ngin/comments/28735914449a68b24367f45b4deba19233cf72b3eb8294c9I think this will work well. :+1: Êž2013-03-25 14:37:04.0000002013-03-25 14:37:04.000000‚f®©[])AAhttps://github.com/sportngin/ngin/commit/9395165ccb8fcd35f25ec8bb2e5e1690183bf7c0#commitcomment-2856080https://api.github.com/repos/sportngin/ngin/comments/2856080 249395165ccb8fcd35f25ec8bb2e5e1690183bf7c0Maybe add a comment about here too. Since you can't change that variable name.º†2013-03-21 20:39:05.0000002013-03-21 20:39:05.000000ƒZ®¨n[]ƒAAhttps://github.com/sportngin/ngin/commit/9395165ccb8fcd35f25ec8bb2e5e1690183bf7c0#commitcomment-2856046https://api.github.com/repos/sportngin/ngin/comments/28560465579395165ccb8fcd35f25ec8bb2e5e1690183bf7c0Good point, the reason it's done that way is because we don't have a list of the tabs we want to destroy because they just aren't passed in from the form. I'll at least change the variable name.¨“2013-03-21 20:34:33.0000002013-03-21 20:34:33.000000‚d®¨d[]%AAhttps://github.com/sportngin/ngin/commit/9395165ccb8fcd35f25ec8bb2e5e1690183bf7c0#commitcomment-2856036https://api.github.com/repos/sportngin/ngin/comments/28560365579395165ccb8fcd35f25ec8bb2e5e1690183bf7c0I guess its a private method so its less important but it still seems weird.º†2013-03-21 20:33:34.0000002013-03-21 20:33:34.000000…2®¨\[]†AAAhttps://github.com/sportngin/ngin/commit/9395165ccb8fcd35f25ec8bb2e5e1690183bf7c0#commitcomment-2856028https://api.github.com/repos/sportngin/ngin/comments/28560285579395165ccb8fcd35f25ec8bb2e5e1690183bf7c0this sort of weirds me out. Any reason its not the list of tabs to destroy? The method name seems kind of misleading. at least change the tabs variable to be tabs_to_keep or something like that. The weird thing is that it will still look weird in the caller It seems easy to make this mistake: ```ruby #page element controller @element.destroy_containers(the_containers_you_want_to_destroy) ```º†2013-03-21 20:32:24.0000002013-03-21 20:32:24.000000 ì& c  ã\ Ù^ì„l·–7[]…5AAhttps://github.com/sportngin/ngin/commit/078b689a311c57418e2929aabb940a81cdfafccd#commitcomment-3001143https://api.github.com/repos/sportngin/ngin/comments/300114331078b689a311c57418e2929aabb940a81cdfafccdIt's supposed to be optional, so I made it so I only added it to the list if the key existed. That said, I probably still could have left it in the `.slice` because if a key doesn't exist, it just doesn't include it in the output. ```ruby {:foo => "Hello World", :bar => "marklarr"}.slice(:foo, :baz) # => {:foo => "Hello World"} ```Êž2013-04-12 14:58:23.0000002013-04-12 14:58:23.000000‚u·•i[]GAAhttps://github.com/sportngin/ngin/commit/078b689a311c57418e2929aabb940a81cdfafccd#commitcomment-3001065https://api.github.com/repos/sportngin/ngin/comments/300106531078b689a311c57418e2929aabb940a81cdfafccdoh, you added the `timestamp_question_id`. Is there a reason you didn't just slice that also? ™Å2013-04-12 14:52:40.0000002013-04-12 14:52:40.000000‚,·•[[]7AAhttps://github.com/sportngin/ngin/commit/078b689a311c57418e2929aabb940a81cdfafccd#commitcomment-3001051https://api.github.com/repos/sportngin/ngin/comments/300105131078b689a311c57418e2929aabb940a81cdfafccdwas this not working? ™Å2013-04-12 14:51:27.0000002013-04-12 14:51:27.000000‚K·•3[]uAAhttps://github.com/sportngin/ngin/commit/2245cbb4144239bd7214d0ac0e564c21b8d0c022#commitcomment-3001011https://api.github.com/repos/sportngin/ngin/comments/3001011262245cbb4144239bd7214d0ac0e564c21b8d0c022As awesome as this is.. don't forget to change it :P ™Å2013-04-12 14:48:03.0000002013-04-12 14:48:03.000000ƒ¶ÿ\[]_AAhttps://github.com/sportngin/ngin/commit/6059b696ff21ddad66b56e062d051c409b6b7ee8#commitcomment-2998236https://api.github.com/repos/sportngin/ngin/comments/2998236196059b696ff21ddad66b56e062d051c409b6b7ee8I was just going to suggest naming this variable more specifically on the last commit, but lo-and-behold! ™Å2013-04-12 06:26:38.0000002013-04-12 06:26:38.000000‚/¶ÿY[];AAhttps://github.com/sportngin/ngin/commit/94275a67d879b9794e0efcafc58ddf5352e2071a#commitcomment-2998233https://api.github.com/repos/sportngin/ngin/comments/2998233'19594275a67d879b9794e0efcafc58ddf5352e2071a`Integer` in the house! ™Å2013-04-12 06:24:45.0000002013-04-12 06:24:45.000000‚E¶ÿU[]gAAhttps://github.com/sportngin/ngin/commit/94275a67d879b9794e0efcafc58ddf5352e2071a#commitcomment-2998229https://api.github.com/repos/sportngin/ngin/comments/299822916694275a67d879b9794e0efcafc58ddf5352e2071amaybe keep this consistent with line 162? lol ™Å2013-04-12 06:23:34.0000002013-04-12 06:23:34.000000ƒ=¶ÿP[]‚WAAhttps://github.com/sportngin/ngin/commit/2245cbb4144239bd7214d0ac0e564c21b8d0c022#commitcomment-2998224https://api.github.com/repos/sportngin/ngin/comments/2998224512245cbb4144239bd7214d0ac0e564c21b8d0c022Or, actually, looking at the tracking controller, is there anything in there that prevents them from saving a status if the question exists but tracking is disabled? ™Å2013-04-12 06:22:25.0000002013-04-12 06:22:25.000000ƒT¶ÿD[]ƒAAhttps://github.com/sportngin/ngin/commit/2245cbb4144239bd7214d0ac0e564c21b8d0c022#commitcomment-2998212https://api.github.com/repos/sportngin/ngin/comments/2998212512245cbb4144239bd7214d0ac0e564c21b8d0c022is it worth tracking video usage if we know the video doesn't have tracking enabled? the controller we AJAX post to will just disregard requests when it sees there are no QuestionElements? ™Å2013-04-12 06:19:36.0000002013-04-12 06:19:36.000000 x æ š ÐÐx‚R·ù[]}AAhttps://github.com/sportngin/ngin/commit/20076f703f0f3daf66bb3903b418db45f88bf72c#commitcomment-3013760https://api.github.com/repos/sportngin/ngin/comments/3013760J1965520076f703f0f3daf66bb3903b418db45f88bf72c@dhoffmann try adding this line back to make tests pass.ñ¥2013-04-15 15:16:15.0000002013-04-15 15:16:15.000000ƒz·õ0[]ƒQAAhttps://github.com/sportngin/ngin/commit/a9758deaf5c4a700d9617775a327349cb2224227#commitcomment-3013296https://api.github.com/repos/sportngin/ngin/comments/301329689a9758deaf5c4a700d9617775a327349cb2224227I don't think this will fix the double render issue. If you do a redirect outside of an action you have to force that redirect method to return from the action so something like ```ruby failed_checkout and return ``` º†2013-04-15 14:23:08.0000002013-04-15 14:23:08.000000‚C·˜a[]eAAhttps://github.com/sportngin/ngin/commit/2245cbb4144239bd7214d0ac0e564c21b8d0c022#commitcomment-3001441https://api.github.com/repos/sportngin/ngin/comments/3001441512245cbb4144239bd7214d0ac0e564c21b8d0c022dear god that's a lot of videos on one page. ™Å2013-04-12 15:30:41.0000002013-04-12 15:30:41.000000…j·—^[]‡1AAhttps://github.com/sportngin/ngin/commit/2245cbb4144239bd7214d0ac0e564c21b8d0c022#commitcomment-3001310https://api.github.com/repos/sportngin/ngin/comments/3001310512245cbb4144239bd7214d0ac0e564c21b8d0c022Yeah, the other thing I was considering is moving this into the `public/javascripts/ngin/av.js` file. As much as I wanted to keep that file clean of cruft like this, if we go this route, we put this function on the page every time there is a video on the page. So for a page like [this](http://www.paincave.com.dev/page/show/647928-videos)... alot.... ![alot...](http://www.mentalfloss.com/sites/default/legacy/blogs/wp-content/uploads/2011/02/550_alotAlix.jpg)Êž2013-04-12 15:19:05.0000002013-04-12 15:19:05.000000ƒ ·—>[]sAAhttps://github.com/sportngin/ngin/commit/2245cbb4144239bd7214d0ac0e564c21b8d0c022#commitcomment-3001278https://api.github.com/repos/sportngin/ngin/comments/3001278512245cbb4144239bd7214d0ac0e564c21b8d0c022on second thought.. you could just do `<% if @site.using_video_element_tracking? and video.tracking_enabled? %>` ™Å2013-04-12 15:15:33.0000002013-04-12 15:15:41.000000‚F·—3[]kAAhttps://github.com/sportngin/ngin/commit/2245cbb4144239bd7214d0ac0e564c21b8d0c022#commitcomment-3001267https://api.github.com/repos/sportngin/ngin/comments/3001267512245cbb4144239bd7214d0ac0e564c21b8d0c022it's up to you, I just thought I'd point it out ™Å2013-04-12 15:13:57.0000002013-04-12 15:13:57.000000†·–b[]ˆ AAhttps://github.com/sportngin/ngin/commit/2245cbb4144239bd7214d0ac0e564c21b8d0c022#commitcomment-3001186https://api.github.com/repos/sportngin/ngin/comments/3001186512245cbb4144239bd7214d0ac0e564c21b8d0c022On the `VideoTrackingController` end, I didn't put anything in place to check if the video in question was actually tracking, so theoretically, you update any question this way. I felt like it was extra query's that didn't need to be there to load the video element as well. It does check if the user is signed in, and will only get user survey's from the `current_user` object as well. I could add it I guess, but I was trying to keep the `update_tracking_data` method as lightweight and quick as possible.Êž2013-04-12 15:03:38.0000002013-04-12 15:03:38.000000ƒv·–E[]ƒIAAhttps://github.com/sportngin/ngin/commit/2245cbb4144239bd7214d0ac0e564c21b8d0c022#commitcomment-3001157https://api.github.com/repos/sportngin/ngin/comments/3001157262245cbb4144239bd7214d0ac0e564c21b8d0c022Yes, I forgot to not commit this last night, but if you are going to code review by adding comments to my commits (instead of the diff), you should at least cross reference it with the diff... because I already removed it.Êž2013-04-12 14:59:57.0000002013-04-12 15:04:30.000000 Å ø Qݼwö§"Å‚W¹›^[]AAhttps://github.com/sportngin/ngin/commit/713e5d3aaa9e2106eefccec98454556cd32ec3f1#commitcomment-3034590https://api.github.com/repos/sportngin/ngin/comments/3034590713e5d3aaa9e2106eefccec98454556cd32ec3f1@stuartnelson3 You are going to want change the filenames as well.Êž2013-04-17 23:41:56.0000002013-04-17 23:42:05.000000‚¹‡[[][AAhttps://github.com/sportngin/ngin/commit/7d9aa3d55fa4fe001c6e5e098bf2e6b1c1177191#commitcomment-3032027https://api.github.com/repos/sportngin/ngin/comments/3032027167d9aa3d55fa4fe001c6e5e098bf2e6b1c1177191lol i literally wrote that, then deleted it. yeah it is standard meta practice, i'll get that in there.UX2013-04-17 17:05:43.0000002013-04-17 17:05:43.000000‚I¹‡L[]qAAhttps://github.com/sportngin/ngin/commit/7d9aa3d55fa4fe001c6e5e098bf2e6b1c1177191#commitcomment-3032012https://api.github.com/repos/sportngin/ngin/comments/3032012167d9aa3d55fa4fe001c6e5e098bf2e6b1c1177191Or above the method is probably standard practice.Êž2013-04-17 17:02:30.0000002013-04-17 17:02:30.000000‚{¹‡J[]SAAhttps://github.com/sportngin/ngin/commit/7d9aa3d55fa4fe001c6e5e098bf2e6b1c1177191#commitcomment-3032010https://api.github.com/repos/sportngin/ngin/comments/3032010167d9aa3d55fa4fe001c6e5e098bf2e6b1c1177191I think the comment of `# Adds methods 'add_win', 'add_loss', 'add_tie'` might be appropriate here.Êž2013-04-17 17:01:59.0000002013-04-17 17:01:59.000000‚?¹2[]cAAhttps://github.com/sportngin/ngin/commit/aadd876ab4687c7336d5e16ca5c47f7fbee69510#commitcomment-3031218https://api.github.com/repos/sportngin/ngin/comments/3031218aadd876ab4687c7336d5e16ca5c47f7fbee69510https://github.com/sportngin/ngin/pull/2240ðž2013-04-17 15:33:10.0000002013-04-17 15:33:10.000000‚¸ÿ#[]AAhttps://github.com/sportngin/ngin/commit/aadd876ab4687c7336d5e16ca5c47f7fbee69510#commitcomment-3030947https://api.github.com/repos/sportngin/ngin/comments/30309475aadd876ab4687c7336d5e16ca5c47f7fbee69510yes. ðž2013-04-17 15:02:56.0000002013-04-17 15:02:56.000000‚n¸ÿ[];AAhttps://github.com/sportngin/ngin/commit/aadd876ab4687c7336d5e16ca5c47f7fbee69510#commitcomment-3030928https://api.github.com/repos/sportngin/ngin/comments/30309285aadd876ab4687c7336d5e16ca5c47f7fbee69510"config_file" doesn't exist at this line. I assume you wanted "guardhouse_config_file"?bG2013-04-17 15:00:59.0000002013-04-17 15:00:59.000000ƒ!¸R[]‚#AAhttps://github.com/sportngin/ngin/commit/aa7ea88f8b3402b1752da8666cc4080e030e2731#commitcomment-3016402https://api.github.com/repos/sportngin/ngin/comments/30164020aa7ea88f8b3402b1752da8666cc4080e030e2731please ``` git rm config/guardhouse.yml ``` We don't want this file in the history. Also you'll need to merge master into this branch.º†2013-04-15 20:29:11.0000002013-04-15 20:29:11.000000ˆ¸€![]‹_AAhttps://github.com/sportngin/ngin/commit/496897544f01ae7d38e5e0011067d393d41f803d#commitcomment-3014689https://api.github.com/repos/sportngin/ngin/comments/3014689136496897544f01ae7d38e5e0011067d393d41f803dSo this is actually going to "invalidate" site 3322. It has a weird code to it, and I am not sure it is valid to begin with... Also, I think the `\S` is a bit too loose for this regexp. I think something like `[0-9A-z\-]` would be a little better (only allows numbers, letters and `-`'s). You could also switch it to something like `[A-z]-[0-9A-z]` to assume that the format is `{character}-{alpha_numeric_chars}{13}`. Again, it also seems like site `3322` doesn't have a 15 character code, which would also be problematic Again, I am not sure on the format of the quantcast analytics code, and since there is only a sample of 3 sites on our system that use it, it is hard for me to say one way or the other on what the true format is.Êž2013-04-15 17:08:45.0000002013-04-15 17:08:45.000000 ááÛ º ] ,…6‚‚ËimMWCkwsacy…N¹l!mM[Go { weg}{…ÛámMS?gso]_usAAkjbkjbhttps://avatars.github…ÛámMS?gso]_usAAkjbkjbhttps://avatars.githubusercontent.com/u/1503390?ff4729ee6e32695128a2689e5b964521https://api.github.com/users/kjbkjbhttps://github.com/kjbkjbhttps://api.github.com/users/kjbkjb/followershttps://api.github.com/users/kjbkjb/following{/other_user}https://api.github.com/users/kjbkjb/gists{/gist_id}https://api.github.com/users/kjbkjb/starred{/owner}{/repo}https://api.github.com/users/kjbkjb/subscriptionshttps://api.github.com/users/kjbkjb/orgshttps://api.github.com/users/kjbkjb/reposhttps://api.github.com/users/kjbkjb/events{/privac…uÕªX'mMaMu}kmAAstuartnelson3https://avatars.githubusercontent.com/u/1398104?c6e2bd81e1e4915e52fcd3ff67d35590https://api.github.com/users/stuartnelson3https://github.com/stuartnelson3https://api.github.com/users/stuartnelson3/followershttps://api.github.com/users/stuartnelson3/following{/other_user}https://api.github.com/users/stuartnelson3/gists{/gist_id}https://api.github.com/users/stuartnelson3/starred{/owner}{/repo}https://api.github.com/users/stuartnelson3/subscriptionshttps://api.github.com/users/stuartnelson3/orgshttps://api.github.com/users/stuartnelson3/reposhttps://api.github.com/users/stuartnelson3/events{/privacy}https://api.github.com/users/stuartnelson3/received_eventsUserf2014-06-05 15:35:59.3110472014-06-05 15:35:59.311047…ZÖ€5#mM]Iq } ygi}AAnatejgreenehttps://avatars.githubusercontent.com/u/1409077?eceec7f2ab131f810402d3593b8bcfb7https://api.github.com/users/natejgreenehttps://github.com/natejgreenehttps://api.github.com/users/natejgreene/followershttps://api.github.com/users/natejgreene/following{/other_user}https://api.github.com/users/natejgreene/gists{/gist_id}https://api.github.com/users/natejgreene/starred{/owner}{/repo}https://api.github.com/users/natejgreene/subscriptionshttps://api.github.com/users/natejgreene/orgshttps://api.github.com/users/natejgreene/reposhttps://api.github.com/users/natejgreene/events{/privacy}https://api.github.com/users/natejgreene/received_eventsUserf2014-06-05 15:35:56.0100672014-06-05 15:35:56.010067…ÛámMS?gso]_usAAkjbkjbhttps://avatars.githubusercontent.com/u/1503390?ff4729ee6e32695128a2689e5b964521https://api.github.com/users/kjbkjbhttps://github.com/kjbkjbhttps://api.github.com/users/kjbkjb/followershttps://api.github.com/users/kjbkjb/following{/other_user}https://api.github.com/users/kjbkjb/gists{/gist_id}https://api.github.com/users/kjbkjb/starred{/owner}{/repo}https://api.github.com/users/kjbkjb/subscriptionshttps://api.github.com/users/kjbkjb/orgshttps://api.github.com/users/kjbkjb/reposhttps://api.github.com/users/kjbkjb/events{/privacy}https://api.github.com/users/kjbkjb/received_eventsUserf2014-06-05 15:35:56.1902242014-06-05 15:35:56.190224…ë¤mmMS?gso]_usAApnvanghttps://avatars.githubusercontent.com/u/1757805?c8135eb96c2f0f1de52207b43332fefbhttps://api.github.com/users/pnvanghttps://github.com/pnvanghttps://api.github.com/users/pnvang/followershttps://api.github.com/users/pnvang/following{/other_user}https://api.github.com/users/pnvang/gists{/gist_id}https://api.github.com/users/pnvang/starred{/owner}{/repo}https://api.github.com/users/pnvang/subscriptionshttps://api.github.com/users/pnvang/orgshttps://api.github.com/users/pnvang/reposhttps://api.github.com/users/pnvang/events{/privacy}https://api.github.com/users/pnvang/received_eventsUserf2014-06-05 15:35:57.8718722014-06-05 15:35:57.871872 q3 t …ïû¸q‚A¹×k[]_AAhttps://github.com/sportngin/ngin/commit/16bd3d26d48d5e81b5de3643398492a1509507df#commitcomment-3042283https://api.github.com/repos/sportngin/ngin/comments/304228310816bd3d26d48d5e81b5de3643398492a1509507dfTypo here. Should be "(comma separated)".…2013-04-18 21:24:16.0000002013-04-18 21:24:16.000000‚=¹Î[]WAAhttps://github.com/sportngin/ngin/commit/b8689b3b813c1ad2a89ee4240c0ac0beb206bb0f#commitcomment-3041049https://api.github.com/repos/sportngin/ngin/comments/3041049113b8689b3b813c1ad2a89ee4240c0ac0beb206bb0fOK, Please add it as a pivotal story.€52013-04-18 19:00:57.0000002013-04-18 19:00:57.000000ƒ¹ÍT[]wAAhttps://github.com/sportngin/ngin/commit/b8689b3b813c1ad2a89ee4240c0ac0beb206bb0f#commitcomment-3040980https://api.github.com/repos/sportngin/ngin/comments/3040980113b8689b3b813c1ad2a89ee4240c0ac0beb206bb0fThat seems like a larger initiative that we'd want to tackle for all gateways. I'm not prepared to do this right now.ðž2013-04-18 18:50:36.0000002013-04-18 18:50:36.000000‚Z¹ËE[]AAhttps://github.com/sportngin/ngin/commit/b8689b3b813c1ad2a89ee4240c0ac0beb206bb0f#commitcomment-3040709https://api.github.com/repos/sportngin/ngin/comments/3040709113b8689b3b813c1ad2a89ee4240c0ac0beb206bb0fWondering if this should go in the gateway code to be consistent.€52013-04-18 18:20:20.0000002013-04-18 18:20:20.000000ƒ¹ÃS[]wAAhttps://github.com/sportngin/ngin/commit/fd2d9565c5fd63e2e2e32362a147e96ba806be38#commitcomment-3039699https://api.github.com/repos/sportngin/ngin/comments/303969920167fd2d9565c5fd63e2e2e32362a147e96ba806be38This was right. There are currently 119 site_setting_types in the test_database, so this should be 1 more then that.Êž2013-04-18 16:06:34.0000002013-04-18 16:06:34.000000„¹Ÿ[]…aAAhttps://github.com/sportngin/ngin/commit/713e5d3aaa9e2106eefccec98454556cd32ec3f1#commitcomment-3035022https://api.github.com/repos/sportngin/ngin/comments/3035022713e5d3aaa9e2106eefccec98454556cd32ec3f1Sorry, didn't mean to make a :fire: to some OS software, so I give a :+1: for using that. If you are looking for something a little less verbose, and more along the lines of a screenshot tool (that isn't the bastardized version of [Skitch](http://evernote.com/skitch/) that Evernote released), then you might be interested in [monosnap](http://monosnap.com/).Êž2013-04-18 01:26:59.0000002013-04-18 01:26:59.000000‚d¹ž`[]+AAhttps://github.com/sportngin/ngin/commit/713e5d3aaa9e2106eefccec98454556cd32ec3f1#commitcomment-3034976https://api.github.com/repos/sportngin/ngin/comments/3034976713e5d3aaa9e2106eefccec98454556cd32ec3f1....seashore... http://seashore.sourceforge.net/The_Seashore_Project/About.htmlUX2013-04-18 01:15:05.0000002013-04-18 01:15:05.000000ƒ9¹œv[]‚UAAhttps://github.com/sportngin/ngin/commit/713e5d3aaa9e2106eefccec98454556cd32ec3f1#commitcomment-3034742https://api.github.com/repos/sportngin/ngin/comments/3034742713e5d3aaa9e2106eefccec98454556cd32ec3f1I stand corrected. Sorry, was just looking into reason's to why your build is failing. P.S. what the :shit: did you use to annotate that screen shot... MSPaint?Êž2013-04-18 00:12:50.0000002013-04-18 00:12:50.000000ƒG¹œ[]‚qAAhttps://github.com/sportngin/ngin/commit/713e5d3aaa9e2106eefccec98454556cd32ec3f1#commitcomment-3034655https://api.github.com/repos/sportngin/ngin/comments/3034655713e5d3aaa9e2106eefccec98454556cd32ec3f1they were — check the arrow after the name ![Screen Shot 2013-04-17 at 6 53 25 PM](https://f.cloud.github.com/assets/1398104/394316/1f4cc65a-a7ba-11e2-8238-8ac08f3e80e8.png) UX2013-04-17 23:54:22.0000002013-04-17 23:54:22.000000 A Ô » Q דí›A‚Tº”[]AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050005https://api.github.com/repos/sportngin/ngin/comments/3050005 1177717c354326524b2785f3450065e7d313650040```ruby if !(failed_ids.nil? || failed_ids.length < 1) ```Þþ2013-04-19 20:33:23.0000002013-04-19 20:34:46.000000‚Lº”[]wAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3049998https://api.github.com/repos/sportngin/ngin/comments/3049998 1177717c354326524b2785f3450065e7d313650040guys guys ```ruby unless !!failed_ids.empty? ```Þþ2013-04-19 20:32:28.0000002013-04-19 20:32:39.000000ƒ º“v[]‚AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3049974https://api.github.com/repos/sportngin/ngin/comments/3049974 1177717c354326524b2785f3450065e7d313650040or since this is rails ``` if failed_ids.present? ``` which is also nil-safe which any/empty arent (not that that's a huge concern here)bG2013-04-19 20:27:47.0000002013-04-19 20:27:47.000000‚>º’r[][AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3049842https://api.github.com/repos/sportngin/ngin/comments/3049842 1177717c354326524b2785f3450065e7d313650040Or `if faild_ids.any?`. You know, Ruby.…2013-04-19 20:06:40.0000002013-04-19 20:06:40.000000‚/º’e[]=AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3049829https://api.github.com/repos/sportngin/ngin/comments/3049829 1177717c354326524b2785f3450065e7d313650040whats wrong with unless?º†2013-04-19 20:05:07.0000002013-04-19 20:05:07.000000‚?¹Ù[]cAAhttps://github.com/sportngin/ngin/commit/923dea9b3d14082eb595161a7b489cb3de72f819#commitcomment-3042461https://api.github.com/repos/sportngin/ngin/comments/3042461923dea9b3d14082eb595161a7b489cb3de72f819Nevermind... I might have figured it out...Êž2013-04-18 21:47:11.0000002013-04-18 21:47:11.000000‚d¹Ù[]+AAhttps://github.com/sportngin/ngin/commit/923dea9b3d14082eb595161a7b489cb3de72f819#commitcomment-3042453https://api.github.com/repos/sportngin/ngin/comments/3042453923dea9b3d14082eb595161a7b489cb3de72f819Now I am not liking your solution because of the stack level too deep errors...Êž2013-04-18 21:46:13.0000002013-04-18 21:46:13.000000„¹Ø=[]„ AAhttps://github.com/sportngin/ngin/commit/923dea9b3d14082eb595161a7b489cb3de72f819#commitcomment-3042365https://api.github.com/repos/sportngin/ngin/comments/3042365923dea9b3d14082eb595161a7b489cb3de72f819@pbyrne I am very much for that solution over my current implementation. Currently I am finding that extra_site_settings are getting created twice at the moment, and is causing duplicates in the DB. I like your solution a lot better, so I will do that.Êž2013-04-18 21:35:36.0000002013-04-18 21:35:36.000000†&¹Ø[]ˆ/AAhttps://github.com/sportngin/ngin/commit/923dea9b3d14082eb595161a7b489cb3de72f819#commitcomment-3042326https://api.github.com/repos/sportngin/ngin/comments/3042326923dea9b3d14082eb595161a7b489cb3de72f819This change gives me the willies. Is the issue that `Site.new(:quantcast_analytics_code => "asdf")` was breaking because the site's `extra_site_settings` was uninitialized? If so, does it make sense that we can roll this back, but overwrite the `Site#extra_site_settings` getter to do an `||= site.build_extra_site_settings`? Either way, we'll probably want to use the `build_extra_site_settings` convenience method rather than ExtraSiteDetails.new, because it automatically hooks up the site_id on the ExtraSiteDetails instance.…2013-04-18 21:29:52.0000002013-04-18 21:29:52.000000 Eo  L æWƒ5B‰E‚>º•[]]AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050132https://api.github.com/repos/sportngin/ngin/comments/3050132 1177717c354326524b2785f3450065e7d313650040Silly Phenow, you're writing Javascript!SS2013-04-19 20:48:22.0000002013-04-19 20:48:22.000000ƒ3º•[]‚CAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050128https://api.github.com/repos/sportngin/ngin/comments/3050128 1177717c354326524b2785f3450065e7d313650040actually in this case it shouldn't be unless. It should be if with the opposing function either ```if failed_ids.any?``` or ```if failed_ids.present?```bG2013-04-19 20:48:04.0000002013-04-19 20:48:04.000000ƒmº•[]ƒ7AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050126https://api.github.com/repos/sportngin/ngin/comments/3050126 1177717c354326524b2785f3450065e7d313650040But let's be real, we could probably just make it easy on ourselves and spin up a boolean-service. @pbyrne can we get http://boolean-service.stage.ngin-staging.com going so I can start development on this bad boy?Þþ2013-04-19 20:47:50.0000002013-04-19 20:47:50.000000‚Hº”{[]oAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050107https://api.github.com/repos/sportngin/ngin/comments/3050107 1177717c354326524b2785f3450065e7d313650040No I think we all agree it should be `unless` IRLÞþ2013-04-19 20:46:34.0000002013-04-19 20:46:34.000000ƒNº”d[]‚yAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050084https://api.github.com/repos/sportngin/ngin/comments/3050084 1177717c354326524b2785f3450065e7d313650040This goes to show you that ruby community has the inability to agree on one way to do something. And that everyone considers themselves "right" because that is the way they do it :)€52013-04-19 20:44:14.0000002013-04-19 20:44:25.000000ƒ º”S[]oAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050067https://api.github.com/repos/sportngin/ngin/comments/3050067 1177717c354326524b2785f3450065e7d313650040TIL Lack of code formatting == enterprisey edit: also incorrect code that doesn't actually function correctlyÞþ2013-04-19 20:42:02.0000002013-04-19 20:42:17.000000‚`º”L[]AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050060https://api.github.com/repos/sportngin/ngin/comments/3050060 1177717c354326524b2785f3450065e7d313650040Never underestimate @natejgreene's ability to make something enterprisy º†2013-04-19 20:41:05.0000002013-04-19 20:41:05.000000ƒEº”F[]‚gAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050054https://api.github.com/repos/sportngin/ngin/comments/3050054 1177717c354326524b2785f3450065e7d313650040def is_empty(ids) if ids if ids.length = 0 return true else return false end else return true end end if !is_empty(failed_ids)€52013-04-19 20:40:06.0000002013-04-19 20:41:15.000000‚Rº”0[]AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050032https://api.github.com/repos/sportngin/ngin/comments/3050032 1177717c354326524b2785f3450065e7d313650040```ruby if failed_ids.detect{|id| !id.nil?}.present? ```¨“2013-04-19 20:37:06.0000002013-04-19 20:37:06.000000ƒ º”*[]sAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050026https://api.github.com/repos/sportngin/ngin/comments/3050026 1177717c354326524b2785f3450065e7d313650040@jphenow more like: ``` if !(failed_ids.nil? || (failed_ids.respond_to?(:length) && failed_ids.length < 0)) ```bG2013-04-19 20:36:41.0000002013-04-19 20:36:41.000000 ㇠( à  ;Ã;±eã‚|º•y[]UAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050233https://api.github.com/repos/sportngin/ngin/comments/3050233 1177717c354326524b2785f3450065e7d313650040![image](https://f.cloud.github.com/assets/319230/404011/617a21c8-a934-11e2-8d39-65b31779b3a1.png) Þþ2013-04-19 21:02:05.0000002013-04-19 21:02:05.000000‚Fº•d[]kAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050212https://api.github.com/repos/sportngin/ngin/comments/3050212 1177717c354326524b2785f3450065e7d313650040As long as we're not worried about nil elementsÞþ2013-04-19 20:57:30.0000002013-04-19 20:57:30.000000ƒº•`[]eAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050208https://api.github.com/repos/sportngin/ngin/comments/3050208 1177717c354326524b2785f3450065e7d313650040I'm gonna go with @pbyrne here ```if Array(failed_ids).any?``` is both nil safe and works outside of rails bG2013-04-19 20:56:43.0000002013-04-19 20:56:43.000000‚Nº•U[]{AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050197https://api.github.com/repos/sportngin/ngin/comments/3050197 1177717c354326524b2785f3450065e7d313650040I thought the phrase was don't use no double negatives.Œ?2013-04-19 20:55:22.0000002013-04-19 20:55:22.000000‚.º•R[];AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050194https://api.github.com/repos/sportngin/ngin/comments/3050194 1177717c354326524b2785f3450065e7d313650040@pbyrne You forgot !! ðž2013-04-19 20:55:09.0000002013-04-19 20:55:09.000000‚rº•F[]AAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050182https://api.github.com/repos/sportngin/ngin/comments/3050182 1177717c354326524b2785f3450065e7d313650040@brycesch if you are going to use .blank? in the negative, you might as well use .present?bG2013-04-19 20:53:49.0000002013-04-19 20:53:49.000000‚>º•C[][AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050179https://api.github.com/repos/sportngin/ngin/comments/3050179 1177717c354326524b2785f3450065e7d313650040```ruby if Array(failed_ids).any? ```…2013-04-19 20:53:21.0000002013-04-19 20:53:21.000000‚[º•B[]AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050178https://api.github.com/repos/sportngin/ngin/comments/3050178 1177717c354326524b2785f3450065e7d313650040could also do ```unless failed_ids.blank?``` which also handles nilŒ?2013-04-19 20:53:11.0000002013-04-19 20:53:11.000000‚Bº•*[]cAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050154https://api.github.com/repos/sportngin/ngin/comments/3050154 1177717c354326524b2785f3450065e7d313650040```ruby if !!(failed_ids.first rescue nil)º†2013-04-19 20:50:11.0000002013-04-19 20:50:11.000000‚Yº•[]AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050142https://api.github.com/repos/sportngin/ngin/comments/3050142 1177717c354326524b2785f3450065e7d313650040@jphenow `git clone git@github.com:sportngin/boolean_service.git`¨“2013-04-19 20:49:23.0000002013-04-19 20:49:23.000000‚sº•[]CAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050139https://api.github.com/repos/sportngin/ngin/comments/3050139 1177717c354326524b2785f3450065e7d313650040I like unless empty? We know for a fact here that it won't be nil so an array check is fineÞþ2013-04-19 20:49:00.0000002013-04-19 20:49:00.000000 *Å*›º–[]²AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050248https://api.github.com/repos/sportngin/ngin/comments/3050248 1177717c354326524b2785f3450065e7d313650040Just for funnsies, I benchmarked it: ```ruby require 'benchmark' require 'active_support/core_ext/object/blank' # curse you guys for using `present?` failed_ids = (1..1000000).to_a Benchmark.bmbm do |x| x.report("Nate V1") { nil if failed_ids.empty? } x.report("Andy V1") { nil unless failed_ids.empty? } x.report("Patrick V1") { nil if failed_ids.any? } x.report("Carl V1") { nil if failed_ids.present? } x.report("Phenow V1") { nil unless !!failed_ids.empty? } x.report("Phenow V2") { nil if !(failed_ids.nil? || failed_ids.length < 1) } x.report("Carl V2") { nil if !(failed_ids.nil? || (failed_ids.respond_to?(:length) && failed_ids.length < 0)) } x.report("Ian V1") { nil if failed_ids.detect{|id| !id.nil?}.present? } x.report("Nate V.... seriously... WTF") do class NateWTF def self.is_empty(ids) if ids if ids.length == 0 return true else return false end else return true end end end nil if !NateWTF.is_empty(failed_ids) end x.report("Andy V2") { nil if !!(failed_ids.first rescue nil) } x.report("Patrick V2") { nil if Array(failed_ids).any? } end ``` ### Output ``` Rehearsal --------------------------------------------------------------- Nate V1 0.000000 0.000000 0.000000 ( 0.000007) Andy V1 0.000000 0.000000 0.000000 ( 0.000090) Patrick V1 0.000000 0.000000 0.000000 ( 0.000006) Carl V1 0.000000 0.000000 0.000000 ( 0.000007) Phenow V1 0.000000 0.000000 0.000000 ( 0.000005) Phenow V2 0.000000 0.000000 0.000000 ( 0.000006) Carl V2 0.000000 0.000000 0.000000 ( 0.000006) Ian V1 0.000000 0.000000 0.000000 ( 0.000010) Nate V.... seriously... WTF 0.000000 0.000000 0.000000 ( 0.000021) Andy V2 0.000000 0.000000 0.000000 ( 0.000006) Patrick V2 0.000000 0.000000 0.000000 ( 0.000006) ------------------------------------------------------ total: 0.000000sec user system total real Nate V1 0.000000 0.000000 0.000000 ( 0.000006) Andy V1 0.000000 0.000000 0.000000 ( 0.000005) Patrick V1 0.000000 0.000000 0.000000 ( 0.000008) Carl V1 0.000000 0.000000 0.000000 ( 0.000013) Phenow V1 0.000000 0.000000 0.000000 ( 0.000009) Phenow V2 0.000000 0.000000 0.000000 ( 0.000010) Carl V2 0.000000 0.000000 0.000000 ( 0.000012) Ian V1 0.000000 0.000000 0.000000 ( 0.000019) Nate V.... seriously... WTF 0.000000 0.000000 0.000000 ( 0.000024) Andy V2 0.000000 0.000000 0.000000 ( 0.000011) Patrick V2 0.000000 0.000000 0.000000 ( 0.000014) ``` Also @natejgreene... `==` not `=`... just saying...Êž2013-04-19 21:05:48.0000002013-04-19 21:10:21.000000‚5º–[]IAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050240https://api.github.com/repos/sportngin/ngin/comments/3050240 1177717c354326524b2785f3450065e7d313650040:trollface: if @natejgreene º†2013-04-19 21:03:20.0000002013-04-19 21:39:08.000000 HÒ O  ¦ `Øœ¬H‚^ºåm[]AAhttps://github.com/sportngin/ngin/commit/c33ffe02c8beedb7556a96eae88995812dbc614e#commitcomment-3060461https://api.github.com/repos/sportngin/ngin/comments/306046130c33ffe02c8beedb7556a96eae88995812dbc614eIsnt your payment method type different? Store::LastFourCreditCardPm?€52013-04-22 16:28:44.0000002013-04-22 16:28:44.000000‚]ºåi[]AAhttps://github.com/sportngin/ngin/commit/46ba996d618bd02ff9a309d3d7e3f2d6a364a7b7#commitcomment-3060457https://api.github.com/repos/sportngin/ngin/comments/306045724846ba996d618bd02ff9a309d3d7e3f2d6a364a7b7I'm not sure that level of exactness is warranted here, to be honest.…2013-04-22 16:28:05.0000002013-04-22 16:28:05.000000ƒº–~[]kAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050366https://api.github.com/repos/sportngin/ngin/comments/3050366 1177717c354326524b2785f3450065e7d313650040relevant ![chownd](https://f.cloud.github.com/assets/319230/404078/f37d6984-a936-11e2-9553-51fe93a19d4d.png)Þþ2013-04-19 21:21:07.0000002013-04-19 21:21:07.000000‚6º–n[]KAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050350https://api.github.com/repos/sportngin/ngin/comments/3050350 1177717c354326524b2785f3450065e7d313650040@ehlertij :+1: for the alt textÊž2013-04-19 21:18:44.0000002013-04-19 21:18:44.000000‚6º–h[]KAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050344https://api.github.com/repos/sportngin/ngin/comments/3050344 1177717c354326524b2785f3450065e7d313650040^ candidate for new wrong room.Œ?2013-04-19 21:17:36.0000002013-04-19 21:17:36.000000‚Fº–d[]kAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050340https://api.github.com/repos/sportngin/ngin/comments/3050340 1177717c354326524b2785f3450065e7d313650040That, @ehlertij, must makes its way onto jarvisÞþ2013-04-19 21:17:17.0000002013-04-19 21:17:17.000000‚@º–K[]_AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050315https://api.github.com/repos/sportngin/ngin/comments/3050315 1177717c354326524b2785f3450065e7d313650040![chownd](http://i.imgur.com/lUkpg1h.jpg)¨“2013-04-19 21:15:14.0000002013-04-19 21:15:14.000000‚lº–C[]5AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050307https://api.github.com/repos/sportngin/ngin/comments/3050307 1177717c354326524b2785f3450065e7d313650040![](http://alwaysdarkestbeforethedawn.files.wordpress.com/2013/02/dean-what-gif.gif)2š2013-04-19 21:14:11.0000002013-04-19 21:14:11.000000‚1º–+[]GAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050283https://api.github.com/repos/sportngin/ngin/comments/305028377717c354326524b2785f3450065e7d313650040github ERMAGERD @natejgreene ðž2013-04-19 21:11:22.0000002013-04-19 21:11:22.000000‚}º–*[]WAAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050282https://api.github.com/repos/sportngin/ngin/comments/3050282 1177717c354326524b2785f3450065e7d313650040And just to make this clear... I switched to unless in another commit before all this fun started...€52013-04-19 21:11:12.0000002013-04-19 21:11:12.000000‚(º–%[]5AAhttps://github.com/sportngin/ngin/commit/77717c354326524b2785f3450065e7d313650040#commitcomment-3050277https://api.github.com/repos/sportngin/ngin/comments/305027777717c354326524b2785f3450065e7d313650040@NickLaMuro You winðž2013-04-19 21:09:45.0000002013-04-19 21:09:45.000000 $Á : m äþL$„"¾ê[]„'AAhttps://github.com/sportngin/ngin/commit/c014d8e69bb1c34e60794cf49c88595e3ee75936#commitcomment-3126549https://api.github.com/repos/sportngin/ngin/comments/3126549c014d8e69bb1c34e60794cf49c88595e3ee75936@anfleene what happened? I remember you merging into master, but for some reason I can't find the changes in the current master's file. Nothing for `android_stlouispirates` is there, for example https://github.com/sportngin/ngin/blob/master/config/mobile_products.yml ™Å2013-05-01 20:08:51.0000002013-05-01 20:08:51.000000ƒ,¼Ð%[]‚;AAhttps://github.com/sportngin/ngin/commit/a7a168a749ef14a8bd4ff8092161c5a3753c5406#commitcomment-3090469https://api.github.com/repos/sportngin/ngin/comments/3090469a7a168a749ef14a8bd4ff8092161c5a3753c5406I definitely didn't mean to put this commit here. I would try to remove the commit and force-push the branch, but I've already merged it with staging. ËP2013-04-25 22:09:54.0000002013-04-25 22:09:54.000000‡`»È:[]‹#AAhttps://github.com/sportngin/ngin/commit/e617797e151ed128c30f765c86ed85e57e0d0e8c#commitcomment-3073082https://api.github.com/repos/sportngin/ngin/comments/3073082e617797e151ed128c30f765c86ed85e57e0d0e8ci know, it's sad. The flatten on line 17 is necessary, actually. When the sorted group is inserted it is an array, so the following group will be inserted in the wrong place if it isn't flattened FUCK I JUST REALIZED WHY I HAVE TO FLATTEN IT! IT ADDS A NEW ARRAY, AND WHEN IT COMPARES THAT ELEMENT IT IS AN ARRAY!!!! I should be able to remove the flatten on 15 and be good! ``` ruby # without flatten! on ln 17 [1,2,6].insert(2, [3,4]) # => [1,2,[3,4],6] [1,2,[3,4],6].insert(4, [5]) # => [1,2,[3,4],6,[5]] # with flatten! on ln 17 [1,2,6].insert(2, [3,4]).flatten! # => [1,2,3,4,6] # finds a different index value when it is flattened [1,2,3,4,6].insert(5, [5]).flatten! # => [1,2,3,4,5,6] ```UX2013-04-24 00:01:29.0000002013-04-24 00:01:29.000000‚#»Å[]+AAhttps://github.com/sportngin/ngin/commit/e617797e151ed128c30f765c86ed85e57e0d0e8c#commitcomment-3072671https://api.github.com/repos/sportngin/ngin/comments/3072671e617797e151ed128c30f765c86ed85e57e0d0e8c:disappointed: Êž2013-04-23 23:03:45.0000002013-04-23 23:03:45.000000‚Z»§#[]AAhttps://github.com/sportngin/ngin/commit/a7d0b33c497bdf25b06d7ca6f2fef2ab36d511ca#commitcomment-3068835https://api.github.com/repos/sportngin/ngin/comments/3068835a7d0b33c497bdf25b06d7ca6f2fef2ab36d511caI think that would work... Just need to make the product mgr aware.€52013-04-23 15:36:31.0000002013-04-23 15:36:31.000000ƒG»§[]‚qAAhttps://github.com/sportngin/ngin/commit/a7d0b33c497bdf25b06d7ca6f2fef2ab36d511ca#commitcomment-3068823https://api.github.com/repos/sportngin/ngin/comments/3068823a7d0b33c497bdf25b06d7ca6f2fef2ab36d511caAh good point. What about excluding schedule upload events? ``` after_save :send_mobile_push_notifications, :if => lambda { self.changed? and !self.event_import_id } ```ñ¥2013-04-23 15:35:42.0000002013-04-23 15:35:42.000000ƒ»¦m[]_AAhttps://github.com/sportngin/ngin/commit/a7d0b33c497bdf25b06d7ca6f2fef2ab36d511ca#commitcomment-3068781https://api.github.com/repos/sportngin/ngin/comments/306878152a7d0b33c497bdf25b06d7ca6f2fef2ab36d511caThis could create a massive trigger on a schedule upload correct? I think that is why it was on update.€52013-04-23 15:30:48.0000002013-04-23 15:31:02.000000‚9ºåo[]QAAhttps://github.com/sportngin/ngin/commit/c33ffe02c8beedb7556a96eae88995812dbc614e#commitcomment-3060463https://api.github.com/repos/sportngin/ngin/comments/306046330c33ffe02c8beedb7556a96eae88995812dbc614eOh never mind you inherit from it.€52013-04-22 16:29:07.0000002013-04-22 16:29:07.000000 GG  Õ…BÈåmMYEmyuce{yAAkevinmarxhttps://avatars.githubusercontent.com/u/1192602?849d09ce927e1c005c86cb3b64ad742bhttps://api.github.com/users/kevinmarxhttps://github.com/kevinmarxhttps://api.github.com/users/kevinmarx/followershttps://api.github.com/users/kevinmarx/following{/other_user}https://api.github.com/users/kevinmarx/gists{/gist_id}https://api.github.com/users/kevinmarx/starred{/owner}{/repo}https://api.github.com/users/kevinmarx/subscriptionshttps://api.github.com/users/kevinmarx/orgshttps://api.github.com/users/kevinmarx/reposhttps://api.github.com/users/kevinmarx/events{/privacy}https://api.github.com/users/kevinmarx/received_eventsUserf2014-06-05 15:35:57.2059072014-06-05 15:35:57.205907…B˲?mMYEmyuce{yAAtippeneinhttps://avatars.githubusercontent.com/u/1235263?2aa2dac39155549700e0d3596a84697ahttps://api.github.com/users/tippeneinhttps://github.com/tippeneinhttps://api.github.com/users/tippenein/followershttps://api.github.com/users/tippenein/following{/other_user}https://api.github.com/users/tippenein/gists{/gist_id}https://api.github.com/users/tippenein/starred{/owner}{/repo}https://api.github.com/users/tippenein/subscriptionshttps://api.github.com/users/tippenein/orgshttps://api.github.com/users/tippenein/reposhttps://api.github.com/users/tippenein/events{/privacy}https://api.github.com/users/tippenein/received_eventsUserf2014-06-05 15:36:01.9844462014-06-05 15:36:01.984446†&ÏÍ/mMiU} su AAJustinChristensenhttps://avatars.githubusercontent.com/u/1304220?f6326bee4e1bd683a75789ddf9042861https://api.github.com/users/JustinChristensenhttps://github.com/JustinChristensenhttps://api.github.com/users/JustinChristensen/followershttps://api.github.com/users/JustinChristensen/following{/other_user}https://api.github.com/users/JustinChristensen/gists{/gist_id}https://api.github.com/users/JustinChristensen/starred{/owner}{/repo}https://api.github.com/users/JustinChristensen/subscriptionshttps://api.github.com/users/JustinChristensen/orgshttps://api.github.com/users/JustinChristensen/reposhttps://api.github.com/users/JustinChristensen/events{/privacy}https://api.github.com/users/JustinChristensen/received_eventsUserf2014-06-05 15:35:55.6238742014-06-05 15:35:55.623874 Yv N  Õ €P脤}Y‚þ[]!AAhttps://github.com/sportngin/ngin/commit/184c3492de022bb9fdaa0c4b4973b8e52dee5aee#commitcomment-3202839https://api.github.com/repos/sportngin/ngin/comments/3202839184c3492de022bb9fdaa0c4b4973b8e52dee5aee:dancers: Êž2013-05-13 21:34:52.0000002013-05-13 21:34:52.000000‚!þ[]'AAhttps://github.com/sportngin/ngin/commit/184c3492de022bb9fdaa0c4b4973b8e52dee5aee#commitcomment-3202838https://api.github.com/repos/sportngin/ngin/comments/3202838184c3492de022bb9fdaa0c4b4973b8e52dee5aeeYour welcome.Êž2013-05-13 21:34:44.0000002013-05-13 21:34:44.000000ƒZÂÄ<[]ƒAAhttps://github.com/sportngin/ngin/commit/fd05df3fc5333c186a7738e6fadc3975bb127c92#commitcomment-3187260https://api.github.com/repos/sportngin/ngin/comments/3187260fd05df3fc5333c186a7738e6fadc3975bb127c92You missed a `Store::` on line 169 ```ruby payment_method = LastFourCreditCardPm.new(@order_information.payment_method.except(:address_1, :country, :state, :city, :address_2, :postal_code)) ```¨“2013-05-10 14:59:43.0000002013-05-10 14:59:43.000000‚^Á2[]AAhttps://github.com/sportngin/ngin/commit/7b88bbbec04102d0f1ad96e72d0a9370bf18b2ec#commitcomment-3164082https://api.github.com/repos/sportngin/ngin/comments/3164082257b88bbbec04102d0f1ad96e72d0a9370bf18b2ecTalked to Phia about this, but I fixed this already in a later commit.Êž2013-05-07 20:33:31.0000002013-05-07 20:33:31.000000‚bÁŽf[]!AAhttps://github.com/sportngin/ngin/commit/7b88bbbec04102d0f1ad96e72d0a9370bf18b2ec#commitcomment-3164006https://api.github.com/repos/sportngin/ngin/comments/3164006257b88bbbec04102d0f1ad96e72d0a9370bf18b2ec@NickLaMuro everything looks good. Can you verify jersey.number is good? Òm2013-05-07 20:24:25.0000002013-05-07 20:24:25.000000‚*¿ØG[]3AAhttps://github.com/sportngin/ngin/commit/91147bfd534738a868e4609f3a85b13b6677e3b8#commitcomment-3140679https://api.github.com/repos/sportngin/ngin/comments/3140679 1191147bfd534738a868e4609f3a85b13b6677e3b8can drop the parensUX2013-05-03 15:03:25.0000002013-05-03 15:03:25.000000‚O¿Ø?[]{AAhttps://github.com/sportngin/ngin/commit/91147bfd534738a868e4609f3a85b13b6677e3b8#commitcomment-3140671https://api.github.com/repos/sportngin/ngin/comments/314067110891147bfd534738a868e4609f3a85b13b6677e3b8the `()` don't affect anything, but they're unnecessaryUX2013-05-03 15:02:27.0000002013-05-03 15:02:27.000000‚+¾ì[[];AAhttps://github.com/sportngin/ngin/commit/c014d8e69bb1c34e60794cf49c88595e3ee75936#commitcomment-3126875https://api.github.com/repos/sportngin/ngin/comments/3126875c014d8e69bb1c34e60794cf49c88595e3ee75936Glad I could help :+1: º†2013-05-01 20:51:39.0000002013-05-01 20:51:39.000000‚B¾ìK[]iAAhttps://github.com/sportngin/ngin/commit/c014d8e69bb1c34e60794cf49c88595e3ee75936#commitcomment-3126859https://api.github.com/repos/sportngin/ngin/comments/3126859c014d8e69bb1c34e60794cf49c88595e3ee75936nevermind @anfleene, those are in the push.yml ™Å2013-05-01 20:50:19.0000002013-05-01 20:50:19.000000‚"¾ë [])AAhttps://github.com/sportngin/ngin/commit/2e3302822e6b1d68cc993df125bb7b7243cc0b0b#commitcomment-3126668https://api.github.com/repos/sportngin/ngin/comments/31266682e3302822e6b1d68cc993df125bb7b7243cc0b0bQA looks good.hY2013-05-01 20:21:43.0000002013-05-01 20:21:43.000000ƒ¾ë []eAAhttps://github.com/sportngin/ngin/commit/2e3302822e6b1d68cc993df125bb7b7243cc0b0b#commitcomment-3126665https://api.github.com/repos/sportngin/ngin/comments/3126665422e3302822e6b1d68cc993df125bb7b7243cc0b0b@stuartnelson3 what about ``from_folder_id = Inbox``` to make it clear the Inbox is the default in this casehY2013-05-01 20:20:58.0000002013-05-01 20:20:58.000000 ½ – ÿ oépN2‚͉[]!AAhttps://github.com/sportngin/ngin/commit/552cb82beb25eb2619422947ddf512a0c629358c#commitcomment-3359895https://api.github.com/repos/sportngin/ngin/comments/3359895552cb82beb25eb2619422947ddf512a0c629358cLooks goodñ¥2013-06-05 15:22:57.0000002013-06-05 15:22:57.000000„Ìã[]„AAhttps://github.com/sportngin/ngin/commit/552cb82beb25eb2619422947ddf512a0c629358c#commitcomment-3355015https://api.github.com/repos/sportngin/ngin/comments/3355015552cb82beb25eb2619422947ddf512a0c629358c@zhengjia I made these changed because my `param[:start_date]` and `param[:end_dates]` were getting overwritten when I didn't pass in a `param[:anchor]`. I hope you don't mind ```ruby 1.9.3p327 :012 > Time.at nil.to_i => 1969-12-31 18:00:00 -0600 ``` ™Å2013-06-05 00:44:36.0000002013-06-05 00:44:36.000000‚Ê¥S[]AAhttps://github.com/sportngin/ngin/commit/09fb28551295bf95c3b5b6587166becca7fdca8a#commitcomment-3314387https://api.github.com/repos/sportngin/ngin/comments/33143872209fb28551295bf95c3b5b6587166becca7fdca8a:+1: hY2013-05-29 20:09:49.0000002013-05-29 20:09:49.000000‚sǽ[]AAAhttps://github.com/sportngin/ngin/commit/1a97c2b89a064b5740d4a519123fad5613bd6e11#commitcomment-3268251https://api.github.com/repos/sportngin/ngin/comments/32682511301a97c2b89a064b5740d4a519123fad5613bd6e11I just sent the ticket off to carson. This seems like a good decision for product to make.bG2013-05-22 19:04:48.0000002013-05-22 19:04:48.000000ƒÇ¼~[][AAhttps://github.com/sportngin/ngin/commit/1a97c2b89a064b5740d4a519123fad5613bd6e11#commitcomment-3268222https://api.github.com/repos/sportngin/ngin/comments/32682221301a97c2b89a064b5740d4a519123fad5613bd6e11I pretty sure there was a reason, but I can't remember why. I'm guessing someone wanted it like that. Œ?2013-05-22 19:01:35.0000002013-05-22 19:01:35.000000ƒǼ[]‚AAhttps://github.com/sportngin/ngin/commit/1a97c2b89a064b5740d4a519123fad5613bd6e11#commitcomment-3268121https://api.github.com/repos/sportngin/ngin/comments/32681211301a97c2b89a064b5740d4a519123fad5613bd6e11Hey I just got a bug sent to me regarding this. https://thedesk.sportngin.com/admin.php?pg=request&reqid=76112 Why this was changed?bG2013-05-22 18:49:47.0000002013-05-22 18:49:47.000000ƒeÆù[]ƒ)AAhttps://github.com/sportngin/ngin/commit/400dde0982576ce692ae87dadc64b4058a7008d3#commitcomment-3259537https://api.github.com/repos/sportngin/ngin/comments/32595378400dde0982576ce692ae87dadc64b4058a7008d3Exception printing looks good. And for future reference, `say` is a convenience method around echoing content to the screen (see http://api.rubyonrails.org/classes/ActiveRecord/Migration.html#method-i-say).…2013-05-21 19:44:51.0000002013-05-21 19:44:51.000000ƒÆø+[]‚AAhttps://github.com/sportngin/ngin/commit/400dde0982576ce692ae87dadc64b4058a7008d3#commitcomment-3259435https://api.github.com/repos/sportngin/ngin/comments/32594358400dde0982576ce692ae87dadc64b4058a7008d3@pbyrne how about now? I wasnt sure the differences between ```say``` and ```puts``` so i went with the trusty ```PUTS```!Òm2013-05-21 19:30:36.0000002013-05-21 19:30:36.000000‚!Æø[]!AAhttps://github.com/sportngin/ngin/commit/b3bcf86d37c26c96268c9d1a476d07933d174051#commitcomment-3259396https://api.github.com/repos/sportngin/ngin/comments/3259396 16b3bcf86d37c26c96268c9d1a476d07933d174051sure, yes.ðž2013-05-21 19:25:36.0000002013-05-21 19:25:36.000000‚=Æ÷s[]YAAhttps://github.com/sportngin/ngin/commit/b3bcf86d37c26c96268c9d1a476d07933d174051#commitcomment-3259379https://api.github.com/repos/sportngin/ngin/comments/3259379 16b3bcf86d37c26c96268c9d1a476d07933d174051@kjbkjb was this what you had in mind?Òm2013-05-21 19:23:11.0000002013-05-21 19:23:11.000000 /‚  ~Œo‰/‚TÑõ+[] AAhttps://github.com/sportngin/ngin/commit/cf274d2ca8b3a0e9ffb837ee2ed141c15d96493b#commitcomment-3439275https://api.github.com/repos/sportngin/ngin/comments/3439275cf274d2ca8b3a0e9ffb837ee2ed141c15d96493byeah, it looks like my editor failed to save... stupid thing...bG2013-06-17 15:42:15.0000002013-06-17 15:42:15.000000ƒ`Ñõ[]ƒ#AAhttps://github.com/sportngin/ngin/commit/cf274d2ca8b3a0e9ffb837ee2ed141c15d96493b#commitcomment-3439250https://api.github.com/repos/sportngin/ngin/comments/3439250cf274d2ca8b3a0e9ffb837ee2ed141c15d96493b@carlallen This commit has broken the deployable-branch build in CI: http://ci.sportngin.com/ngin/deployable.06.12. It looks like the commit included merge conflict markers in the OrderTransaction class.…2013-06-17 15:39:30.0000002013-06-17 15:39:30.000000‚Ñ-[]AAhttps://github.com/sportngin/ngin/commit/da4ab75700d956f9b51dd7ba8a0597d1ce7b81b2#commitcomment-3426221https://api.github.com/repos/sportngin/ngin/comments/3426221da4ab75700d956f9b51dd7ba8a0597d1ce7b81b2Yep.SS2013-06-14 15:11:12.0000002013-06-14 15:11:12.000000ƒlͦ[]ƒ7AAhttps://github.com/sportngin/ngin/commit/46831a62ad785ce581b7f29c3eaec0481605694c#commitcomment-3363585https://api.github.com/repos/sportngin/ngin/comments/3363585546831a62ad785ce581b7f29c3eaec0481605694cyeah, HashWithIndifferentAccess is all about making your hashes more convenient. I personally hate that keys are sometimes strings and sometimes symbols. Rails adding in the indifference makes life so much easier.bG2013-06-05 21:49:26.0000002013-06-05 21:49:26.000000ƒ ͤh[]uAAhttps://github.com/sportngin/ngin/commit/46831a62ad785ce581b7f29c3eaec0481605694c#commitcomment-3363432https://api.github.com/repos/sportngin/ngin/comments/3363432 746831a62ad785ce581b7f29c3eaec0481605694cI have no excuse here except I was removing code and didn't think to switch. It's a trival change, so I will do it.Êž2013-06-05 21:30:53.0000002013-06-05 21:30:53.000000„lͤ^[]…7AAhttps://github.com/sportngin/ngin/commit/46831a62ad785ce581b7f29c3eaec0481605694c#commitcomment-3363422https://api.github.com/repos/sportngin/ngin/comments/3363422546831a62ad785ce581b7f29c3eaec0481605694cDidn't come mind mostly, but if you want some other reasons, calling `HashWithIndifferentAccess` in the view is kind of gross looking (when compared to a standard hash), its a `Rails` construct that isn't in Ruby's standard lib, and (from what I can tell) isn't really providing any performance or code readability improvements by adding it.Êž2013-06-05 21:30:23.0000002013-06-05 21:30:23.000000‚Í ;[]]AAhttps://github.com/sportngin/ngin/commit/46831a62ad785ce581b7f29c3eaec0481605694c#commitcomment-3362875https://api.github.com/repos/sportngin/ngin/comments/3362875 746831a62ad785ce581b7f29c3eaec0481605694c`keys.include?` should be `has_key?` http://www.ruby-doc.org/core-1.9.3/Hash.html#method-i-has_key-3FbG2013-06-05 20:31:50.0000002013-06-05 20:32:16.000000‚vÍ *[]KAAhttps://github.com/sportngin/ngin/commit/46831a62ad785ce581b7f29c3eaec0481605694c#commitcomment-3362858https://api.github.com/repos/sportngin/ngin/comments/3362858546831a62ad785ce581b7f29c3eaec0481605694cor ```ruby allowed_stat_types = HashWithIndifferentAccess.new { :Pitcher => .... } ```bG2013-06-05 20:29:54.0000002013-06-05 20:29:54.000000‚xÍ []OAAhttps://github.com/sportngin/ngin/commit/46831a62ad785ce581b7f29c3eaec0481605694c#commitcomment-3362837https://api.github.com/repos/sportngin/ngin/comments/3362837546831a62ad785ce581b7f29c3eaec0481605694cwhy not just do? ```ruby allowed_stat_types = allowed_stat_types.with_indifferent_access ```bG2013-06-05 20:28:35.0000002013-06-05 20:28:35.000000 ¶b 8 DžF¤¶ƒhÞ‡[]ƒ3AAhttps://github.com/sportngin/ngin/commit/0d832aa76f66ff40c3776308271bdd5554c7b44b#commitcomment-3638173https://api.github.com/repos/sportngin/ngin/comments/36381730d832aa76f66ff40c3776308271bdd5554c7b44bSo if our CI server is letting this go through without a problem, it might be something that we want to look into in the future. This is outside of the scope of this PR, but leaving this comment here as a note.Êž2013-07-15 20:26:24.0000002013-07-15 20:26:24.000000…ÜÆJ[]†AAhttps://github.com/sportngin/ngin/commit/3e00c05a8b1ed3f6979cb6a8ec9a6089d64a491f#commitcomment-3613514https://api.github.com/repos/sportngin/ngin/comments/36135143e00c05a8b1ed3f6979cb6a8ec9a6089d64a491fI totally agree. I will work on it later and see what I come up with. I might even make a "remote_shared" console script that slightly redoes the `rails console` so that you are able to just do `reload!`. Also, the `loudly` relic that I lifted from Patrick's `cibuild` script is also really unnecessary, so it is a good excuse to remove that. Sounds good guys, thanks for the advice.Êž2013-07-11 14:40:42.0000002013-07-14 20:43:05.000000‚RÜÄm[]AAhttps://github.com/sportngin/ngin/commit/3e00c05a8b1ed3f6979cb6a8ec9a6089d64a491f#commitcomment-3613293https://api.github.com/repos/sportngin/ngin/comments/36132933e00c05a8b1ed3f6979cb6a8ec9a6089d64a491fI'm with Ian on this one. I think it belongs in automation. º†2013-07-11 14:22:44.0000002013-07-11 14:22:44.000000ƒ ÜÄN[]‚#AAhttps://github.com/sportngin/ngin/commit/3e00c05a8b1ed3f6979cb6a8ec9a6089d64a491f#commitcomment-3613262https://api.github.com/repos/sportngin/ngin/comments/36132623e00c05a8b1ed3f6979cb6a8ec9a6089d64a491fI like the idea, but we should put this script in https://github.com/sportngin/automation so we don't have to duplicate it across projects.¨“2013-07-11 14:19:34.0000002013-07-11 14:19:34.000000‡nܤo[]‹?AAhttps://github.com/sportngin/ngin/commit/3e00c05a8b1ed3f6979cb6a8ec9a6089d64a491f#commitcomment-3609199https://api.github.com/repos/sportngin/ngin/comments/36091993e00c05a8b1ed3f6979cb6a8ec9a6089d64a491f@ehlertij @anfleene Curious about your thoughts on this approach. I don't really think it is "ideal" but it solves the problem of: A. Having to remember that damn ssh command every time... B. Allows for an easy reconnect with `pow` by just doing a `powder restart`. I wish it would work the same in the console, but for now, you can do this: ```ruby irb> `#{Rails.root}/script/connect_to_remote_share` && reload! ``` I was hoping to get something were running `reload!` would reconnect the DB, but I punted on that after digging through the rails source for a few hours. There might be a better solution we could do, but let me know what you think about this one for now so we can get this out of the PR queue.Êž2013-07-11 02:00:55.0000002013-07-11 02:00:55.000000‚$ÔŸ []-AAhttps://github.com/sportngin/ngin/commit/9222aa2869deb7416e87b59f439d7951f39e5dc5#commitcomment-3477408https://api.github.com/repos/sportngin/ngin/comments/34774089222aa2869deb7416e87b59f439d7951f39e5dc5Seems reasonableÞþ2013-06-21 14:45:34.0000002013-06-21 14:45:34.000000ƒÓìV[]‚AAhttps://github.com/sportngin/ngin/commit/ce20e71ce1a475ac4bae27e87fde693b3b120930#commitcomment-3470934https://api.github.com/repos/sportngin/ngin/comments/34709349ce20e71ce1a475ac4bae27e87fde693b3b120930I know you didn't write it but `!@team_stats[stat_module.key].blank?` == :poop: `@team_stats[stat_module.key].present?` :+1: bG2013-06-20 19:36:45.0000002013-06-20 19:36:45.000000 &, T vÀj,è&ƒ<äúb[]‚SAAhttps://github.com/sportngin/ngin/commit/6c7b34f5676f517bcd5447c1b5ebf44a85e76ce9#commitcomment-3751266https://api.github.com/repos/sportngin/ngin/comments/3751266 2156c7b34f5676f517bcd5447c1b5ebf44a85e76ce9if `originator` is an instance ActiveRecord object then `originator.class.table_name` would return the name of the table where the class is stored in the database.bG2013-07-30 19:57:37.0000002013-07-30 19:57:37.000000‚>ßë`[]]AAhttps://github.com/sportngin/ngin/commit/41615a2b6d2a98b65bdac0a63c81030e10f8eb96#commitcomment-3667424https://api.github.com/repos/sportngin/ngin/comments/3667424841615a2b6d2a98b65bdac0a63c81030e10f8eb96I have no idea what I was doing.. drugs? ™Å2013-07-18 19:03:42.0000002013-07-18 19:03:42.000000‚8ßë?[]QAAhttps://github.com/sportngin/ngin/commit/41615a2b6d2a98b65bdac0a63c81030e10f8eb96#commitcomment-3667391https://api.github.com/repos/sportngin/ngin/comments/3667391841615a2b6d2a98b65bdac0a63c81030e10f8eb96Yeah, this was all sorts of wrong.Êž2013-07-18 19:02:06.0000002013-07-18 19:02:06.000000‚PÞÉ8[]}AAhttps://github.com/sportngin/ngin/commit/9d1028f78deee2db0eb1c86604279811211d88f3#commitcomment-3646648https://api.github.com/repos/sportngin/ngin/comments/3646648$1189d1028f78deee2db0eb1c86604279811211d88f3I would like to get it done. I'm going to try your idea.@¥é2013-07-16 18:02:46.0000002013-07-16 18:02:46.000000…0ÞÇ[]†;AAhttps://github.com/sportngin/ngin/commit/9d1028f78deee2db0eb1c86604279811211d88f3#commitcomment-3646337https://api.github.com/repos/sportngin/ngin/comments/3646337$1189d1028f78deee2db0eb1c86604279811211d88f3If you want to fix the duplicate id's, then it should be fixed in the template, and it's your call if you want to tackle it (you can pass ```:id => value``` arguments to the methods that render the input tags ex: ```text_field```). The duplicate id's aren't a big issue in this case because the address blocks are never submitted together. I think loading the address blocks dynamically would be overkill.hY2013-07-16 17:36:04.0000002013-07-16 17:36:04.000000…XÞÂm[]‡ AAhttps://github.com/sportngin/ngin/commit/9d1028f78deee2db0eb1c86604279811211d88f3#commitcomment-3645805https://api.github.com/repos/sportngin/ngin/comments/3645805$1189d1028f78deee2db0eb1c86604279811211d88f3I can try that, but was concerned that having duplicate ids could also lead to other issues and I think would require changing the shared address form. I wanted to avoid that because I'm not sure what else is using that form and didn't want to break something else. I thought another option might be to dynamically load the address block when they click on the radio buttons, but I'm not sure if that can be done. Let me know what you think.@¥é2013-07-16 16:41:04.0000002013-07-16 16:41:04.000000ƒRÞÁ []‚AAhttps://github.com/sportngin/ngin/commit/9d1028f78deee2db0eb1c86604279811211d88f3#commitcomment-3645580https://api.github.com/repos/sportngin/ngin/comments/3645580$1189d1028f78deee2db0eb1c86604279811211d88f3I'd prefer to not add/remove the address nodes from the document like this. Seems like an easy to inadvertently introduce a bug. Why not select the element to auto-fill base on class?hY2013-07-16 16:20:32.0000002013-07-16 16:20:32.000000ƒNÞ‡3[]‚AAhttps://github.com/sportngin/ngin/commit/0d832aa76f66ff40c3776308271bdd5554c7b44b#commitcomment-3638195https://api.github.com/repos/sportngin/ngin/comments/36381950d832aa76f66ff40c3776308271bdd5554c7b44bYeah there are a handful of remote tests that do not run in CI or unless you specify REMOTE_TEST=1. Most of the salesforce, zuora and credit card processing run under this env variable€52013-07-15 20:28:58.0000002013-07-15 20:28:58.000000  7 V _%Aè‚SïÆ@[]AAhttps://github.com/sportngin/ngin/commit/b92bf942927dda92cd2b834c123eab1a1bd1f6fe#commitcomment-3924800https://api.github.com/repos/sportngin/ngin/comments/39248002812b92bf942927dda92cd2b834c123eab1a1bd1f6feyeah, go ahead and populate that. sorry for the runaround.ðž2013-08-22 19:48:02.0000002013-08-22 19:48:02.000000„SïÄ@[]…AAhttps://github.com/sportngin/ngin/commit/b92bf942927dda92cd2b834c123eab1a1bd1f6fe#commitcomment-3924544https://api.github.com/repos/sportngin/ngin/comments/39245442812b92bf942927dda92cd2b834c123eab1a1bd1f6fe@kjbkjb I can't remember if we talked about this... when we look up the survey using tournament_id, params[:id] isn't set causing issues with things that depend on it. I think at this point/action params[:id] is mean to be the same as @survey.id which we have provided to us... better solution? This seems to work.;ß2013-08-22 19:23:00.0000002013-08-22 19:23:00.000000ƒ^ïÄ&[]ƒAAhttps://github.com/sportngin/ngin/commit/b92bf942927dda92cd2b834c123eab1a1bd1f6fe#commitcomment-3924518https://api.github.com/repos/sportngin/ngin/comments/392451871b92bf942927dda92cd2b834c123eab1a1bd1f6fethis needed to stay the same as it was in the markup, but not be in the markup. I updated it to check for 0 rather than nil because nil can be converted to 0 and we can kill two birds with one stone;ß2013-08-22 19:20:20.0000002013-08-22 19:20:20.000000‚4îã[]MAAhttps://github.com/sportngin/ngin/commit/349b590ff478197d04aee5476dca3f93f61d50a6#commitcomment-3912092https://api.github.com/repos/sportngin/ngin/comments/3912092349b590ff478197d04aee5476dca3f93f61d50a6Get a better editor :trollface: Êž2013-08-21 16:00:59.0000002013-08-21 16:00:59.000000ƒ-î‘[]‚=AAhttps://github.com/sportngin/ngin/commit/b2390a8f7f839fe9b3b332eb85fa64c161eb720a#commitcomment-3901584https://api.github.com/repos/sportngin/ngin/comments/3901584b2390a8f7f839fe9b3b332eb85fa64c161eb720aSo code review is good. Lets call QA good as well as I've identified the emailing problem to be related to something else. Go ahead and mark deployable.©i2013-08-20 16:31:44.0000002013-08-20 16:31:44.000000‚>îy[]aAAhttps://github.com/sportngin/ngin/commit/b2390a8f7f839fe9b3b332eb85fa64c161eb720a#commitcomment-3901561https://api.github.com/repos/sportngin/ngin/comments/3901561b2390a8f7f839fe9b3b332eb85fa64c161eb720aAh yes, I missed that! Change looks good. ©i2013-08-20 16:30:14.0000002013-08-20 16:30:14.000000ƒ[î3[]ƒAAhttps://github.com/sportngin/ngin/commit/b2390a8f7f839fe9b3b332eb85fa64c161eb720a#commitcomment-3901491https://api.github.com/repos/sportngin/ngin/comments/3901491b2390a8f7f839fe9b3b332eb85fa64c161eb720aDoesn't this line add the approval user to the list of emails to be sent to: + email_addrs << order_transaction.survey.approval_user.primary_email if order_transaction.survey.approval_user <ÚU2013-08-20 16:23:02.0000002013-08-20 16:23:02.000000…Cî[]†iAAhttps://github.com/sportngin/ngin/commit/b2390a8f7f839fe9b3b332eb85fa64c161eb720a#commitcomment-3901463https://api.github.com/repos/sportngin/ngin/comments/3901463b2390a8f7f839fe9b3b332eb85fa64c161eb720aNIck ... good change here getting it to use send_email instead which will cause delayed job to send the emails. Looks like you removed the email sending entirely though for the survey's approval user... will want to get that back. Also, we are QAing something else right now and ran into the same accept encoding error when sending email. So this issue is not specific to Chargebacks and not something you need to worry about. ©i2013-08-20 16:19:11.0000002013-08-20 16:19:11.000000 77Ûq E %…†’]mMS?gso]_usAAzserrehttps://avatars.githubusercontent.com/u/2197853?da7ed409a9b457acc872823471d7033ehttps://api.github.com/users/zserrehttps://github.com/zserrehttps://api.github.com/users/zserre/followershttps://api.github.com/users/zserre/following{/other_user}https://api.github.com/users/zserre/gists{/gist_id}https://api.github.com/users/zserre/starred{/owner}{/repo}https://api.github.com/users/zserre/subscriptionshttps://api.github.com/users/zserre/orgshttps://api.github.com/users/zserre/reposhttps://api.github.com/users/zserre/events{/privacy}https://api.github.com/users/zserre/received_eventsUserf2014-06-05 15:36:01.8544062014-06-05 15:36:01.854406…ö3mMQ=eqm[]sqAAjdalthttps://avatars.githubusercontent.com/u/2358067?73d631d2ba6af058cdffae8598a3d43ehttps://api.github.com/users/jdalthttps://github.com/jdalthttps://api.github.com/users/jdalt/followershttps://api.github.com/users/jdalt/following{/other_user}https://api.github.com/users/jdalt/gists{/gist_id}https://api.github.com/users/jdalt/starred{/owner}{/repo}https://api.github.com/users/jdalt/subscriptionshttps://api.github.com/users/jdalt/orgshttps://api.github.com/users/jdalt/reposhttps://api.github.com/users/jdalt/events{/privacy}https://api.github.com/users/jdalt/received_eventsUserf2014-06-05 15:36:01.7381862014-06-05 15:36:01.738186…N¹l!mM[Go { weg}{AAmpillsburyhttps://avatars.githubusercontent.com/u/2366700?b3f7e38fc55f7eb05b7bda4263f3c2d0https://api.github.com/users/mpillsburyhttps://github.com/mpillsburyhttps://api.github.com/users/mpillsbury/followershttps://api.github.com/users/mpillsbury/following{/other_user}https://api.github.com/users/mpillsbury/gists{/gist_id}https://api.github.com/users/mpillsbury/starred{/owner}{/repo}https://api.github.com/users/mpillsbury/subscriptionshttps://api.github.com/users/mpillsbury/orgshttps://api.github.com/users/mpillsbury/reposhttps://api.github.com/users/mpillsbury/events{/privacy}https://api.github.com/users/mpillsbury/received_eventsUserf2014-06-05 15:36:01.1580272014-06-05 15:36:01.158027…Z•âs#mM]Iq } ygi}AAelliothurshhttps://avatars.githubusercontent.com/u/2453875?9216098977456848b3c792465f604452https://api.github.com/users/elliothurshhttps://github.com/elliothurshhttps://api.github.com/users/elliothursh/followershttps://api.github.com/users/elliothursh/following{/other_user}https://api.github.com/users/elliothursh/gists{/gist_id}https://api.github.com/users/elliothursh/starred{/owner}{/repo}https://api.github.com/users/elliothursh/subscriptionshttps://api.github.com/users/elliothursh/orgshttps://api.github.com/users/elliothursh/reposhttps://api.github.com/users/elliothursh/events{/privacy}https://api.github.com/users/elliothursh/received_eventsUserf2014-06-05 15:36:02.4368632014-06-05 15:36:02.436863…U´Ÿ:'maMu}kmAAmpillsburytsthttps://avatars.githubusercontent.com/u/2953146?https://api.github.com/users/mpillsburytsthttps://github.com/mpillsburytsthttps://api.github.com/users/mpillsburytst/followershttps://api.github.com/users/mpillsburytst/following{/other_user}https://api.github.com/users/mpillsburytst/gists{/gist_id}https://api.github.com/users/mpillsburytst/starred{/owner}{/repo}https://api.github.com/users/mpillsburytst/subscriptionshttps://api.github.com/users/mpillsburytst/orgshttps://api.github.com/users/mpillsburytst/reposhttps://api.github.com/users/mpillsburytst/events{/privacy}https://api.github.com/users/mpillsburytst/received_eventsUserf2014-06-05 15:35:57.7446982014-06-05 15:35:57.744698  q  7¼c( ‰ùüH[]aAAhttps://github.com/sportngin/ngin/commit/b4cf119f7f517e19a57a1e4b957cef303f9dea23#commitcomment-4095560https://api.github.com/repos/sportngin/ngin/comments/4095560 13b4cf119f7f517e19a57a1e4b957cef303f9dea23@zhengjia I think we want to just use `game.start_date_time` here, so we can take advantage of https://github.com/sportngin/ngin/blob/master/app/models/game.rb#L517. Though, it does look like you are taking measures here to correctly convert the `Time` to the site's `TimeZone`. The method you're using, `tst_site_timezone`, looks like it defaults to `US/Central` if nothing is provided, which is what we're seeing. It looks like `site` shouldn't be anything when you pass it in, in fact, it looks like it's undefined, which should be throwing an exception at https://github.com/sportngin/ngin/blob/snl_start_date_time_from_game_not_event/app/controllers/api2/snl/games_controller.rb#L19. *BOOM*, my head explodes, I don't exactly know what's going on here and I'm probably missing something but something looks like it might be out of place. Do you have any insight? ™Å2013-09-15 09:14:50.0000002013-09-15 09:14:50.000000‚5ù‡7[]OAAhttps://github.com/sportngin/ngin/commit/0181cddcea9a578811b8ba935e9dcc6e53f887f1#commitcomment-4080567https://api.github.com/repos/sportngin/ngin/comments/40805670181cddcea9a578811b8ba935e9dcc6e53f887f1Pull Requests Welcome @carlallen º†2013-09-12 19:52:04.0000002013-09-12 19:52:04.000000‚Sù‡,[] AAhttps://github.com/sportngin/ngin/commit/0181cddcea9a578811b8ba935e9dcc6e53f887f1#commitcomment-4080556https://api.github.com/repos/sportngin/ngin/comments/40805560181cddcea9a578811b8ba935e9dcc6e53f887f1https://github.com/sportngin/postal_service/blob/master/.powrcbG2013-09-12 19:50:29.0000002013-09-12 19:50:29.000000‚uù‡"[]MAAhttps://github.com/sportngin/ngin/commit/0181cddcea9a578811b8ba935e9dcc6e53f887f1#commitcomment-4080546https://api.github.com/repos/sportngin/ngin/comments/40805460181cddcea9a578811b8ba935e9dcc6e53f887f1There's another trick, just add `cd .` to the `.powrc` and bam.. it just picks up all the thingsbG2013-09-12 19:49:18.0000002013-09-12 19:49:18.000000…Tù‡[]‡ AAhttps://github.com/sportngin/ngin/commit/0181cddcea9a578811b8ba935e9dcc6e53f887f1#commitcomment-4080512https://api.github.com/repos/sportngin/ngin/comments/40805120181cddcea9a578811b8ba935e9dcc6e53f887f1This would be faster and more robust (supporting the apps that still use .rvmrc), and only calling rvm use once. ```sh if [ -f "$rvm_path/scripts/rvm" ]; then source "$rvm_path/scripts/rvm" if [ -f ".rvmrc" ]; then source ".rvmrc" elif [ -f ".ruby-version" ] && [ -f ".ruby-gemset" ]; then rvm use `cat .ruby-version`@`cat .ruby-gemset` elif [ -f ".ruby-version" ]; then rvm use `cat .ruby-version` fi fi ``` >ð2013-09-12 19:44:55.0000002013-09-12 19:44:55.000000„Zô©[]…AAhttps://github.com/sportngin/ngin/commit/9c0635d5fae6266d023909f5cb0b510c9648b3b5#commitcomment-4002970https://api.github.com/repos/sportngin/ngin/comments/400297039c0635d5fae6266d023909f5cb0b510c9648b3b5Arg... why do you make comments in commits ![rage](https://dujrsrsgsd3nh.cloudfront.net/img/emoticons/rageguy.png) Anyway, if that is the case, should we just switch it to only block for sandbox sites? Both `:deleted` and `:disabled` will return some kind of error page, so doing a positive check for those seems silly.Êž2013-09-03 15:31:04.0000002013-09-03 15:31:04.000000ƒ ô¨ []qAAhttps://github.com/sportngin/ngin/commit/9c0635d5fae6266d023909f5cb0b510c9648b3b5#commitcomment-4002848https://api.github.com/repos/sportngin/ngin/comments/400284839c0635d5fae6266d023909f5cb0b510c9648b3b5This shouldn't have a `!` on the front. I definitely commented with the wrong logic earlier out of force of habit.¨“2013-09-03 15:20:28.0000002013-09-03 15:20:28.000000 ³ „ Í ˜Ô˜!³‚hÿÏ1[]-AAhttps://github.com/sportngin/ngin/commit/af5f0b1334170dcce1ad037a1c616f1176f02db8#commitcomment-4188081https://api.github.com/repos/sportngin/ngin/comments/418808126af5f0b1334170dcce1ad037a1c616f1176f02db8I am also matching tag_match with this as well, that is why I am not doing this.Êž2013-09-26 14:31:18.0000002013-09-26 14:31:18.000000‚qÿ“%[]?AAhttps://github.com/sportngin/ngin/commit/af5f0b1334170dcce1ad037a1c616f1176f02db8#commitcomment-4180389https://api.github.com/repos/sportngin/ngin/comments/418038926af5f0b1334170dcce1ad037a1c616f1176f02db8#2584 ```javascript var match = value.match(/^tag=(.+)?&/) if (match) match[0] ``` ™Å2013-09-25 19:38:49.0000002013-09-25 19:38:49.000000ˆ6ýÝV[]ŒIAAhttps://github.com/sportngin/ngin/commit/0505407ae2e312ad2c90ad8d020cc45a7526858c#commitcomment-4157142https://api.github.com/repos/sportngin/ngin/comments/4157142"340505407ae2e312ad2c90ad8d020cc45a7526858cI don't think this is going to work correctly. Here is the original code for find resource: ```ruby def find_resource set_resource_type @resource ||= @resource_type.camelize.constantize.find_by_id(params[:id]) if ["show", "update"].include? params[:action] and @resource.nil? render :json => "The #{@resource_type} could not be found.", :status => 404 return false elsif params[:action == 'destroy'] and @resource.nil? render :json => '' return false end end ``` I think `super` in this case is always going to return `false` (if one of the conditions match in the `if` statement) or `nil` (if none of the conditions match). So I think we would want to do something like this: ```ruby super return false if @resource.nil? ``` Or am I mistaken?Êž2013-09-23 16:43:58.0000002013-09-23 16:43:58.000000ƒ>ûšQ[]‚YAAhttps://github.com/sportngin/ngin/commit/b1a31c2a9a4ed14664cc9478b11c837a643ea81c#commitcomment-4115793https://api.github.com/repos/sportngin/ngin/comments/411579315b1a31c2a9a4ed14664cc9478b11c837a643ea81cThe thirdnorth support is on staging now. The sites are scoped by sport_id so it's not as bad as I thought. We have about 1,100 hockey sites @mpillsbury @mrschroederñ¥2013-09-17 21:02:15.0000002013-09-17 21:02:15.000000„/û™ []„;AAhttps://github.com/sportngin/ngin/commit/b1a31c2a9a4ed14664cc9478b11c837a643ea81c#commitcomment-4115593https://api.github.com/repos/sportngin/ngin/comments/411559315b1a31c2a9a4ed14664cc9478b11c837a643ea81cYeah, I can add support for third north user. I just wasn't sure whether we want to return all sites for third north users or not. It does help us to debug. But finding a site among 3,000 sites could be an issue. I will add it and worry about it later. @mpillsbury @mrschroeder ñ¥2013-09-17 20:44:33.0000002013-09-17 20:44:33.000000ƒ1û—o[]‚?AAhttps://github.com/sportngin/ngin/commit/b1a31c2a9a4ed14664cc9478b11c837a643ea81c#commitcomment-4115439https://api.github.com/repos/sportngin/ngin/comments/411543915b1a31c2a9a4ed14664cc9478b11c837a643ea81cShould we maybe check Third North access before running this big query? Right now it seems that Third North users are getting no results... @mrschroeder$ì2013-09-17 20:29:23.0000002013-09-17 20:29:23.000000„vú‡?[]…IAAhttps://github.com/sportngin/ngin/commit/b4cf119f7f517e19a57a1e4b957cef303f9dea23#commitcomment-4096959https://api.github.com/repos/sportngin/ngin/comments/4096959 13b4cf119f7f517e19a57a1e4b957cef303f9dea23Ah, with the brilliance of @kevinmarx, we were able to figure this out. It tries to set the site here https://github.com/sportngin/ngin/blob/snl_start_date_time_from_game_not_event/app/controllers/api2/api_resource_controller.rb#L228 but `@resource` is `nil`, so we get `nil` for the `@site`. `@resource` is nil because we have no `params[:id]` ™Å2013-09-15 19:24:34.0000002013-09-15 19:24:34.000000 –o „ / ÏdÒ–‚6‚Ÿ±"[]IAAhttps://github.com/sportngin/ngin/commit/3be4fe528a395efe61cef88be813d53a9268d654#commitcomment-4708514https://api.github.com/repos/sportngin/ngin/comments/47085141873be4fe528a395efe61cef88be813d53a9268d654this should be in page_node.rb€52013-11-26 20:42:09.0000002013-11-26 20:42:09.000000‚>‚žÇc[][AAhttps://github.com/sportngin/ngin/commit/7dfe63f0544da200e432102b27a50e2770418760#commitcomment-4695011https://api.github.com/repos/sportngin/ngin/comments/4695011127dfe63f0544da200e432102b27a50e2770418760@marklarr Can you review again. Thanks.Òm2013-11-25 18:05:36.0000002013-11-25 18:05:36.000000‚H‚•¥1[]iAAhttps://github.com/sportngin/ngin/commit/5cb3705069e8f8bbb99030cb8caad77f112afec0#commitcomment-4543153https://api.github.com/repos/sportngin/ngin/comments/4543153187125cb3705069e8f8bbb99030cb8caad77f112afec0Need to add this line back so the test can runñ¥2013-11-08 00:23:57.0000002013-11-08 00:23:57.000000…/‚“Îw[]†AAAhttps://github.com/sportngin/ngin/commit/e8e8964c4b8d7698521b3ca4de8d60c719f09c8e#commitcomment-4515703https://api.github.com/repos/sportngin/ngin/comments/4515703e8e8964c4b8d7698521b3ca4de8d60c719f09c8eI'd like to see the whitespace cleaned up on this before it is deployed. Please use 2 space whitespace. No tabs. Also, this pull request is showing a lot of other files modified with it. Please make sure this branch is up to date with master by running bundle exec sync-branch which will merge the latest from master into this branch. When ready please re-mark as deployable so we know to deploy this. Thanks.©i2013-11-05 17:30:20.0000002013-11-05 17:30:20.000000‚p‚Ž¦/[];AAhttps://github.com/sportngin/ngin/commit/8d3d83ed00204fc8b930386c8f57ce6a8349a1bc#commitcomment-4428591https://api.github.com/repos/sportngin/ngin/comments/44285911068d3d83ed00204fc8b930386c8f57ce6a8349a1bcI think it's worth dumping any nettica ns record not just the dns1.nettica.com records.º†2013-10-25 14:36:56.0000002013-10-25 14:36:56.000000‚:‚Ž¤T[]SAAhttps://github.com/sportngin/ngin/commit/30fcbc98ea489f7c1adf13289b6c2fce9f13bb11#commitcomment-4428372https://api.github.com/repos/sportngin/ngin/comments/44283726630fcbc98ea489f7c1adf13289b6c2fce9f13bb11Ah right, I didn't pick up on that.¨“2013-10-25 14:17:00.0000002013-10-25 14:17:00.000000‚Z‚Ž¤H[]AAhttps://github.com/sportngin/ngin/commit/30fcbc98ea489f7c1adf13289b6c2fce9f13bb11#commitcomment-4428360https://api.github.com/repos/sportngin/ngin/comments/44283606630fcbc98ea489f7c1adf13289b6c2fce9f13bb11not with the same hostname neither nettica or dme would allow thatº†2013-10-25 14:15:28.0000002013-10-25 14:15:28.000000‚O‚ñ<[]}AAhttps://github.com/sportngin/ngin/commit/30fcbc98ea489f7c1adf13289b6c2fce9f13bb11#commitcomment-4421820https://api.github.com/repos/sportngin/ngin/comments/44218206630fcbc98ea489f7c1adf13289b6c2fce9f13bb11Is there ever a chance that there will be more than one?¨“2013-10-24 21:29:40.0000002013-10-24 21:29:40.000000ƒe‚ä4[]ƒ-AAhttps://github.com/sportngin/ngin/commit/90660b1e7f332afcc1e6f6df81e547dec16f4e98#commitcomment-4420148https://api.github.com/repos/sportngin/ngin/comments/442014890660b1e7f332afcc1e6f6df81e547dec16f4e98Kept this scoped to just the new version of the picker, but this reduces the response time for large query on highschoolcubenews from 120 secs to 20 secs. Still could use some improvement, but it is a start.Êž2013-10-24 18:52:40.0000002013-10-24 18:52:40.000000ƒ ‚„Çn[]yAAhttps://github.com/sportngin/ngin/commit/f79c59e7c9a53a24bd62d8c66a3d7e57c01a9494#commitcomment-4269038https://api.github.com/repos/sportngin/ngin/comments/4269038f79c59e7c9a53a24bd62d8c66a3d7e57c01a9494![I fear change](http://3.bp.blogspot.com/-SvU7-t5Fa0w/UGFVdy3tYYI/AAAAAAAACRY/1JoAfPyBQeg/s1600/waynes_world+(2).jpg)º†2013-10-07 19:44:46.0000002013-10-07 19:44:46.000000 M³ @ ò †Ú ;Mƒh‚ª¥l[]ƒ3AAhttps://github.com/sportngin/ngin/commit/5bfb43fdfccef42544219aff5fa2bc85fdbfeb5c#commitcomment-4887276https://api.github.com/repos/sportngin/ngin/comments/48872765bfb43fdfccef42544219aff5fa2bc85fdbfeb5cHa. Yeah we need a way to test this on staging. Not sure why it matters that it pops up anyway. It at least shows the code is working :) Also the hide functionality should be working to hide it for 24hrs. €52013-12-17 21:23:09.0000002013-12-17 21:23:09.000000ƒQ‚ª¥C[]ƒAAhttps://github.com/sportngin/ngin/commit/5bfb43fdfccef42544219aff5fa2bc85fdbfeb5c#commitcomment-4887235https://api.github.com/repos/sportngin/ngin/comments/48872355bfb43fdfccef42544219aff5fa2bc85fdbfeb5c@natejgreene where the hell were you [when we talked about this 30 min ago...](https://github.com/sportngin/ngin/pull/3380#discussion_r8416163). @ehlertij, @natejgreene figure it out...Êž2013-12-17 21:19:45.0000002013-12-17 21:19:56.000000ƒ‚ª¤p[]sAAhttps://github.com/sportngin/ngin/commit/5bfb43fdfccef42544219aff5fa2bc85fdbfeb5c#commitcomment-4887152https://api.github.com/repos/sportngin/ngin/comments/48871525bfb43fdfccef42544219aff5fa2bc85fdbfeb5cI think it should stay Rails.env.production? so these pop up on staging for testing. Or add staging as a condition.€52013-12-17 21:11:27.0000002013-12-17 21:11:27.000000‚4‚ª¤/[]MAAhttps://github.com/sportngin/ngin/commit/5bfb43fdfccef42544219aff5fa2bc85fdbfeb5c#commitcomment-4887087https://api.github.com/repos/sportngin/ngin/comments/48870875bfb43fdfccef42544219aff5fa2bc85fdbfeb5cit's about time you learned that¨“2013-12-17 21:06:16.0000002013-12-17 21:06:16.000000ƒ&‚ª []‚)AAhttps://github.com/sportngin/ngin/commit/5f6901718776824040ca7ef0bacee04e0370fa73#commitcomment-4884128https://api.github.com/repos/sportngin/ngin/comments/4884128285f6901718776824040ca7ef0bacee04e0370fa73`@season` is a deprecated way of calling attributes/relationships, you should just call `season` or `self.season` This breaks in rails 3.1+bG2013-12-17 17:02:02.0000002013-12-17 17:02:02.000000‚f‚©ÐO[]+AAhttps://github.com/sportngin/ngin/commit/8f13f209f08140d6e18476aae396a80ae97d44ff#commitcomment-4876367https://api.github.com/repos/sportngin/ngin/comments/487636788f13f209f08140d6e18476aae396a80ae97d44ffCan you make this rubyish instead of javascripty? `supports_custom_paint_jobs?`¨“2013-12-16 23:01:02.0000002013-12-16 23:01:02.000000‚H‚¦ù []uAAhttps://github.com/sportngin/ngin/commit/41c2af27e090559081fb0c9693dd8a7d1af624f6#commitcomment-4832396https://api.github.com/repos/sportngin/ngin/comments/483239641c2af27e090559081fb0c9693dd8a7d1af624f6hey that tag should at least be a table :trollface: º†2013-12-11 14:05:42.0000002013-12-11 14:05:42.000000‚m‚¦Ú[]=AAhttps://github.com/sportngin/ngin/commit/41c2af27e090559081fb0c9693dd8a7d1af624f6#commitcomment-4828435https://api.github.com/repos/sportngin/ngin/comments/482843541c2af27e090559081fb0c9693dd8a7d1af624f6```ruby true if "...kind of sort of had it" =~ /looks like <\/html>/ ``` @anfleene Êž2013-12-11 03:26:36.0000002013-12-11 03:26:36.000000‚G‚¦ÙC[]sAAhttps://github.com/sportngin/ngin/commit/41c2af27e090559081fb0c9693dd8a7d1af624f6#commitcomment-4828355https://api.github.com/repos/sportngin/ngin/comments/482835541c2af27e090559081fb0c9693dd8a7d1af624f6@NickLaMuro Heh thanks! I kind of sort of had it...º†2013-12-11 03:06:47.0000002013-12-11 03:06:47.000000 B É  E »±º•B‚M‚ªþz[]AAhttps://github.com/sportngin/ngin/commit/63ef727839c24da54b110e8209661b505478ab05#commitcomment-4898682https://api.github.com/repos/sportngin/ngin/comments/489868263ef727839c24da54b110e8209661b505478ab05![grumpy](http://memeifier.com/_/just_stop/grumpycat.jpg)Êž2013-12-18 21:29:46.0000002013-12-18 21:29:46.000000‚‚ªþf[]#AAhttps://github.com/sportngin/ngin/commit/63ef727839c24da54b110e8209661b505478ab05#commitcomment-4898662https://api.github.com/repos/sportngin/ngin/comments/489866263ef727839c24da54b110e8209661b505478ab05Such amaze!¨“2013-12-18 21:27:28.0000002013-12-18 21:27:28.000000ƒ?‚ªþ4[]‚[AAhttps://github.com/sportngin/ngin/commit/0263752657c602d24708d59234c64378a751014a#commitcomment-4898612https://api.github.com/repos/sportngin/ngin/comments/4898612150263752657c602d24708d59234c64378a751014aDid you do this just to make me grumpy? passing `false` to `save` is deprecated and no longer workers in rails 3.1+ The new syntax is `save(:validate => false)`bG2013-12-18 21:23:01.0000002013-12-18 21:23:01.000000‚,‚ª«[]=AAhttps://github.com/sportngin/ngin/commit/5bfb43fdfccef42544219aff5fa2bc85fdbfeb5c#commitcomment-4887967https://api.github.com/repos/sportngin/ngin/comments/48879675bfb43fdfccef42544219aff5fa2bc85fdbfeb5cAll I see are circles. €52013-12-17 22:28:45.0000002013-12-17 22:28:45.000000†‚ª«[]‡kAAhttps://github.com/sportngin/ngin/commit/5bfb43fdfccef42544219aff5fa2bc85fdbfeb5c#commitcomment-4887956https://api.github.com/repos/sportngin/ngin/comments/48879565bfb43fdfccef42544219aff5fa2bc85fdbfeb5cThis is a pie chart describing that shows the "percentage of lines of code added to this PR that can (in theory) be deployed to production": ![Figure 1](http://upload.wikimedia.org/wikipedia/commons/0/0e/Ski_trail_rating_symbol-green_circle.svg) This is a pie chart showing "the percentage of this PR that is going out any time soon, potentially reducing stress, and synergizing business workflows": ![Figure 2](http://www.intheheavens.org/images/500px-Circle_-_black_simple.svg[1].png)Êž2013-12-17 22:27:17.0000002013-12-17 22:27:17.000000ƒ‚ªªt[]kAAhttps://github.com/sportngin/ngin/commit/5bfb43fdfccef42544219aff5fa2bc85fdbfeb5c#commitcomment-4887924https://api.github.com/repos/sportngin/ngin/comments/48879245bfb43fdfccef42544219aff5fa2bc85fdbfeb5c![](https://encrypted-tbn1.gstatic.com/images?q=tbn:ANd9GcQgPm9dXst6wdy0rqD2SLfNNW7H-2GBHgkVGs-BtaCdCxDu8Q7rDQ)bG2013-12-17 22:24:13.0000002013-12-17 22:24:13.000000‚4‚ª©4[]MAAhttps://github.com/sportngin/ngin/commit/5bfb43fdfccef42544219aff5fa2bc85fdbfeb5c#commitcomment-4887732https://api.github.com/repos/sportngin/ngin/comments/48877325bfb43fdfccef42544219aff5fa2bc85fdbfeb5c@carlallen what have you done...Êž2013-12-17 22:07:34.0000002013-12-17 22:07:34.000000‚D‚ª¦=[]mAAhttps://github.com/sportngin/ngin/commit/5bfb43fdfccef42544219aff5fa2bc85fdbfeb5c#commitcomment-4887357https://api.github.com/repos/sportngin/ngin/comments/48873575bfb43fdfccef42544219aff5fa2bc85fdbfeb5cSeems to fall out of our QA workflow though :) €52013-12-17 21:31:38.0000002013-12-17 21:31:38.000000„1‚ª¦ []„EAAhttps://github.com/sportngin/ngin/commit/5bfb43fdfccef42544219aff5fa2bc85fdbfeb5c#commitcomment-4887306https://api.github.com/repos/sportngin/ngin/comments/48873065bfb43fdfccef42544219aff5fa2bc85fdbfeb5cIt's super annoying because it moves everything on the page after the page loads. So you try to click on something and all of a sudden everything moves. I just don't see why we need to test this on staging when dev mode would be just as useful and would actually have up-to-date data.¨“2013-12-17 21:25:48.0000002013-12-17 21:25:48.000000 + _ r ˆp%%é+ƒ8‚Þ„][]‚SAAhttps://github.com/sportngin/ngin/commit/e89464899d60c080445a09c53508a781f1a70e93#commitcomment-5735005https://api.github.com/repos/sportngin/ngin/comments/5735005e89464899d60c080445a09c53508a781f1a70e93@travisdahlke changed to use `roster_players.viewable` and added `is_node_type_team_instance?` check before declaring `roster` is this what you were thinking?!‰]2014-03-19 21:08:58.0000002014-03-19 21:08:58.000000‚6‚Þx[]QAAhttps://github.com/sportngin/ngin/commit/d211c3102b721dc31585d8d6ebb07c02e3b4fabc#commitcomment-5734648https://api.github.com/repos/sportngin/ngin/comments/5734648d211c3102b721dc31585d8d6ebb07c02e3b4fabc@travisdahlke does this look good?!‰]2014-03-19 20:43:27.0000002014-03-19 20:43:27.000000ƒz‚Ø÷Z[]ƒWAAhttps://github.com/sportngin/ngin/commit/0f6b3be7f41b05744593c74d054853349355f19c#commitcomment-5651418https://api.github.com/repos/sportngin/ngin/comments/56514180f6b3be7f41b05744593c74d054853349355f19cScratch that, git is smarter than me. I only added the new file to the commit and did not add the removal of the file (which didn't happen automatically b/c I also modified it). New commit added to remove file and pass the tests.#û32014-03-12 16:25:07.0000002014-03-12 16:25:07.000000‚E‚Øög[]oAAhttps://github.com/sportngin/ngin/commit/0f6b3be7f41b05744593c74d054853349355f19c#commitcomment-5651303https://api.github.com/repos/sportngin/ngin/comments/56513030f6b3be7f41b05744593c74d054853349355f19c:( git did not understand that I moved this file.#û32014-03-12 16:17:36.0000002014-03-12 16:17:36.000000„‚×´}[]„AAhttps://github.com/sportngin/ngin/commit/c1b060eb15e9bb713d564a1f1725cac0d6a23f87#commitcomment-5626493https://api.github.com/repos/sportngin/ngin/comments/5626493c1b060eb15e9bb713d564a1f1725cac0d6a23f87You could have just created a `settings` (or possibly `migration_settings`) method to represent it. You probably could have even memoized it as well: ```ruby def migration_settings @migration_settings = { # your settings here } end ```Êž2014-03-10 22:12:54.0000002014-03-10 22:12:54.000000ƒd‚×´L[]ƒ+AAhttps://github.com/sportngin/ngin/commit/c1b060eb15e9bb713d564a1f1725cac0d6a23f87#commitcomment-5626444https://api.github.com/repos/sportngin/ngin/comments/5626444c1b060eb15e9bb713d564a1f1725cac0d6a23f87I used a class variable `@@settings` b/c using an instance variable (`@settings`) did not work. Am I to assume that rails doesn't instantiate an object for migrations but rather just uses the class methods? #û32014-03-10 22:08:58.0000002014-03-10 22:08:58.000000ƒg‚½Ö~[ ]ƒ/AAhttps://github.com/sportngin/ngin/commit/2ef573c2d1dde486a939cf83457bb20a4c7874ba#commitcomment-5204862https://api.github.com/repos/sportngin/ngin/comments/520486212ef573c2d1dde486a939cf83457bb20a4c7874ba@nataliq FYI I had to remove this file on staging branch since there is another file of the same name, and the deploy failed because two files can't have the same name. Please add it back if it's still needed.ñ¥2014-01-28 19:53:56.0000002014-01-28 19:53:56.000000‚(‚ºó[]1AAhttps://github.com/sportngin/ngin/commit/f0ad0913705115c080ee91b586051d5fdd67a7ab#commitcomment-5159320https://api.github.com/repos/sportngin/ngin/comments/51593202f0ad0913705115c080ee91b586051d5fdd67a7abYou have a `do do`¨“2014-01-23 20:43:50.0000002014-01-23 20:43:50.000000‚m‚²›[]7AAhttps://github.com/sportngin/ngin/commit/4f09cccafd579c839fb54e838b328f8938c12eff#commitcomment-5016983https://api.github.com/repos/sportngin/ngin/comments/5016983214f09cccafd579c839fb54e838b328f8938c12effMinor point, will this work? `if @subseason.ext_game_id_preferences.try(:persisted?)`ñ¥2014-01-08 21:46:05.0000002014-01-08 21:46:05.000000 T´ á¿‚T‚(‚ßÌ;[ ]3AAhttps://github.com/sportngin/ngin/commit/3581ee7c203e3d28254bca7ffc1fb8fee740049e#commitcomment-5760571https://api.github.com/repos/sportngin/ngin/comments/576057113581ee7c203e3d28254bca7ffc1fb8fee740049e/\/ice hyphen, dudeÙ?2014-03-21 18:17:14.0000002014-03-21 18:17:14.000000ˆ7‚ßµq[]ŒQAAhttps://github.com/sportngin/ngin/commit/7fef6205c32ac95257c01ae960e822cecc00aa43#commitcomment-5757681https://api.github.com/repos/sportngin/ngin/comments/57576817fef6205c32ac95257c01ae960e822cecc00aa43Nothing I can think of off the top of my head. Zach Serre wrote: > > @dougrohde setting |active_only| > parameter to |true| appears to fix this issue for traded players. I > went through and checked and it appears the only way you can access > this function is when referencing team stats. Travis thought that it > might interfere with the division stats but this method does not > appear to get called when referencing division stats. > > Off the top of your head is there a reason why this is set to |false|? > I would like to make this change but am concerned about introducing > additional issues. > > — > Reply to this email directly or view it on GitHub > .Aq2014-03-21 14:55:46.0000002014-03-21 14:55:46.000000†‚ß²u[]ˆAAhttps://github.com/sportngin/ngin/commit/7fef6205c32ac95257c01ae960e822cecc00aa43#commitcomment-5757301https://api.github.com/repos/sportngin/ngin/comments/57573017fef6205c32ac95257c01ae960e822cecc00aa43@dougrohde setting `active_only` parameter to `true` appears to fix this issue for traded players. I went through and checked and it appears the only way you can access this function is when referencing team stats. Travis thought that it might interfere with the division stats but this method does not appear to get called when referencing division stats. Off the top of your head is there a reason why this is set to `false`? I would like to make this change but am concerned about introducing additional issues.!‰]2014-03-21 14:34:34.0000002014-03-21 14:34:34.000000‰M‚Þï[]Ž}AAhttps://github.com/sportngin/ngin/commit/7fef6205c32ac95257c01ae960e822cecc00aa43#commitcomment-5748627https://api.github.com/repos/sportngin/ngin/comments/57486277fef6205c32ac95257c01ae960e822cecc00aa43@travisdahlke it looks like they already do essentially what I was trying to do in the other PR. I am assuming we only want to do it one way? This way filters the results *after* the call to stat ngin. The way I do it in the other pull request is to filter the results *inside* stat ngin. Is there a preferred way of handling this? I assume we want to cut down on network traffic as much as possible and therefore I would assume to do the filtering inside stat ngin. Thoughts? Actually after thinking about it, in https://github.com/sportngin/ngin/pull/3795 we *have* to filter the player list before hand because the returned we want the returned list of results to be of a fixed size To put it another way, we don't want to return the top 5 stats leaders and then eliminate one because he is no longer on the team. In this instance that shouldn't matter though, unless we want to enforce it for consistency / style / performance reasons!‰]2014-03-20 20:07:59.0000002014-03-20 21:10:52.000000‚F‚Þ›C[]qAAhttps://github.com/sportngin/ngin/commit/278a933c1b27ef40f773417e91a341c67ebb0af1#commitcomment-5737923https://api.github.com/repos/sportngin/ngin/comments/5737923278a933c1b27ef40f773417e91a341c67ebb0af1@travisdahlke can you sign off on CR here as well?!‰]2014-03-20 02:02:17.0000002014-03-20 02:02:42.000000 ``Ì ˆ D…*ìƒ_mMUAiuq_awuAAjakemerhttps://avatars.githubusercontent.com/u/3867103?de564f45d55f1adcfe426d703d256b2fhttps://api.github.com/users/jakemerhttps://github.com/jakemerhttps://api.github.com/users/jakemer/followershttps://api.github.com/users/jakemer/following{/other_user}https://api.github.com/users/jakemer/gists{/gist_id}https://api.github.com/users/jakemer/starred{/owner}{/repo}https://api.github.com/users/jakemer/subscriptionshttps://api.github.com/users/jakemer/orgshttps://api.github.com/users/jakemer/reposhttps://api.github.com/users/jakemer/events{/privacy}https://api.github.com/users/jakemer/received_eventsUserf2014-06-05 15:36:00.9667332014-06-05 15:36:00.966733…6ó´UmMWCkwsacywAAjaegernhhttps://avatars.githubusercontent.com/u/3988053?cd7ff7c5b11a91acc06a8f8aa8607de8https://api.github.com/users/jaegernhhttps://github.com/jaegernhhttps://api.github.com/users/jaegernh/followershttps://api.github.com/users/jaegernh/following{/other_user}https://api.github.com/users/jaegernh/gists{/gist_id}https://api.github.com/users/jaegernh/starred{/owner}{/repo}https://api.github.com/users/jaegernh/subscriptionshttps://api.github.com/users/jaegernh/orgshttps://api.github.com/users/jaegernh/reposhttps://api.github.com/users/jaegernh/events{/privacy}https://api.github.com/users/jaegernh/received_eventsUserf2014-06-05 15:36:00.9075272014-06-05 15:36:00.907527…6‚‚ËimMWCkwsacywAAdlyckmanhttps://avatars.githubusercontent.com/u/4236777?9295c33be809e3da93a5076cdd67848ahttps://api.github.com/users/dlyckmanhttps://github.com/dlyckmanhttps://api.github.com/users/dlyckman/followershttps://api.github.com/users/dlyckman/following{/other_user}https://api.github.com/users/dlyckman/gists{/gist_id}https://api.github.com/users/dlyckman/starred{/owner}{/repo}https://api.github.com/users/dlyckman/subscriptionshttps://api.github.com/users/dlyckman/orgshttps://api.github.com/users/dlyckman/reposhttps://api.github.com/users/dlyckman/events{/privacy}https://api.github.com/users/dlyckman/received_eventsUserf2014-06-05 15:36:00.8376062014-06-05 15:36:00.837606…6‚†—fmMWCkwsacywAAdsnelsonhttps://avatars.githubusercontent.com/u/4295654?4b310a3780afe54f7096c72e1fa1f10bhttps://api.github.com/users/dsnelsonhttps://github.com/dsnelsonhttps://api.github.com/users/dsnelson/followershttps://api.github.com/users/dsnelson/following{/other_user}https://api.github.com/users/dsnelson/gists{/gist_id}https://api.github.com/users/dsnelson/starred{/owner}{/repo}https://api.github.com/users/dsnelson/subscriptionshttps://api.github.com/users/dsnelson/orgshttps://api.github.com/users/dsnelson/reposhttps://api.github.com/users/dsnelson/events{/privacy}https://api.github.com/users/dsnelson/received_eventsUserf2014-06-05 15:36:02.2127322014-06-05 15:36:02.212732…6ƒ®šmMWCkwsacywAArbedeauxhttps://avatars.githubusercontent.com/u/7048473?869cd3860ea1bb475040b796a0e475c8https://api.github.com/users/rbedeauxhttps://github.com/rbedeauxhttps://api.github.com/users/rbedeaux/followershttps://api.github.com/users/rbedeaux/following{/other_user}https://api.github.com/users/rbedeaux/gists{/gist_id}https://api.github.com/users/rbedeaux/starred{/owner}{/repo}https://api.github.com/users/rbedeaux/subscriptionshttps://api.github.com/users/rbedeaux/orgshttps://api.github.com/users/rbedeaux/reposhttps://api.github.com/users/rbedeaux/events{/privacy}https://api.github.com/users/rbedeaux/received_eventsUserf2014-06-05 15:36:02.2930382014-06-05 15:36:02.293038 c º ˆåãcˆz‚è”[]WAAhttps://github.com/sportngin/ngin/commit/b69f487a134887c322903a380ef45128c7e0ab84#commitcomment-5900828https://api.github.com/repos/sportngin/ngin/comments/5900828b69f487a134887c322903a380ef45128c7e0ab84Yep. We never implemented notifications on future articles. That was known at the time On Thu, Apr 3, 2014 at 2:56 PM, Kevin Boedigheimer wrote: > What Michael is saying is that because this is an after create callback, > unless the article is published immediately, the notification would never > be sent. Some sort of cron is necessary to send out article events on > publish date. > > -- > Reply to this email directly or view it on GitHub > . > -- *Nate Greene* SOFTWARE ARCHITECT *Sport Ngin | 1400 Van Buren St NE, Suite 200 | Minneapolis, MN 55413* 888.255.7840 | nate.greene@sportngin.com *http://www.sportngin.com | * http://www.twitter.com/sportngin | http://www.facebook.com/sportngin€52014-04-03 20:03:01.0000002014-04-03 20:03:01.000000ƒ|‚è“?[]ƒ[AAhttps://github.com/sportngin/ngin/commit/b69f487a134887c322903a380ef45128c7e0ab84#commitcomment-5900735https://api.github.com/repos/sportngin/ngin/comments/5900735b69f487a134887c322903a380ef45128c7e0ab84What Michael is saying is that because this is an after create callback, unless the article is published immediately, the notification would never be sent. Some sort of cron is necessary to send out article events on publish date.ðž2014-04-03 19:56:48.0000002014-04-03 19:56:48.000000ƒ‚è“[]‚AAhttps://github.com/sportngin/ngin/commit/b69f487a134887c322903a380ef45128c7e0ab84#commitcomment-5900698https://api.github.com/repos/sportngin/ngin/comments/5900698b69f487a134887c322903a380ef45128c7e0ab84I suppose it "should" work that way, shouldn't it. the < operator should really be comparing UTC. I bet that it actually does do that. ðž2014-04-03 19:53:32.0000002014-04-03 19:53:32.000000‚{‚è’|[]YAAhttps://github.com/sportngin/ngin/commit/b69f487a134887c322903a380ef45128c7e0ab84#commitcomment-5900668https://api.github.com/repos/sportngin/ngin/comments/5900668b69f487a134887c322903a380ef45128c7e0ab84Umm yeah? so your #3 with timezone CT is compared to Time.now with timezone PT. That should work €52014-04-03 19:51:30.0000002014-04-03 19:51:30.000000…+‚è’ []†1AAhttps://github.com/sportngin/ngin/commit/b69f487a134887c322903a380ef45128c7e0ab84#commitcomment-5900554https://api.github.com/repos/sportngin/ngin/comments/5900554321b69f487a134887c322903a380ef45128c7e0ab84The tst_site_timezone "forces" a timezone on a date_time without changing the date. This is done because we save a date that is already in the timezone of the ngin site, but when it comes back out of the database, it is listed as server time. ie- 1) article is saved at 12:00 PM CT 2) article is retrieved from DB and the date reads: 12:00 PM PT 3) tst_site_timezone restores the original zone.ðž2014-04-03 19:41:12.0000002014-04-03 20:01:59.000000„@‚ä®[]„]AAhttps://github.com/sportngin/ngin/commit/29dee8df16490d15a7fd74fdec42c88d33771294#commitcomment-5838617https://api.github.com/repos/sportngin/ngin/comments/58386177329dee8df16490d15a7fd74fdec42c88d33771294This sort of works based on luck. A better test would stub out the current_user.can_write?(page_node, site) used in the controller method. I'm not sure how do stub that out and I'm not sure how valuable such a test would be (since stubbing its value is more complex than the method being tested).#û32014-03-28 20:03:50.0000002014-03-28 20:03:50.000000 % ¼ #¹E%ÅX%‚-ƒ‡õ.[]?AAhttps://github.com/sportngin/ngin/commit/250990ae7228e264d8f399e0d1ce7448f42b9a88#commitcomment-6421166https://api.github.com/repos/sportngin/ngin/comments/6421166250990ae7228e264d8f399e0d1ce7448f42b9a88@anfleene check this out?%qs2014-05-22 20:59:53.0000002014-05-22 20:59:53.000000‚gƒ‚Š|[]+AAhttps://github.com/sportngin/ngin/commit/801987bd13a5d14d5b2cf5e1bef18c6c5607dfd1#commitcomment-6325628https://api.github.com/repos/sportngin/ngin/comments/6325628 77801987bd13a5d14d5b2cf5e1bef18c6c5607dfd1Found that options[:acct_num] is passed in all the tests so I just used it here ‚ 2014-05-14 19:59:22.0000002014-05-14 19:59:22.000000‚Zƒ‚Šg[]AAhttps://github.com/sportngin/ngin/commit/801987bd13a5d14d5b2cf5e1bef18c6c5607dfd1#commitcomment-6325607https://api.github.com/repos/sportngin/ngin/comments/6325607)102801987bd13a5d14d5b2cf5e1bef18c6c5607dfd1Used Optional params so I don't break the other gateways testing ‚ 2014-05-14 19:58:17.0000002014-05-14 19:58:17.000000†‚÷â,[]ˆAAhttps://github.com/sportngin/ngin/commit/9d3d07eef870556a41dbc3745333820917116cf0#commitcomment-6156588https://api.github.com/repos/sportngin/ngin/comments/615658859d3d07eef870556a41dbc3745333820917116cf0Since they need to have a manager/owner in TeamSnap for it to work on that side, let's adjust the language a tad. How about this? +We synced your Sport Ngin team <%= @team_instance.name %> to TeamSnap. To manage your team in TeampSnap, you must assign manager/owner permissions from the permission tab of the team page. If you have any questions you can also contact us.k2014-04-29 14:52:39.0000002014-04-29 14:52:39.000000‚n‚öË[];AAhttps://github.com/sportngin/ngin/commit/9d3d07eef870556a41dbc3745333820917116cf0#commitcomment-6137219https://api.github.com/repos/sportngin/ngin/comments/613721959d3d07eef870556a41dbc3745333820917116cf0@rbedeaux please review text here and provide feedback to Zheng on the wording. Thanks©]2014-04-28 03:33:13.0000002014-04-28 03:33:13.000000‚d‚öÊ~[]'AAhttps://github.com/sportngin/ngin/commit/9d3d07eef870556a41dbc3745333820917116cf0#commitcomment-6137214https://api.github.com/repos/sportngin/ngin/comments/613721489d3d07eef870556a41dbc3745333820917116cf0Let's change this to "Your Sport Ngin team xxxxx has been created in TeamSnap©]2014-04-28 03:32:37.0000002014-04-28 03:32:37.000000ƒ‚ö²[]‚AAhttps://github.com/sportngin/ngin/commit/8eeb3c3f0a85daa3aa6e14394aed07b45a84dd2b#commitcomment-6134035https://api.github.com/repos/sportngin/ngin/comments/61340351988eeb3c3f0a85daa3aa6e14394aed07b45a84dd2bRight, got rid of the site setting check, not needed, instead now checking for the presence of the ext_game_id_preference.A‹æ2014-04-27 12:25:46.0000002014-04-27 12:25:46.000000„D‚ó¾j[]„cAAhttps://github.com/sportngin/ngin/commit/8eeb3c3f0a85daa3aa6e14394aed07b45a84dd2b#commitcomment-6086506https://api.github.com/repos/sportngin/ngin/comments/60865061988eeb3c3f0a85daa3aa6e14394aed07b45a84dd2bI guess ext_game_id_preference will be always created and present if the site setting is enabled, even for the current subseason that does not have the game id turned on http://demo.multisportsystems.com.stage.ngin-staging.com/page/show/643758?tab=seasons. Maybe check if ext_game_id_mode is set?ñ¥2014-04-22 20:33:18.0000002014-04-22 20:33:18.000000ƒt‚éÿ[]ƒEAAhttps://github.com/sportngin/ngin/commit/21cc0b8dcf6846ed65be5987d7463cb8d4bb13aa#commitcomment-5930896https://api.github.com/repos/sportngin/ngin/comments/5930896O8521cc0b8dcf6846ed65be5987d7463cb8d4bb13aaIt seems this file has methods (sport_id, sport, stat_modules, after copy, destory_stat_types, stat_types_by_module) that are the same as app/models/widget/team_stats_widget.rb. May be we could refactor them to a module.ñ¥2014-04-07 16:35:57.0000002014-04-07 16:35:57.000000  a a…6ƒ®šmMWCkwsacywAAr…ƒ‹¦v[]†AAhttps://github.com/sportngin/ngin/commit/e89402a5ed7f8f8938e68bf5caa4e8962d962c45#commitcomment-6476662https://api.github.com/repos/sportngin/ngin/comments/647666248e89402a5ed7f8f8938e68bf5caa4e8962d962c45This is how you should be calling it: ```ruby Ngin.log :mobile_notifications_log, { :message => message, :custom_fields => { :location => 'MobileNotification.send_notification_for_teams' } } ``` Basically, everything not in `message` needs to go inside the `custom_fields` hash. Here's the gem that's providing this functionality: https://github.com/jphenow/scribbler¨“2014-05-28 16:39:47.0000002014-05-28 16:39:47.000000