Sha256: 8887c7b03f53e4e6d125b3165163b105683f9d6546b0ef4bbe2eececa70405c9
Contents?: true
Size: 1.57 KB
Versions: 13
Compression:
Stored size: 1.57 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Minitest
# Enforces the test to use `assert_path_exists` instead of using `assert(File.exist?(path))`.
#
# @example
# # bad
# assert(File.exist?(path))
# assert(File.exist?(path), 'message')
#
# # good
# assert_path_exists(path)
# assert_path_exists(path, 'message')
#
class AssertPathExists < Base
extend AutoCorrector
MSG = 'Prefer using `%<good_method>s`.'
RESTRICT_ON_SEND = %i[assert].freeze
def_node_matcher :assert_file_exists, <<~PATTERN
(send nil? :assert
(send
(const _ :File) {:exist? :exists?} $_)
$...)
PATTERN
def on_send(node)
assert_file_exists(node) do |path, failure_message|
failure_message = failure_message.first
good_method = build_good_method(node, path, failure_message)
message = format(MSG, good_method: good_method)
add_offense(node, message: message) do |corrector|
corrector.replace(node.loc.selector, 'assert_path_exists')
corrector.replace(node.first_argument, path.source)
end
end
end
private
def build_good_method(node, path, message)
args = [path.source, message&.source].compact.join(', ')
if node.parenthesized?
"assert_path_exists(#{args})"
else
"assert_path_exists #{args}"
end
end
end
end
end
end
Version data entries
13 entries across 13 versions & 1 rubygems