Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Minitest
      # Check if your test uses `assert_includes`
      # instead of `assert(collection.includes?(actual))`.
      #
      # @example
      #   # bad
      #   assert(collection.includes?(actual))
      #   assert(collection.includes?(actual), 'the message')
      #
      #   # good
      #   assert_includes(collection, actual)
      #   assert_includes(collection, actual, 'the message')
      #
      class AssertIncludes < Cop
        MSG = 'Prefer using `assert_includes(%<arguments>s)` over ' \
              '`assert(%<receiver>s)`.'

        def_node_matcher :assert_with_includes, <<~PATTERN
          (send nil? :assert $(send $_ :includes? $_) $...)
        PATTERN

        def on_send(node)
          assert_with_includes(node) do
            |first_receiver_arg, collection, actual, rest_receiver_arg|

            message = rest_receiver_arg.first
            arguments = node_arguments(collection, actual, message)
            receiver = [first_receiver_arg.source, message&.source].compact.join(', ')

            offense_message = format(MSG, arguments: arguments, receiver: receiver)

            add_offense(node, message: offense_message)
          end
        end

        def autocorrect(node)
          lambda do |corrector|
            assert_with_includes(node) do
              |_receiver, collection, actual, rest_receiver_arg|

              message = rest_receiver_arg.first
              replacement = node_arguments(collection, actual, message)
              corrector.replace(node.loc.expression, "assert_includes(#{replacement})")
            end
          end
        end

        private

        def node_arguments(collection, actual, message)
          [collection.source, actual.source, message&.source].compact.join(', ')
        end
      end
    end
  end
end

Version data entries

2 entries across 2 versions & 1 rubygems

Version	Path
rubocop-minitest-0.2.1	lib/rubocop/cop/minitest/assert_includes.rb
rubocop-minitest-0.2.0	lib/rubocop/cop/minitest/assert_includes.rb