Contents

require 'rails_best_practices/checks/check'

module RailsBestPractices
  module Checks
    # Check a controller file to make sure to use before_filter to remove duplicate call in different action.
    #
    # Implementation: Check all methods' first call, if they are duplicate, then should use before_filter.
    class UseBeforeFilterCheck < Check

      def interesting_nodes
        [:class]
      end

      def interesting_files
        CONTROLLER_FILES
      end

      def evaluate_start(node)
        @methods = {}
        node.grep_nodes({:node_type => :defn}).each { |method_node| remember_method(method_node) }
        @methods.each do |first_call, method_names|
          add_error "use before_filter for #{first_call.to_ruby} in #{method_names.join(',')}" if method_names.size > 1
        end
      end

      private

      def remember_method(method_node)
        method_name = method_node.message_name
        first_call = method_node.body[1]
        unless first_call == s(:nil)
          @methods[first_call] ||= []
          @methods[first_call] << method_name
        end
      end
    end
  end
end

Version data entries

12 entries across 12 versions & 1 rubygems

Version	Path
rails_best_practices-0.3.14	lib/rails_best_practices/checks/use_before_filter_check.rb
rails_best_practices-0.3.13	lib/rails_best_practices/checks/use_before_filter_check.rb
rails_best_practices-0.3.12	lib/rails_best_practices/checks/use_before_filter_check.rb
rails_best_practices-0.3.11	lib/rails_best_practices/checks/use_before_filter_check.rb
rails_best_practices-0.3.10	lib/rails_best_practices/checks/use_before_filter_check.rb
rails_best_practices-0.3.9	lib/rails_best_practices/checks/use_before_filter_check.rb
rails_best_practices-0.3.8	lib/rails_best_practices/checks/use_before_filter_check.rb
rails_best_practices-0.3.7	lib/rails_best_practices/checks/use_before_filter_check.rb
rails_best_practices-0.3.6	lib/rails_best_practices/checks/use_before_filter_check.rb
rails_best_practices-0.3.5	lib/rails_best_practices/checks/use_before_filter_check.rb
rails_best_practices-0.3.4	lib/rails_best_practices/checks/use_before_filter_check.rb
rails_best_practices-0.3.3	lib/rails_best_practices/checks/use_before_filter_check.rb