Sha256: 88515f5b5d0c79996639fee97c6da86d25a73599f15febb6206d920824b37549

Contents?: true

Size: 1.01 KB

Versions: 6494

Compression:

Stored size: 1.01 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Lint
      # This cop checks for *return* from an *ensure* block.
      # Explicit return from an ensure block alters the control flow
      # as the return will take precedence over any exception being raised,
      # and the exception will be silently thrown away as if it were rescued.
      #
      # @example
      #
      #   # bad
      #
      #   begin
      #     do_something
      #   ensure
      #     do_something_else
      #     return
      #   end
      #
      # @example
      #
      #   # good
      #
      #   begin
      #     do_something
      #   ensure
      #     do_something_else
      #   end
      class EnsureReturn < Cop
        MSG = 'Do not return from an `ensure` block.'.freeze

        def on_ensure(node)
          ensure_body = node.body

          return unless ensure_body

          ensure_body.each_node(:return) do |return_node|
            add_offense(return_node)
          end
        end
      end
    end
  end
end

Version data entries

6,494 entries across 6,488 versions & 24 rubygems

Version Path
rubocop-0.67.0 lib/rubocop/cop/lint/ensure_return.rb
rubocop-0.66.0 lib/rubocop/cop/lint/ensure_return.rb
rubocop-0.65.0 lib/rubocop/cop/lint/ensure_return.rb
rubocop-0.64.0 lib/rubocop/cop/lint/ensure_return.rb
rubocop-0.63.1 lib/rubocop/cop/lint/ensure_return.rb
rubocop-0.63.0 lib/rubocop/cop/lint/ensure_return.rb
rubocop-0.62.0 lib/rubocop/cop/lint/ensure_return.rb
rubocop-0.61.1 lib/rubocop/cop/lint/ensure_return.rb
rubocop-0.61.0 lib/rubocop/cop/lint/ensure_return.rb
config_gems_initialization_aim-0.1.4 vendor/bundle/ruby/2.5.0/gems/config_gems_initialization_aim-0.1.1/vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/lint/ensure_return.rb
config_gems_initialization_aim-0.1.4 vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/lint/ensure_return.rb
config_gems_initialization_aim-0.1.3 vendor/bundle/ruby/2.5.0/gems/config_gems_initialization_aim-0.1.1/vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/lint/ensure_return.rb
config_gems_initialization_aim-0.1.3 vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/lint/ensure_return.rb
rubocop-0.60.0 lib/rubocop/cop/lint/ensure_return.rb