Sha256: 877516b508b98e47080020a6af5c33b97e12ca9b6155c3b1cc7fd414e578f346
Contents?: true
Size: 1.86 KB
Versions: 19
Compression:
Stored size: 1.86 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Style
# Looks for uses of `map.to_set` or `collect.to_set` that could be
# written with just `to_set`.
#
# @safety
# This cop is unsafe, as it can produce false positives if the receiver
# is not an `Enumerable`.
#
# @example
# # bad
# something.map { |i| i * 2 }.to_set
#
# # good
# something.to_set { |i| i * 2 }
#
# # bad
# [1, 2, 3].collect { |i| i.to_s }.to_set
#
# # good
# [1, 2, 3].to_set { |i| i.to_s }
#
class MapToSet < Base
extend AutoCorrector
include RangeHelp
MSG = 'Pass a block to `to_set` instead of calling `%<method>s.to_set`.'
RESTRICT_ON_SEND = %i[to_set].freeze
# @!method map_to_set?(node)
def_node_matcher :map_to_set?, <<~PATTERN
{
$(send ({block numblock} $(send _ {:map :collect}) ...) :to_set)
$(send $(send _ {:map :collect} (block_pass sym)) :to_set)
}
PATTERN
def on_send(node)
return unless (to_set_node, map_node = map_to_set?(node))
message = format(MSG, method: map_node.loc.selector.source)
add_offense(map_node.loc.selector, message: message) do |corrector|
# If the `to_set` call already has a block, do not autocorrect.
next if to_set_node.block_literal?
autocorrect(corrector, to_set_node, map_node)
end
end
private
def autocorrect(corrector, to_set, map)
removal_range = range_between(to_set.loc.dot.begin_pos, to_set.loc.selector.end_pos)
corrector.remove(range_with_surrounding_space(removal_range, side: :left))
corrector.replace(map.loc.selector, 'to_set')
end
end
end
end
end
Version data entries
19 entries across 19 versions & 4 rubygems