# frozen_string_literal: true module RuboCop module Cop module RSpec # Checks that message expectations are set using spies. # # This cop can be configured in your configuration using the # `EnforcedStyle` option and supports `--auto-gen-config`. # # @example `EnforcedStyle: have_received` # # # bad # expect(foo).to receive(:bar) # # # good # expect(foo).to have_received(:bar) # # @example `EnforcedStyle: receive` # # # bad # expect(foo).to have_received(:bar) # # # good # expect(foo).to receive(:bar) # class MessageSpies < Cop include ConfigurableEnforcedStyle MSG_RECEIVE = 'Prefer `receive` for setting message ' \ 'expectations.'.freeze MSG_HAVE_RECEIVED = 'Prefer `have_received` for setting message ' \ 'expectations. Setup `%s` as a spy using `allow` or `instance_spy`.' .freeze SUPPORTED_STYLES = %w(have_received receive).freeze def_node_matcher :message_expectation, %( (send (send nil :expect (send nil $_)) :to ...) ) def_node_search :receive_message, %( $(send nil {:receive :have_received} ...) ) def on_send(node) receive_message_matcher(node) do |receiver, message_matcher| return correct_style_detected if preferred_style?(message_matcher) add_offense(message_matcher, :selector, error_message(receiver)) do opposite_style_detected end end end private def receive_message_matcher(node) return unless (receiver = message_expectation(node)) receive_message(node) { |match| yield(receiver, match) } end def preferred_style?(expectation) expectation.method_name.equal?(style) end def error_message(receiver) case style when :receive MSG_RECEIVE when :have_received MSG_HAVE_RECEIVED % receiver end end end end end end