Sha256: 819ef7a5a48326fdf45abb55f00349a4c11b9a058d944ba97e0d1763938f9a2f
Contents?: true
Size: 1.98 KB
Versions: 7
Compression:
Stored size: 1.98 KB
Contents
# frozen_string_literal: true
require 'spec_helper'
module RailsBestPractices
module Reviews
describe ReplaceInstanceVariableWithLocalVariableReview do
let(:runner) { Core::Runner.new(reviews: described_class.new) }
it 'replaces instance variable with local varialbe' do
content = <<-EOF
<%= @post.title %>
EOF
runner.review('app/views/posts/_post.html.erb', content)
expect(runner.errors.size).to eq(1)
expect(runner.errors[0].to_s).to eq(
'app/views/posts/_post.html.erb:1 - replace instance variable with local variable'
)
end
it 'replaces instance variable with local varialbe in haml file' do
content = <<~EOF
= @post.title
EOF
runner.review('app/views/posts/_post.html.haml', content)
expect(runner.errors.size).to eq(1)
expect(runner.errors[0].to_s).to eq(
'app/views/posts/_post.html.haml:1 - replace instance variable with local variable'
)
end
it 'replaces instance variable with local varialbe in slim file' do
content = <<~EOF
= @post.title
EOF
runner.review('app/views/posts/_post.html.slim', content)
expect(runner.errors.size).to eq(1)
expect(runner.errors[0].to_s).to eq(
'app/views/posts/_post.html.slim:1 - replace instance variable with local variable'
)
end
it 'does not replace instance variable with local varialbe' do
content = <<-EOF
<%= post.title %>
EOF
runner.review('app/views/posts/_post.html.erb', content)
expect(runner.errors.size).to eq(0)
end
it 'does not check ignored files' do
runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{views/posts}))
content = <<-EOF
<%= @post.title %>
EOF
runner.review('app/views/posts/_post.html.erb', content)
expect(runner.errors.size).to eq(0)
end
end
end
end
Version data entries
7 entries across 7 versions & 1 rubygems