Sha256: 7eb8f34fa564906ac64bf0cd9e00f957e1d1db1a14dc6a5e0a593c5b9cc042c7
Contents?: true
Size: 1.66 KB
Versions: 38
Compression:
Stored size: 1.66 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Style
# This cop checks for potential uses of `Enumerable#minmax`.
#
# @example
#
# # bad
# bar = [foo.min, foo.max]
# return foo.min, foo.max
#
# # good
# bar = foo.minmax
# return foo.minmax
class MinMax < Base
extend AutoCorrector
MSG = 'Use `%<receiver>s.minmax` instead of `%<offender>s`.'
def on_array(node)
min_max_candidate(node) do |receiver|
offender = offending_range(node)
add_offense(offender, message: message(offender, receiver)) do |corrector|
receiver = node.children.first.receiver
corrector.replace(offending_range(node), "#{receiver.source}.minmax")
end
end
end
alias on_return on_array
private
# @!method min_max_candidate(node)
def_node_matcher :min_max_candidate, <<~PATTERN
({array return} (send [$_receiver !nil?] :min) (send [$_receiver !nil?] :max))
PATTERN
def message(offender, receiver)
format(MSG, offender: offender.source, receiver: receiver.source)
end
def offending_range(node)
case node.type
when :return
argument_range(node)
else
node.loc.expression
end
end
def argument_range(node)
first_argument_range = node.children.first.loc.expression
last_argument_range = node.children.last.loc.expression
first_argument_range.join(last_argument_range)
end
end
end
end
end
Version data entries
38 entries across 38 versions & 6 rubygems