Sha256: 7e0e5daae72ea4cb06dac933f1369109bcac6975fc4edf0dc161c843dd1a7c9f
Contents?: true
Size: 1.03 KB
Versions: 17
Compression:
Stored size: 1.03 KB
Contents
require 'spec_helper'
module RailsBestPractices
module Reviews
describe MoveCodeIntoHelperReview do
let(:runner) { Core::Runner.new(reviews: MoveCodeIntoHelperReview.new('array_count' => 2)) }
it "should move code into helper" do
content = <<-EOF
<%= select_tag :state, options_for_select( [[t(:draft), "draft"],
[t(:published), "published"]],
params[:default_state] ) %>
EOF
runner.review('app/views/posts/show.html.erb', content)
runner.should have(1).errors
runner.errors[0].to_s.should == "app/views/posts/show.html.erb:1 - move code into helper (array_count >= 2)"
end
it "should not move code into helper with simple arguments" do
content = <<-EOF
<%= select_tag :state, options_for_select( Post.STATES ) %>
EOF
runner.review('app/views/posts/show.html.erb', content)
runner.should have(0).errors
end
end
end
end
Version data entries
17 entries across 17 versions & 1 rubygems