Contents

# encoding: utf-8

module Rubocop
  module Cop
    module Style
      # This cop checks for uses of "*" as a substitute for *join*.
      #
      # Not all cases can reliably checked, due to Ruby's dynamic
      # types, so we consider only cases when the first argument is an
      # array literal or the second is a string literal.
      class FavorJoin < Cop
        MSG = 'Favor Array#join over Array#*.'

        def on_send(node)
          receiver_node, method_name, *arg_nodes = *node

          if receiver_node && receiver_node.type == :array &&
              method_name == :* && arg_nodes[0].type == :str
            add_offence(:convention,
                        node.loc.selector,
                        MSG)
          end

          super
        end
      end
    end
  end
end

Version data entries

3 entries across 3 versions & 2 rubygems

Version	Path
rubocop-0.9.1	lib/rubocop/cop/style/favor_join.rb
sabat-rubocop-0.9.0	lib/rubocop/cop/style/favor_join.rb
rubocop-0.9.0	lib/rubocop/cop/style/favor_join.rb