Sha256: 732d24d9a9a9413551e462c32717d5130da070490cd62ce1232e34671833f613

Contents?: true

Size: 1.7 KB

Versions: 20

Compression:

Stored size: 1.7 KB

Contents

#
# Copyright:: 2019, Chef Software Inc.
# Author:: Tim Smith (<tsmith@chef.io>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
  module Cop
    module Chef
      module ChefDeprecations
        # Some providers in resources override the provides? method, used to check whether they are a valid provider on the current platform. In Chef Infra Client 13, this will cause an error. Instead use `provides :SOME_PROVIDER_NAME` to register the provider.
        #
        # @example
        #
        #   # bad
        #   def provides?
        #    true
        #   end
        #
        #   # good
        #   provides :SOME_PROVIDER_NAME
        #
        class ResourceOverridesProvidesMethod < Cop
          MSG = "Don't override the provides? method in a resource provider. Use provides :SOME_PROVIDER_NAME instead. This will cause failures in Chef Infra Client 13 and later.".freeze

          def_node_search :provides, '(send nil? :provides ...)'

          def on_def(node)
            if node.method_name == :provides?
              add_offense(node, location: :expression, message: MSG, severity: :refactor) if provides(processed_source.ast).count == 0
            end
          end
        end
      end
    end
  end
end

Version data entries

20 entries across 20 versions & 1 rubygems

Version Path
cookstyle-5.23.0 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.22.6 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.21.9 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.20.0 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.19.9 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.18.4 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.17.4 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.16.11 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.16.10 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.15.7 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.14.1 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.13.7 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.12.13 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.12.12 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.11.0 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.10.13 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.10.11 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.9.3 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.8.1 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb
cookstyle-5.7.0 lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb