Sha256: 70a46ff50bd39f4f23aa97bd02c4f5e9d99c8638539bf570d711204f4a256da7
Contents?: true
Size: 1.17 KB
Versions: 6
Compression:
Stored size: 1.17 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Lint
# Don't omit the accumulator when calling `next` in a `reduce` block.
#
# @example
#
# # bad
#
# result = (1..4).reduce(0) do |acc, i|
# next if i.odd?
# acc + i
# end
#
# @example
#
# # good
#
# result = (1..4).reduce(0) do |acc, i|
# next acc if i.odd?
# acc + i
# end
class NextWithoutAccumulator < Cop
MSG = 'Use `next` with an accumulator argument in a `reduce`.'.freeze
def_node_matcher :on_body_of_reduce, <<-PATTERN
(block (send _recv {:reduce :inject} !sym) _blockargs $(begin ...))
PATTERN
def on_block(node)
on_body_of_reduce(node) do |body|
void_next = body.each_node(:next).find do |n|
n.children.empty? && parent_block_node(n) == node
end
add_offense(void_next, :expression) if void_next
end
end
private
def parent_block_node(node)
node.each_ancestor(:block).first
end
end
end
end
end
Version data entries
6 entries across 6 versions & 1 rubygems