Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Style
      # This cop checks for cases when you could use a block
      # accepting version of a method that does automatic
      # resource cleanup.
      #
      # @example
      #
      #   # bad
      #   f = File.open('file')
      #
      #   # good
      #   File.open('file') do |f|
      #     # ...
      #   end
      class AutoResourceCleanup < Cop
        MSG = 'Use the block version of `%<class>s.%<method>s`.'

        TARGET_METHODS = {
          File: :open
        }.freeze

        def on_send(node)
          TARGET_METHODS.each do |target_class, target_method|
            next if node.method_name != target_method

            target_receiver = s(:const, nil, target_class)
            next if node.receiver != target_receiver

            next if cleanup?(node)

            add_offense(node,
                        message: format(MSG,
                                        class: target_class,
                                        method: target_method))
          end
        end

        private

        def cleanup?(node)
          parent = node.parent
          node.block_argument? ||
            (parent && (parent.block_type? || !parent.lvasgn_type?))
        end
      end
    end
  end
end

Version data entries

3 entries across 3 versions & 2 rubygems

Version	Path
rubocop-0.89.0	lib/rubocop/cop/style/auto_resource_cleanup.rb
rubocop-0.88.0	lib/rubocop/cop/style/auto_resource_cleanup.rb
rbhint-0.87.1.rc1	lib/rubocop/cop/style/auto_resource_cleanup.rb