Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Lint
      # Checks for duplicate literal, constant, or variable elements in Set.
      #
      # @example
      #
      #   # bad
      #   Set[:foo, :bar, :foo]
      #
      #   # good
      #   Set[:foo, :bar]
      #
      #   # bad
      #   Set.new([:foo, :bar, :foo])
      #
      #   # good
      #   Set.new([:foo, :bar])
      #
      #   # bad
      #   [:foo, :bar, :foo].to_set
      #
      #   # good
      #   [:foo, :bar].to_set
      #
      class DuplicateSetElement < Base
        extend AutoCorrector

        MSG = 'Remove the duplicate element in Set.'
        RESTRICT_ON_SEND = %i[\[\] new to_set].freeze

        # @!method set_init_elements(node)
        def_node_matcher :set_init_elements, <<~PATTERN
          {
            (send (const {nil? cbase} :Set) :[] $...)
            (send (const {nil? cbase} :Set) :new (array $...))
            (call (array $...) :to_set)
          }
        PATTERN

        def on_send(node)
          return unless (set_elements = set_init_elements(node))

          seen_elements = Set[]

          set_elements.each_with_index do |set_element, index|
            # NOTE: Skip due to the possibility of corner cases where Set elements
            # may have changing return values if they are not literals, constants, or variables.
            next if !set_element.literal? && !set_element.const_type? && !set_element.variable?

            if seen_elements.include?(set_element)
              register_offense(set_element, set_elements[index - 1])
            else
              seen_elements << set_element
            end
          end
        end
        alias on_csend on_send

        private

        def register_offense(current_element, prev_element)
          add_offense(current_element) do |corrector|
            range = prev_element.source_range.end.join(current_element.source_range.end)

            corrector.remove(range)
          end
        end
      end
    end
  end
end

Version data entries

5 entries across 5 versions & 1 rubygems

Version	Path
rubocop-1.69.2	lib/rubocop/cop/lint/duplicate_set_element.rb
rubocop-1.69.1	lib/rubocop/cop/lint/duplicate_set_element.rb
rubocop-1.69.0	lib/rubocop/cop/lint/duplicate_set_element.rb
rubocop-1.68.0	lib/rubocop/cop/lint/duplicate_set_element.rb
rubocop-1.67.0	lib/rubocop/cop/lint/duplicate_set_element.rb