Sha256: 6d1ac2b7e2be3fd1517513d395bda76b6e5d4b95cd862f2bf5e208c4e4a883e2
Contents?: true
Size: 1.32 KB
Versions: 14
Compression:
Stored size: 1.32 KB
Contents
# encoding: utf-8
require 'rails_best_practices/reviews/review'
module RailsBestPractices
module Reviews
# Review a controller file to make sure using simplified syntax for render.
#
# See the best practice details here http://rails-bestpractices.com/posts/62-simplify-render-in-controllers.
#
# Implementation:
#
# Review process:
# check all render method commands in controller files,
# if there is a key 'action', 'template' or 'file' in the argument,
# then they should be replaced by simplified syntax.
class SimplifyRenderInControllersReview < Review
interesting_nodes :command
interesting_files CONTROLLER_FILES
def url
"http://rails-bestpractices.com/posts/62-simplify-render-in-controllers"
end
# check command node in the controller file,
# if its message is render and the arguments contain a key action, template or file,
# then it should be replaced by simplified syntax.
def start_command(node)
if "render" == node.message.to_s
keys = node.arguments.all.first.hash_keys
if keys && keys.size == 1 &&
(keys.include?("action") || keys.include?("template") || keys.include?("file"))
add_error 'simplify render in controllers'
end
end
end
end
end
end
Version data entries
14 entries across 14 versions & 2 rubygems