Sha256: 6ab9dc168571e0e4984ae9a3c7c5d76df713631bbc1085f5fa7094628014a793
Contents?: true
Size: 1.39 KB
Versions: 6778
Compression:
Stored size: 1.39 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Security
# This cop checks for the use of JSON class methods which have potential
# security issues.
#
# Autocorrect is disabled by default because it's potentially dangerous.
# If using a stream, like `JSON.load(open('file'))`, it will need to call
# `#read` manually, like `JSON.parse(open('file').read)`.
# If reading single values (rather than proper JSON objects), like
# `JSON.load('false')`, it will need to pass the `quirks_mode: true`
# option, like `JSON.parse('false', quirks_mode: true)`.
# Other similar issues may apply.
#
# @example
# # bad
# JSON.load("{}")
# JSON.restore("{}")
#
# # good
# JSON.parse("{}")
#
class JSONLoad < Cop
MSG = 'Prefer `JSON.parse` over `JSON.%<method>s`.'.freeze
def_node_matcher :json_load, <<-PATTERN
(send (const {nil? cbase} :JSON) ${:load :restore} ...)
PATTERN
def on_send(node)
json_load(node) do |method|
add_offense(node,
location: :selector,
message: format(MSG, method: method))
end
end
def autocorrect(node)
->(corrector) { corrector.replace(node.loc.selector, 'parse') }
end
end
end
end
end
Version data entries
6,778 entries across 6,772 versions & 24 rubygems