Sha256: 69fc85c20532b9bb806b96c47ad26da999ce904cad6140931f887c8bf0c3794a
Contents?: true
Size: 1.38 KB
Versions: 30
Compression:
Stored size: 1.38 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Security
# This cop checks for the use of JSON class methods which have potential
# security issues.
#
# Autocorrect is disabled by default because it's potentially dangerous.
# If using a stream, like `JSON.load(open('file'))`, it will need to call
# `#read` manually, like `JSON.parse(open('file').read)`.
# If reading single values (rather than proper JSON objects), like
# `JSON.load('false')`, it will need to pass the `quirks_mode: true`
# option, like `JSON.parse('false', quirks_mode: true)`.
# Other similar issues may apply.
#
# @example
# # bad
# JSON.load("{}")
# JSON.restore("{}")
#
# # good
# JSON.parse("{}")
#
class JSONLoad < Base
extend AutoCorrector
MSG = 'Prefer `JSON.parse` over `JSON.%<method>s`.'
RESTRICT_ON_SEND = %i[load restore].freeze
def_node_matcher :json_load, <<~PATTERN
(send (const {nil? cbase} :JSON) ${:load :restore} ...)
PATTERN
def on_send(node)
json_load(node) do |method|
add_offense(node.loc.selector, message: format(MSG, method: method)) do |corrector|
corrector.replace(node.loc.selector, 'parse')
end
end
end
end
end
end
end
Version data entries
30 entries across 30 versions & 2 rubygems