Sha256: 68ca9f4fd0aef066f4449e992d21f70bd32895c28d88171687eeb8912a9337ed
Contents?: true
Size: 1.2 KB
Versions: 6
Compression:
Stored size: 1.2 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Minitest
# This cop tries to detect when a user accidentally used
# `assert` when they meant to use `assert_equal`.
#
# It is marked as unsafe because it is not possible to determine
# whether the second argument of `assert` is a message or not.
#
# @example
# # bad
# assert(3, my_list.length)
# assert(expected, actual)
#
# # good
# assert_equal(3, my_list.length)
# assert_equal(expected, actual)
# assert(foo, 'message')
#
class AssertWithExpectedArgument < Base
MSG = 'Did you mean to use `assert_equal(%<arguments>s)`?'
RESTRICT_ON_SEND = %i[assert].freeze
def_node_matcher :assert_with_two_arguments?, <<~PATTERN
(send nil? :assert $_ $_)
PATTERN
def on_send(node)
assert_with_two_arguments?(node) do |_expected, message|
return if message.str_type? || message.dstr_type?
arguments = node.arguments.map(&:source).join(', ')
add_offense(node, message: format(MSG, arguments: arguments))
end
end
end
end
end
end
Version data entries
6 entries across 6 versions & 1 rubygems