Sha256: 6837eaf0a919693fa9f1d01d7a9aaec5fc2c142b1190d2a435d98d31bdbabfe5

Contents?: true

Size: 1.05 KB

Versions: 6791

Compression:

Stored size: 1.05 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Style
      # If the `else` branch of a conditional consists solely of an `if` node,
      # it can be combined with the `else` to become an `elsif`.
      # This helps to keep the nesting level from getting too deep.
      #
      # @example
      #   # bad
      #   if condition_a
      #     action_a
      #   else
      #     if condition_b
      #       action_b
      #     else
      #       action_c
      #     end
      #   end
      #
      #   # good
      #   if condition_a
      #     action_a
      #   elsif condition_b
      #     action_b
      #   else
      #     action_c
      #   end
      class IfInsideElse < Cop
        MSG = 'Convert `if` nested inside `else` to `elsif`.'.freeze

        def on_if(node)
          return if node.ternary? || node.unless?

          else_branch = node.else_branch

          return unless else_branch && else_branch.if_type? && else_branch.if?

          add_offense(else_branch, location: :keyword)
        end
      end
    end
  end
end

Version data entries

6,791 entries across 6,785 versions & 25 rubygems

Version Path
rubocop-0.67.1 lib/rubocop/cop/style/if_inside_else.rb
rubocop-0.67.0 lib/rubocop/cop/style/if_inside_else.rb
rubocop-0.66.0 lib/rubocop/cop/style/if_inside_else.rb
rubocop-0.65.0 lib/rubocop/cop/style/if_inside_else.rb
rubocop-0.64.0 lib/rubocop/cop/style/if_inside_else.rb
rubocop-0.63.1 lib/rubocop/cop/style/if_inside_else.rb
rubocop-0.63.0 lib/rubocop/cop/style/if_inside_else.rb
rubocop-0.62.0 lib/rubocop/cop/style/if_inside_else.rb
rubocop-0.61.1 lib/rubocop/cop/style/if_inside_else.rb
rubocop-0.61.0 lib/rubocop/cop/style/if_inside_else.rb
config_gems_initialization_aim-0.1.4 vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/style/if_inside_else.rb
config_gems_initialization_aim-0.1.4 vendor/bundle/ruby/2.5.0/gems/config_gems_initialization_aim-0.1.1/vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/style/if_inside_else.rb
config_gems_initialization_aim-0.1.3 vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/style/if_inside_else.rb
config_gems_initialization_aim-0.1.3 vendor/bundle/ruby/2.5.0/gems/config_gems_initialization_aim-0.1.1/vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/style/if_inside_else.rb
rubocop-0.60.0 lib/rubocop/cop/style/if_inside_else.rb
rubocop-0.59.2 lib/rubocop/cop/style/if_inside_else.rb
rubocop-0.59.1 lib/rubocop/cop/style/if_inside_else.rb
rubocop-0.59.0 lib/rubocop/cop/style/if_inside_else.rb
rubocop-0.58.2 lib/rubocop/cop/style/if_inside_else.rb
rubocop-0.58.1 lib/rubocop/cop/style/if_inside_else.rb