Sha256: 6709c717b8c4c87eafffaa9784c14ea182d78c86b304c3b2ff5a9cd84a26a0ba
Contents?: true
Size: 1.26 KB
Versions: 47
Compression:
Stored size: 1.26 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Ezcater
# Enforce use of HTTP status code matchers rather than asserting on on random numbers.
#
# @example
#
# # good
# expect(response).to have_http_status :created
# expect(response).to have_http_status :bad_request
#
# # bad
# expect(response.code).to eq 201
# expect(response.code).to eq 400
class RspecRequireHttpStatusMatcher < Cop
MSG = "Use the `have_http_status` matcher, like `expect(response).to have_http_status :bad_request`, "\
"rather than `%<node_source>s`"
def_node_matcher :response_status_assertion, <<~PATTERN
(send (send _ :expect (send (send _ :response) :status)) :to (send _ :eq (int _)))
PATTERN
def_node_matcher :response_code_assertion, <<~PATTERN
(send (send _ :expect (send (send _ :response) :code)) :to (send _ :eq (str _)))
PATTERN
def on_send(node)
return if !response_status_assertion(node) && !response_code_assertion(node)
add_offense(node,
location: :expression,
message: format(MSG, node_source: node.source))
end
end
end
end
end
Version data entries
47 entries across 47 versions & 1 rubygems