# frozen_string_literal: true module RuboCop module Cop module Style # Checks for uses of `if-else` and ternary operators with a negated condition # which can be simplified by inverting condition and swapping branches. # # @example # # bad # if !x # do_something # else # do_something_else # end # # # good # if x # do_something_else # else # do_something # end # # # bad # !x ? do_something : do_something_else # # # good # x ? do_something_else : do_something # class NegatedIfElseCondition < Base include RangeHelp extend AutoCorrector MSG = 'Invert the negated condition and swap the %s branches.' NEGATED_EQUALITY_METHODS = %i[!= !~].freeze # @!method double_negation?(node) def_node_matcher :double_negation?, '(send (send _ :!) :!)' def self.autocorrect_incompatible_with [Style::InverseMethods, Style::Not] end def on_new_investigation @corrected_nodes = nil end # rubocop:disable Metrics/AbcSize,Metrics/CyclomaticComplexity def on_if(node) return unless if_else?(node) return unless (condition = unwrap_begin_nodes(node.condition)) return if double_negation?(condition) || !negated_condition?(condition) return unless condition.arguments.size < 2 message = message(node) add_offense(node, message: message) do |corrector| unless corrected_ancestor?(node) correct_negated_condition(corrector, condition) swap_branches(corrector, node) @corrected_nodes ||= Set.new.compare_by_identity @corrected_nodes.add(node) end end end # rubocop:enable Metrics/AbcSize,Metrics/CyclomaticComplexity private def if_else?(node) else_branch = node.else_branch !node.elsif? && else_branch && (!else_branch.if_type? || !else_branch.elsif?) end def unwrap_begin_nodes(node) node = node.children.first while node && (node.begin_type? || node.kwbegin_type?) node end def negated_condition?(node) node.send_type? && (node.negation_method? || NEGATED_EQUALITY_METHODS.include?(node.method_name)) end def message(node) type = node.ternary? ? 'ternary' : 'if-else' format(MSG, type: type) end def corrected_ancestor?(node) node.each_ancestor(:if).any? { |ancestor| @corrected_nodes&.include?(ancestor) } end def correct_negated_condition(corrector, node) replacement = if node.negation_method? node.receiver.source else inverted_method = node.method_name.to_s.sub('!', '=') "#{node.receiver.source} #{inverted_method} #{node.first_argument.source}" end corrector.replace(node, replacement) end def swap_branches(corrector, node) if node.if_branch.nil? corrector.remove(range_by_whole_lines(node.loc.else, include_final_newline: true)) else corrector.swap(if_range(node), else_range(node)) end end # Collect the entire if branch, including whitespace and comments def if_range(node) if node.ternary? node.if_branch else range_between(node.condition.source_range.end_pos, node.loc.else.begin_pos) end end # Collect the entire else branch, including whitespace and comments def else_range(node) if node.ternary? node.else_branch else range_between(node.loc.else.end_pos, node.loc.end.begin_pos) end end end end end end