Sha256: 61185b894bfdab1b614671d1b43d366342e4feb7a51063711392f41de6deef84

Contents?: true

Size: 1.01 KB

Versions: 15

Compression:

Stored size: 1.01 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Lint
      # This cop checks for *rescue* blocks targeting the Exception class.
      #
      # @example
      #
      #   # bad
      #
      #   begin
      #     do_something
      #   rescue Exception
      #     handle_exception
      #   end
      #
      # @example
      #
      #   # good
      #
      #   begin
      #     do_something
      #   rescue ArgumentError
      #     handle_exception
      #   end
      class RescueException < Cop
        MSG = 'Avoid rescuing the `Exception` class. ' \
              'Perhaps you meant to rescue `StandardError`?'.freeze

        def on_resbody(node)
          return unless node.children.first
          rescue_args = node.children.first.children
          return unless rescue_args.any? { |a| targets_exception?(a) }

          add_offense(node)
        end

        def targets_exception?(rescue_arg_node)
          rescue_arg_node.const_name == 'Exception'
        end
      end
    end
  end
end

Version data entries

15 entries across 15 versions & 2 rubygems

Version Path
rubocop-0.58.2 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.58.1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.58.0 lib/rubocop/cop/lint/rescue_exception.rb
vagrant-packet-0.1.1 vendor/bundle/ruby/2.4.0/gems/rubocop-0.57.2/lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.57.2 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.57.1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.57.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.56.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.55.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.54.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.53.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.52.1 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.52.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.51.0 lib/rubocop/cop/lint/rescue_exception.rb
rubocop-0.50.0 lib/rubocop/cop/lint/rescue_exception.rb