Sha256: 5f346cb3a043be9888067424a5854fa3c61ec729dbd9d225156ee4346914eb39
Contents?: true
Size: 1.21 KB
Versions: 6831
Compression:
Stored size: 1.21 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Performance
# This cop identifies places where `sort_by { ... }` can be replaced by
# `sort`.
#
# @example
# # bad
# array.sort_by { |x| x }
# array.sort_by do |var|
# var
# end
#
# # good
# array.sort
class RedundantSortBy < Cop
include RangeHelp
MSG = 'Use `sort` instead of `sort_by { |%<var>s| %<var>s }`.'.freeze
def_node_matcher :redundant_sort_by, <<-PATTERN
(block $(send _ :sort_by) (args (arg $_x)) (lvar _x))
PATTERN
def on_block(node)
redundant_sort_by(node) do |send, var_name|
range = sort_by_range(send, node)
add_offense(node,
location: range,
message: format(MSG, var: var_name))
end
end
def autocorrect(node)
send, = *node
->(corrector) { corrector.replace(sort_by_range(send, node), 'sort') }
end
private
def sort_by_range(send, node)
range_between(send.loc.selector.begin_pos, node.loc.end.end_pos)
end
end
end
end
end
Version data entries
6,831 entries across 6,825 versions & 27 rubygems