Sha256: 5dcdca85a63cee202451ab5feff406d9e5744179cb547a8e185bb82caff9adf6
Contents?: true
Size: 1.8 KB
Versions: 15
Compression:
Stored size: 1.8 KB
Contents
require 'spec_helper'
module RailsBestPractices
module Reviews
describe HashSyntaxReview do
let(:runner) { Core::Runner.new(reviews: HashSyntaxReview.new) }
it "should find 1.8 Hash with symbol" do
content =<<-EOF
class User < ActiveRecord::Base
CONST = { :foo => :bar }
end
EOF
runner.review('app/models/user.rb', content)
runner.should have(1).errors
runner.errors[0].to_s.should == "app/models/user.rb:2 - change Hash Syntax to 1.9"
end
it "should not find 1.8 Hash with string" do
content =<<-EOF
class User < ActiveRecord::Base
CONST = { "foo" => "bar" }
end
EOF
runner.review('app/models/user.rb', content)
runner.should have(0).errors
end
it "should not alert on 1.9 Syntax" do
content =<<-EOF
class User < ActiveRecord::Base
CONST = { foo: :bar }
end
EOF
runner.review('app/models/user.rb', content)
runner.should have(0).errors
end
it "should ignore haml_out" do
content =<<-EOF
%div{ class: "foo1" }
.div{ class: "foo2" }
#div{ class: "foo3" }
EOF
runner.review('app/views/files/show.html.haml', content)
runner.should have(0).errors
end
it "should not consider hash with array key" do
content =<<-EOF
transition [:unverified, :verified] => :deleted
EOF
runner.review('app/models/post.rb', content)
runner.should have(0).errors
end
it "should not consider hash with charaters not valid for symbol" do
content =<<-EOF
receiver.stub(:` => 'Error')
EOF
runner.review('app/models/post.rb', content)
runner.should have(0).errors
end
end
end
end
Version data entries
15 entries across 15 versions & 1 rubygems