Contents

# encoding: utf-8
# frozen_string_literal: true

module RuboCop
  module Cop
    module Style
      # This cop looks for *unless* expressions with *else* clauses.
      class UnlessElse < Cop
        MSG = 'Do not use `unless` with `else`. Rewrite these with the ' \
              'positive case first.'.freeze

        def on_if(node)
          loc = node.loc

          # discard ternary ops and modifier if/unless nodes
          return unless loc.respond_to?(:keyword) && loc.respond_to?(:else)
          return unless loc.keyword.is?('unless') && loc.else

          add_offense(node, :expression)
        end

        def autocorrect(node)
          condition, = *node
          body_range = range_between_condition_and_else(node, condition)
          else_range = range_between_else_and_end(node)

          lambda do |corrector|
            corrector.replace(node.loc.keyword, 'if'.freeze)
            corrector.replace(body_range, else_range.source)
            corrector.replace(else_range, body_range.source)
          end
        end

        def range_between_condition_and_else(node, condition)
          Parser::Source::Range.new(node.source_range.source_buffer,
                                    condition.source_range.end_pos,
                                    node.loc.else.begin_pos)
        end

        def range_between_else_and_end(node)
          Parser::Source::Range.new(node.source_range.source_buffer,
                                    node.loc.else.end_pos,
                                    node.loc.end.begin_pos)
        end
      end
    end
  end
end

Version data entries

5 entries across 5 versions & 1 rubygems

Version	Path
rubocop-0.41.1	lib/rubocop/cop/style/unless_else.rb
rubocop-0.41.0	lib/rubocop/cop/style/unless_else.rb
rubocop-0.40.0	lib/rubocop/cop/style/unless_else.rb
rubocop-0.39.0	lib/rubocop/cop/style/unless_else.rb
rubocop-0.38.0	lib/rubocop/cop/style/unless_else.rb