Contents

require 'rails_best_practices/checks/check'

module RailsBestPractices
  module Checks
    # Check a model to make sure finders are on their own model.
    #
    # Implementation: check if :find is called by other model.
    class KeepFindersOnTheirOwnModelCheck < Check
      
      def interesting_nodes
        [:call]
      end

      def interesting_files
        MODLE_FILES
      end

      def evaluate_start(node)
        add_error "keep finders on their own model" if others_finder?(node)
      end

      private

      def others_finder?(node)
        [:find, :all, :first, :last].include? node.message and node.subject.node_type == :call and node.arguments.size > 1
      end
    end
  end
end

Version data entries

8 entries across 8 versions & 1 rubygems

Version	Path
rails_best_practices-0.4.2	lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb
rails_best_practices-0.4.1	lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb
rails_best_practices-0.4.0	lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb
rails_best_practices-0.3.27	lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb
rails_best_practices-0.3.26	lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb
rails_best_practices-0.3.25	lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb
rails_best_practices-0.3.24	lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb
rails_best_practices-0.3.23	lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb