Sha256: 5aa4d6db6fdb1052ebad94b26bea97a9f7415b48765ad57d28403ed0b7ad40b5

Contents?: true

Size: 1.92 KB

Versions: 5

Compression:

Stored size: 1.92 KB

Contents

# frozen_string_literal: true
#
# Copyright:: 2022, Chef Software, Inc.
# Author:: Tim Smith (<tsmith@chef.io>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
  module Cop
    module Chef
      module Correctness
        # The resource to notify when calling `notifies` or `subscribes` must be a string.
        #
        # @example
        #
        #   #### incorrect
        #
        #   template '/etc/www/configures-apache.conf' do
        #     notifies :restart, service['apache'], :immediately
        #   end
        #
        #   template '/etc/www/configures-apache.conf' do
        #     notifies :restart, service[apache], :immediately
        #   end
        #
        #   #### correct
        #
        #   template '/etc/www/configures-apache.conf' do
        #     notifies :restart, 'service[apache]', :immediately
        #   end
        #
        class InvalidNotificationResource < Base
          MSG = 'The resource to notify when calling `notifies` or `subscribes` must be a string.'
          RESTRICT_ON_SEND = [:notifies, :subscribes].freeze

          def_node_matcher :invalid_notification?, <<-PATTERN
            (send nil? {:notifies :subscribes} (sym _) $(send (send nil? _) :[] ...) ...)
          PATTERN

          def on_send(node)
            invalid_notification?(node) do |resource|
              add_offense(resource, severity: :refactor)
            end
          end
        end
      end
    end
  end
end

Version data entries

5 entries across 5 versions & 1 rubygems

Version Path
cookstyle-7.31.3 lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb
cookstyle-7.31.1 lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb
cookstyle-7.31.0 lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb
cookstyle-7.30.4 lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb
cookstyle-7.30.3 lib/rubocop/cop/chef/correctness/invalid_notification_resource.rb