Sha256: 5a6e21337c322c4a6aebb62492d0ad379ef42a62d625212517eb5da17824428a
Contents?: true
Size: 1.48 KB
Versions: 9
Compression:
Stored size: 1.48 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module RSpec
module FactoryBot
# Use string value when setting the class attribute explicitly.
#
# This cop would promote faster tests by lazy-loading of
# application files. Also, this could help you suppress potential bugs
# in combination with external libraries by avoiding a preload of
# application files from the factory files.
#
# @example
# # bad
# factory :foo, class: Foo do
# end
#
# # good
# factory :foo, class: 'Foo' do
# end
class FactoryClassName < Base
extend AutoCorrector
MSG = "Pass '%<class_name>s' string instead of `%<class_name>s` " \
'constant.'
ALLOWED_CONSTANTS = %w[Hash OpenStruct].freeze
def_node_matcher :class_name, <<~PATTERN
(send _ :factory _ (hash <(pair (sym :class) $(const ...)) ...>))
PATTERN
def on_send(node)
class_name(node) do |cn|
next if allowed?(cn.const_name)
msg = format(MSG, class_name: cn.const_name)
add_offense(cn, message: msg) do |corrector|
corrector.replace(cn, "'#{cn.source}'")
end
end
end
private
def allowed?(const_name)
ALLOWED_CONSTANTS.include?(const_name)
end
end
end
end
end
end
Version data entries
9 entries across 9 versions & 1 rubygems