Sha256: 59e03e35a2e3fdda3bd20515d579d71a18dde0494bad6c6b007d082f497c2458
Contents?: true
Size: 1.84 KB
Versions: 25
Compression:
Stored size: 1.84 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Lint
# Checks for redundant `with_index`.
#
# @example
# # bad
# ary.each_with_index do |v|
# v
# end
#
# # good
# ary.each do |v|
# v
# end
#
# # bad
# ary.each.with_index do |v|
# v
# end
#
# # good
# ary.each do |v|
# v
# end
#
class RedundantWithIndex < Base
include RangeHelp
extend AutoCorrector
MSG_EACH_WITH_INDEX = 'Use `each` instead of `each_with_index`.'
MSG_WITH_INDEX = 'Remove redundant `with_index`.'
def on_block(node)
return unless (send = redundant_with_index?(node))
range = with_index_range(send)
add_offense(range, message: message(send)) do |corrector|
if send.method?(:each_with_index)
corrector.replace(send.loc.selector, 'each')
else
corrector.remove(range)
corrector.remove(send.loc.dot)
end
end
end
alias on_numblock on_block
private
# @!method redundant_with_index?(node)
def_node_matcher :redundant_with_index?, <<~PATTERN
{
(block
$(send _ {:each_with_index :with_index} ...)
(args (arg _)) ...)
(numblock
$(send _ {:each_with_index :with_index} ...) 1 ...)
}
PATTERN
def message(node)
if node.method?(:each_with_index)
MSG_EACH_WITH_INDEX
else
MSG_WITH_INDEX
end
end
def with_index_range(send)
range_between(send.loc.selector.begin_pos, send.loc.expression.end_pos)
end
end
end
end
end
Version data entries
25 entries across 23 versions & 4 rubygems