Sha256: 570616aaf7291505f62b60b43f450130d5f3bc161a0a99e77b9da86f3c94d5d5
Contents?: true
Size: 1.1 KB
Versions: 9
Compression:
Stored size: 1.1 KB
Contents
<!--- For the author to fill in --> Reviewers: ---------- <!--- Check yourself off the list after review --> - [ ] @mention What's the purpose of the PR? ----------------------------- <!--- Does it resolve an issue? Does it add a feature? Is it a refactor? --> <!--- Trello ticket links? Design document links?--> <!--- List out intended functionality. --> Description of changes ---------------------- <!--- What code was changed? Why? --> Notes to reviewers ------------------ <!--- Is there anything in particular you want reviewers to check for? --> <!--- For the reviewer --> Keep in mind while reviewing code: ---------------------------------- - Is relevant code tested? - Are added functions/methods documented? - Separation of concerns (SOC) - Don't repeat yourself (DRY) - Limit the number of positional arguments - Is function/method length reasonable? - Can code be broken down into smaller components? - Where do added functions/methods belong? - Are variable names descriptive? - Are errors handled appropriately? - Can logic be simplified? - Does the code make sense in context? (expand the diff)
Version data entries
9 entries across 9 versions & 1 rubygems