Contents

# encoding: utf-8

module RuboCop
  module Cop
    module Style
      # This cop checks for braces in method calls with hash parameters.
      class BracesAroundHashParameters < Cop
        include ConfigurableEnforcedStyle

        def on_send(node)
          _receiver, method_name, *args = *node

          # Discard attr writer methods.
          return if method_name.to_s.end_with?('=')
          # Discard operator methods.
          return if operator?(method_name)

          # We care only for the last argument.
          arg = args.last

          check(arg, args) if non_empty_hash?(arg)
        end

        private

        def check(arg, args)
          if style == :no_braces
            if !braces?(arg) || all_hashes?(args)
              correct_style_detected
            else
              offense(arg, 'Redundant curly braces around a hash parameter.')
            end
          elsif braces?(arg)
            correct_style_detected
          else
            offense(arg, 'Missing curly braces around a hash parameter.')
          end
        end

        def offense(arg, msg)
          add_offense(arg, :expression, msg) { opposite_style_detected }
        end

        def autocorrect(node)
          @corrections << lambda do |corrector|
            if style == :no_braces
              corrector.remove(node.loc.begin)
              corrector.remove(node.loc.end)
            elsif style == :braces
              corrector.insert_before(node.loc.expression, '{')
              corrector.insert_after(node.loc.expression, '}')
            end
          end
        end

        def non_empty_hash?(arg)
          arg && arg.type == :hash && arg.children.any?
        end

        def braces?(arg)
          arg.loc.begin
        end

        def all_hashes?(args)
          args.length > 1 && args.all? { |a| a.type == :hash }
        end
      end
    end
  end
end

Version data entries

2 entries across 2 versions & 1 rubygems

Version	Path
rubocop-0.27.1	lib/rubocop/cop/style/braces_around_hash_parameters.rb
rubocop-0.27.0	lib/rubocop/cop/style/braces_around_hash_parameters.rb