Sha256: 55fe67aef4a696998c4fa2bfacd52a6c29cf60a2f83f44af2655032b8f0dbd1e
Contents?: true
Size: 1.84 KB
Versions: 7
Compression:
Stored size: 1.84 KB
Contents
# frozen_string_literal: true
require 'spec_helper'
module RailsBestPractices
module Reviews
describe MoveCodeIntoControllerReview do
let(:runner) { Core::Runner.new(reviews: described_class.new) }
it 'moves code into controller for method call' do
content = <<-EOF
<% Post.find(:all).each do |post| %>
<%=h post.title %>
<%=h post.content %>
<% end %>
EOF
runner.review('app/views/posts/index.html.erb', content)
expect(runner.errors.size).to eq(1)
expect(runner.errors[0].to_s).to eq('app/views/posts/index.html.erb:1 - move code into controller')
end
it 'moves code into controller for assign' do
content = <<-EOF
<% @posts = Post.all %>
<% @posts.each do |post| %>
<%=h post.title %>
<%=h post.content %>
<% end %>
EOF
runner.review('app/views/posts/index.html.erb', content)
expect(runner.errors.size).to eq(1)
expect(runner.errors[0].to_s).to eq('app/views/posts/index.html.erb:1 - move code into controller')
end
it 'does not move code into controller' do
content = <<-EOF
<% @posts.each do |post| %>
<%=h post.title %>
<%=h post.content %>
<% end %>
EOF
runner.review('app/views/posts/index.html.erb', content)
expect(runner.errors.size).to eq(0)
end
it 'does not check ignored files' do
runner = Core::Runner.new(reviews: described_class.new(ignored_files: %r{app/views/post}))
content = <<-EOF
<% Post.find(:all).each do |post| %>
<%=h post.title %>
<%=h post.content %>
<% end %>
EOF
runner.review('app/views/posts/index.html.erb', content)
expect(runner.errors.size).to eq(0)
end
end
end
end
Version data entries
7 entries across 7 versions & 1 rubygems