module SCSSLint # Checks for unnecessary uses of the parent reference (&) in nested selectors. class Linter::UnnecessaryParentReference < Linter include LinterRegistry MESSAGE = 'Unnecessary parent selector (&)' def visit_comma_sequence(comma_sequence) @multiple_sequences = comma_sequence.members.size > 1 end def visit_sequence(sequence) return unless sequence_starts_with_parent?(sequence.members.first) # Allow sequences that contain multiple parent references, e.g. # element { # & + & { ... } # } return if sequence.members[1..-1].any? { |ss| sequence_starts_with_parent?(ss) } # Special case: allow an isolated parent to appear if it is part of a # comma sequence of more than one sequence, as this could be used to DRY # up code. return if @multiple_sequences && isolated_parent?(sequence) add_lint(sequence.members.first.line, MESSAGE) end private def isolated_parent?(sequence) sequence.members.size == 1 && sequence_starts_with_parent?(sequence.members.first) end def sequence_starts_with_parent?(simple_sequence) return unless simple_sequence.is_a?(Sass::Selector::SimpleSequence) first = simple_sequence.members.first simple_sequence.members.size == 1 && first.is_a?(Sass::Selector::Parent) && first.suffix.empty? # Ignore concatenated selectors, like `&-something` end end end