Sha256: 53cba5a03d3aea095f97b35e43264a6d57d5ef3432e1fce79f40223159542b09

Contents?: true

Size: 1.64 KB

Versions: 13

Compression:

Stored size: 1.64 KB

Contents

# frozen_string_literal: true
#
# Copyright:: Copyright 2019, Chef Software Inc.
# Author:: Tim Smith (<tsmith@chef.io>)
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
  module Cop
    module Chef
      module ChefCorrectness
        # Chef Infra Client uses properties in several resources to track state. These
        # should not be set in recipes as they break the internal workings of the Chef
        # Infra Client
        #
        # @example
        #
        #   # bad
        #   service 'foo' do
        #     running true
        #     action [:start, :enable]
        #   end
        #
        #   # good
        #   service 'foo' do
        #     action [:start, :enable]
        #   end
        #
        class ResourceSetsInternalProperties < Base
          include RuboCop::Chef::CookbookHelpers

          MSG = 'Do not set properties used internally by Chef Infra Client to track the system state.'

          def on_block(node)
            match_property_in_resource?(:service, 'running', node) do |prop|
              add_offense(prop, message: MSG, severity: :refactor)
            end
          end
        end
      end
    end
  end
end

Version data entries

13 entries across 13 versions & 1 rubygems

Version Path
cookstyle-6.21.1 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.20.2 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.20.1 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.19.11 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.19.5 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.18.8 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.17.7 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.17.6 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.17.5 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.16.10 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.16.9 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.16.7 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb
cookstyle-6.16.4 lib/rubocop/cop/chef/correctness/resource_sets_internal_properties.rb