Contents

module RuboCop
  module Cop
    module RSpec
      # Checks for a specified error in checking raised errors.
      #
      # Enforces one of an Exception type, a string, or a regular
      # expression to match against the exception message as a parameter
      # to `raise_error`
      #
      # @example
      #
      #     # bad
      #     expect {
      #       raise StandardError.new('error')
      #     }.to raise_error
      #
      #     # good
      #     expect {
      #       raise StandardError.new('error')
      #     }.to raise_error(StandardError)
      #
      #     expect {
      #       raise StandardError.new('error')
      #     }.to raise_error('error')
      #
      #     expect {
      #       raise StandardError.new('error')
      #     }.to raise_error(/err/)
      #
      #     expect { do_something }.not_to raise_error
      class UnspecifiedException < Cop
        MSG = 'Specify the exception being captured'.freeze

        def_node_matcher :empty_raise_error_or_exception, <<-PATTERN.freeze
          (send
            (block
                (send nil? :expect) ...)
            :to
            (send nil? {:raise_error :raise_exception})
          )
        PATTERN

        def on_send(node)
          return unless empty_exception_matcher?(node)

          add_offense(
            node.children.last,
            location: :expression
          )
        end

        def empty_exception_matcher?(node)
          empty_raise_error_or_exception(node) && !block_with_args?(node.parent)
        end

        def block_with_args?(node)
          return unless node && node.block_type?

          node.arguments?
        end
      end
    end
  end
end

Version data entries

4 entries across 4 versions & 1 rubygems

Version	Path
rubocop-rspec-1.32.0	lib/rubocop/cop/rspec/unspecified_exception.rb
rubocop-rspec-1.31.0	lib/rubocop/cop/rspec/unspecified_exception.rb
rubocop-rspec-1.30.1	lib/rubocop/cop/rspec/unspecified_exception.rb
rubocop-rspec-1.30.0	lib/rubocop/cop/rspec/unspecified_exception.rb