Sha256: 4e227a9e384bd2398827826f78a6703228eab74c658a1fa8db0be0b7e642a8ec
Contents?: true
Size: 1.36 KB
Versions: 38
Compression:
Stored size: 1.36 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Style
# This cop checks for methods called on a do...end block. The point of
# this check is that it's easy to miss the call tacked on to the block
# when reading code.
#
# @example
# # bad
# a do
# b
# end.c
#
# # good
# a { b }.c
#
# # good
# foo = a do
# b
# end
# foo.c
class MethodCalledOnDoEndBlock < Base
include RangeHelp
MSG = 'Avoid chaining a method call on a do...end block.'
def on_block(node)
# If the method that is chained on the do...end block is itself a
# method with a block, we allow it. It's pretty safe to assume that
# these calls are not missed by anyone reading code. We also want to
# avoid double reporting of offenses checked by the
# MultilineBlockChain cop.
ignore_node(node.send_node)
end
def on_send(node)
return if ignored_node?(node)
receiver = node.receiver
return unless receiver&.block_type? && receiver.loc.end.is?('end')
range = range_between(receiver.loc.end.begin_pos, node.source_range.end_pos)
add_offense(range)
end
alias on_csend on_send
end
end
end
end
Version data entries
38 entries across 38 versions & 6 rubygems