Sha256: 4863c74c3edcd93f5f779839b4f8ed2abd8a5d4bbde7ab17d29dad78c0529653

Contents?: true

Size: 1.28 KB

Versions: 24

Compression:

Stored size: 1.28 KB

Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Style
      # This cop checks for methods called on a do...end block. The point of
      # this check is that it's easy to miss the call tacked on to the block
      # when reading code.
      #
      # @example
      #
      #   a do
      #     b
      #   end.c
      class MethodCalledOnDoEndBlock < Cop
        include RangeHelp

        MSG = 'Avoid chaining a method call on a do...end block.'.freeze

        def on_block(node)
          # If the method that is chained on the do...end block is itself a
          # method with a block, we allow it. It's pretty safe to assume that
          # these calls are not missed by anyone reading code. We also want to
          # avoid double reporting of offenses checked by the
          # MultilineBlockChain cop.
          ignore_node(node.send_node)
        end

        def on_send(node)
          return if ignored_node?(node)

          receiver = node.receiver

          return unless receiver && receiver.block_type? &&
                        receiver.loc.end.is?('end')

          range = range_between(receiver.loc.end.begin_pos,
                                node.source_range.end_pos)

          add_offense(nil, location: range)
        end
      end
    end
  end
end

Version data entries

24 entries across 22 versions & 3 rubygems

Version Path
rubocop-0.63.1 lib/rubocop/cop/style/method_called_on_do_end_block.rb
rubocop-0.63.0 lib/rubocop/cop/style/method_called_on_do_end_block.rb
rubocop-0.62.0 lib/rubocop/cop/style/method_called_on_do_end_block.rb
rubocop-0.61.1 lib/rubocop/cop/style/method_called_on_do_end_block.rb
rubocop-0.61.0 lib/rubocop/cop/style/method_called_on_do_end_block.rb
config_gems_initialization_aim-0.1.4 vendor/bundle/ruby/2.5.0/gems/config_gems_initialization_aim-0.1.1/vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/style/method_called_on_do_end_block.rb
config_gems_initialization_aim-0.1.4 vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/style/method_called_on_do_end_block.rb
config_gems_initialization_aim-0.1.3 vendor/bundle/ruby/2.5.0/gems/config_gems_initialization_aim-0.1.1/vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/style/method_called_on_do_end_block.rb
config_gems_initialization_aim-0.1.3 vendor/bundle/ruby/2.5.0/gems/rubocop-0.60.0/lib/rubocop/cop/style/method_called_on_do_end_block.rb
rubocop-0.60.0 lib/rubocop/cop/style/method_called_on_do_end_block.rb
rubocop-0.59.2 lib/rubocop/cop/style/method_called_on_do_end_block.rb
rubocop-0.59.1 lib/rubocop/cop/style/method_called_on_do_end_block.rb
rubocop-0.59.0 lib/rubocop/cop/style/method_called_on_do_end_block.rb
rubocop-0.58.2 lib/rubocop/cop/style/method_called_on_do_end_block.rb
rubocop-0.58.1 lib/rubocop/cop/style/method_called_on_do_end_block.rb
rubocop-0.58.0 lib/rubocop/cop/style/method_called_on_do_end_block.rb
vagrant-packet-0.1.1 vendor/bundle/ruby/2.4.0/gems/rubocop-0.57.2/lib/rubocop/cop/style/method_called_on_do_end_block.rb
rubocop-0.57.2 lib/rubocop/cop/style/method_called_on_do_end_block.rb
rubocop-0.57.1 lib/rubocop/cop/style/method_called_on_do_end_block.rb
rubocop-0.57.0 lib/rubocop/cop/style/method_called_on_do_end_block.rb