Contents

# frozen_string_literal: true

module RuboCop
  module Cop
    module Style
      # This cop checks for comments put on the same line as some keywords.
      # These keywords are: `begin`, `class`, `def`, `end`, `module`.
      #
      # Note that some comments
      # (`:nodoc:`, `:yields:`, `rubocop:disable` and `rubocop:todo`)
      # are allowed.
      #
      # @example
      #   # bad
      #   if condition
      #     statement
      #   end # end if
      #
      #   # bad
      #   class X # comment
      #     statement
      #   end
      #
      #   # bad
      #   def x; end # comment
      #
      #   # good
      #   if condition
      #     statement
      #   end
      #
      #   # good
      #   class X # :nodoc:
      #     y
      #   end
      class CommentedKeyword < Base
        MSG = 'Do not place comments on the same line as the ' \
              '`%<keyword>s` keyword.'

        def on_new_investigation
          processed_source.comments.each do |comment|
            next unless (match = line(comment).match(/(?<keyword>\S+).*#/))

            if offensive?(comment)
              add_offense(comment, message: format(MSG, keyword: match[:keyword]))
            end
          end
        end

        private

        KEYWORDS = %w[begin class def end module].freeze
        KEYWORD_REGEXES = KEYWORDS.map { |w| /^\s*#{w}\s/ }.freeze

        ALLOWED_COMMENTS = %w[
          :nodoc:
          :yields:
          rubocop:disable
          rubocop:todo
        ].freeze
        ALLOWED_COMMENT_REGEXES = ALLOWED_COMMENTS.map { |c| /#\s*#{c}/ }.freeze

        def offensive?(comment)
          line = line(comment)
          KEYWORD_REGEXES.any? { |r| r.match?(line) } &&
            ALLOWED_COMMENT_REGEXES.none? { |r| r.match?(line) }
        end

        def line(comment)
          comment.location.expression.source_line
        end
      end
    end
  end
end

Version data entries

23 entries across 23 versions & 2 rubygems

Version	Path
rubocop-0.93.0	lib/rubocop/cop/style/commented_keyword.rb
rubocop-0.92.0	lib/rubocop/cop/style/commented_keyword.rb
rubocop-0.91.1	lib/rubocop/cop/style/commented_keyword.rb