Sha256: 45cc4cb7bfe428f9d02e47cbb8b4ca8513869495e0d67d6e62624db487bbee7d

Contents?: true

Size: 1.81 KB

Versions: 6

Compression:

Stored size: 1.81 KB

Contents

# frozen_string_literal: true
#
# Copyright:: Copyright 2019, Chef Software Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
module RuboCop
  module Cop
    module Chef
      module ChefDeprecations
        # The `node.set` method has been removed in Chef Infra Client 13 and usage must be replaced with `node.normal`.
        #
        # This cop will autocorrect code to use node.normal, which is functionally identical to node.set, but we also discourage the use of that method as normal level attributes persist on the node even if the code setting the attribute is later removed.
        #
        # @example
        #
        #   # bad
        #   node.set['foo'] = true
        #
        #   # good
        #   node.normal['foo'] = true
        #
        class NodeSet < Cop
          MSG = 'Do not use node.set. Replace with node.normal to keep identical behavior.'

          def_node_matcher :node_set?, <<-PATTERN
            (send (send _ :node) $:set)
          PATTERN

          def on_send(node)
            node_set?(node) do
              add_offense(node, location: :selector, message: MSG, severity: :warning)
            end
          end

          def autocorrect(node)
            lambda do |corrector|
              corrector.replace(node.loc.selector, 'normal')
            end
          end
        end
      end
    end
  end
end

Version data entries

6 entries across 6 versions & 1 rubygems

Version Path
cookstyle-6.15.9 lib/rubocop/cop/chef/deprecation/node_set.rb
cookstyle-6.15.5 lib/rubocop/cop/chef/deprecation/node_set.rb
cookstyle-6.15.3 lib/rubocop/cop/chef/deprecation/node_set.rb
cookstyle-6.14.7 lib/rubocop/cop/chef/deprecation/node_set.rb
cookstyle-6.13.3 lib/rubocop/cop/chef/deprecation/node_set.rb
cookstyle-6.12.6 lib/rubocop/cop/chef/deprecation/node_set.rb