Contents

require 'spec_helper'

describe RailsBestPractices::Reviews::SimplifyRenderInControllersReview do
  let(:runner) { RailsBestPractices::Core::Runner.new(:reviews => RailsBestPractices::Reviews::SimplifyRenderInControllersReview.new) }

  it "should simplify render action view" do
    content =<<-EOF
    def edit
      render :action => :edit
    end
    EOF
    runner.review("app/controllers/posts_controller.rb", content)
    runner.should have(1).errors
    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - simplify render in controllers"
  end

  it "should simplify render actions's template" do
    content =<<-EOF
    def edit
      render :template => 'books/edit'
    end
    EOF
    runner.review("app/controllers/posts_controller.rb", content)
    runner.should have(1).errors
    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - simplify render in controllers"
  end

  it "should simplify render an arbitrary file" do
    content =<<-EOF
    def edit
      render :file => '/path/to/rails/app/views/books/edit'
    end
    EOF
    runner.review("app/controllers/posts_controller.rb", content)
    runner.should have(1).errors
    runner.errors[0].to_s.should == "app/controllers/posts_controller.rb:3 - simplify render in controllers"
  end

  it "should not simplify render action view" do
    content =<<-EOF
    render :edit
    EOF
    runner.review("app/controllers/posts_controller", content)
    runner.should have(0).errors
  end

  it "should not simplify render actions's template" do
    content =<<-EOF
    def edit
      render 'books/edit'
    end
    EOF
    runner.review("app/controllers/posts_controller.rb", content)
    runner.should have(0).errors
  end

  it "should not simplify render an arbitrary file" do
    content =<<-EOF
    def edit
      render '/path/to/rails/app/views/books/edit'
    end
    EOF
    runner.review("app/controllers/posts_controller.rb", content)
    runner.should have(0).errors
  end
end

Version data entries

7 entries across 7 versions & 2 rubygems

Version	Path
rails_best_practices-0.10.1	spec/rails_best_practices/reviews/simplify_render_in_controllers_review_spec.rb
rails_best_practices-0.10.0	spec/rails_best_practices/reviews/simplify_render_in_controllers_review_spec.rb
rails_best_practices-raydog153-0.9.1	spec/rails_best_practices/reviews/simplify_render_in_controllers_review_spec.rb
rails_best_practices-0.9.0	spec/rails_best_practices/reviews/simplify_render_in_controllers_review_spec.rb
rails_best_practices-0.8.2	spec/rails_best_practices/reviews/simplify_render_in_controllers_review_spec.rb
rails_best_practices-0.8.1	spec/rails_best_practices/reviews/simplify_render_in_controllers_review_spec.rb
rails_best_practices-0.8.0	spec/rails_best_practices/reviews/simplify_render_in_controllers_review_spec.rb