#! /usr/bin/env ruby
require 'spec_helper'

provider_class = Puppet::Type.type(:package).provider(:rpm)

describe provider_class do

  let (:packages) do
    <<-RPM_OUTPUT
    'cracklib-dicts 0 2.8.9 3.3 x86_64
    basesystem 0 8.0 5.1.1.el5.centos noarch
    chkconfig 0 1.3.30.2 2.el5 x86_64
    myresource 0 1.2.3.4 5.el4 noarch
    mysummaryless 0 1.2.3.4 5.el4 noarch
    tomcat 1 1.2.3.4 5.el4 x86_64
    '
    RPM_OUTPUT
  end

  let(:resource_name) { 'myresource' }
  let(:resource) do
    Puppet::Type.type(:package).new(
      :name     => resource_name,
      :ensure   => :installed,
      :provider => 'rpm'
    )
  end

  let(:provider) do
    provider = provider_class.new
    provider.resource = resource
    provider
  end

  let(:nevra_format) { %Q{%{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH}\\n} }
  let(:execute_options) do
    {:failonfail => true, :combine => true, :custom_environment => {}}
  end
  let(:rpm_version) { "RPM version 5.0.0\n" }

  before(:each) do
    Puppet::Util.stubs(:which).with("rpm").returns("/bin/rpm")
    provider_class.stubs(:which).with("rpm").returns("/bin/rpm")
    provider_class.instance_variable_set("@current_version", nil)
    Puppet::Type::Package::ProviderRpm.expects(:execute).with(["/bin/rpm", "--version"]).returns(rpm_version).at_most_once
    Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", "--version"], execute_options).returns(rpm_version).at_most_once
  end

  describe 'provider features' do
    it { is_expected.to be_versionable }
    it { is_expected.to be_install_options }
    it { is_expected.to be_uninstall_options }
    it { is_expected.to be_virtual_packages }
  end

  describe "self.instances" do
    describe "with a modern version of RPM" do
      it "includes all the modern flags" do
        Puppet::Util::Execution.expects(:execpipe).with("/bin/rpm -qa --nosignature --nodigest --qf '#{nevra_format}'").yields(packages)

        installed_packages = provider_class.instances
      end
    end

    describe "with a version of RPM < 4.1" do
      let(:rpm_version) { "RPM version 4.0.2\n" }
      it "excludes the --nosignature flag" do
        Puppet::Util::Execution.expects(:execpipe).with("/bin/rpm -qa  --nodigest --qf '#{nevra_format}'").yields(packages)

        installed_packages = provider_class.instances
      end
    end

    describe "with a version of RPM < 4.0.2" do
      let(:rpm_version) { "RPM version 3.0.5\n" }
      it "excludes the --nodigest flag" do
        Puppet::Util::Execution.expects(:execpipe).with("/bin/rpm -qa   --qf '#{nevra_format}'").yields(packages)

        installed_packages = provider_class.instances
      end
    end

    it "returns an array of packages" do
      Puppet::Util::Execution.expects(:execpipe).with("/bin/rpm -qa --nosignature --nodigest --qf '#{nevra_format}'").yields(packages)

      installed_packages = provider_class.instances

      expect(installed_packages[0].properties).to eq(
        {
          :provider => :rpm,
          :name => "cracklib-dicts",
          :epoch => "0",
          :version => "2.8.9",
          :release => "3.3",
          :arch => "x86_64",
          :ensure => "2.8.9-3.3",
        }
      )
      expect(installed_packages[1].properties).to eq(
        {
          :provider => :rpm,
          :name => "basesystem",
          :epoch => "0",
          :version => "8.0",
          :release => "5.1.1.el5.centos",
          :arch => "noarch",
          :ensure => "8.0-5.1.1.el5.centos",
        }
      )
      expect(installed_packages[2].properties).to eq(
        {
          :provider => :rpm,
          :name => "chkconfig",
          :epoch => "0",
          :version => "1.3.30.2",
          :release => "2.el5",
          :arch => "x86_64",
          :ensure => "1.3.30.2-2.el5",
        }
      )
      expect(installed_packages[3].properties).to eq(
        {
          :provider => :rpm,
          :name => "myresource",
          :epoch => "0",
          :version => "1.2.3.4",
          :release => "5.el4",
          :arch => "noarch",
          :ensure => "1.2.3.4-5.el4",
        }
      )
      expect(installed_packages[4].properties).to eq(
        {
          :provider    => :rpm,
          :name        => "mysummaryless",
          :epoch       => "0",
          :version     => "1.2.3.4",
          :release     => "5.el4",
          :arch        => "noarch",
          :ensure      => "1.2.3.4-5.el4",
        }
      )
      expect(installed_packages[5].properties).to eq(
        {
          :provider    => :rpm,
          :name        => "tomcat",
          :epoch       => "1",
          :version     => "1.2.3.4",
          :release     => "5.el4",
          :arch        => "x86_64",
          :ensure      => "1:1.2.3.4-5.el4",
        }
      )
    end
  end

  describe "#install" do
    let(:resource) do
      Puppet::Type.type(:package).new(
        :name     => 'myresource',
        :ensure   => :installed,
        :source   => '/path/to/package'
      )
    end

    describe "when not already installed" do
      it "only includes the '-i' flag" do
        Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", ["-i"], '/path/to/package'], execute_options)
        provider.install
      end
    end

    describe "when installed with options" do
      let(:resource) do
        Puppet::Type.type(:package).new(
          :name            => resource_name,
          :ensure          => :installed,
          :provider        => 'rpm',
          :source          => '/path/to/package',
          :install_options => ['-D', {'--test' => 'value'}, '-Q']
        )
      end

      it "includes the options" do
        Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", ["-i", "-D", "--test=value", "-Q"], '/path/to/package'], execute_options)
        provider.install
      end
    end

    describe "when an older version is installed" do
      before(:each) do
        # Force the provider to think a version of the package is already installed
        # This is real hacky. I'm sorry.  --jeffweiss 25 Jan 2013
        provider.instance_variable_get('@property_hash')[:ensure] = '1.2.3.3'
      end

      it "includes the '-U --oldpackage' flags" do
         Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", ["-U", "--oldpackage"], '/path/to/package'], execute_options)
         provider.install
      end
    end
  end

  describe "#latest" do
    it "retrieves version string after querying rpm for version from source file" do
      resource.expects(:[]).with(:source).returns('source-string')
      Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", "-q", "--qf", "'#{nevra_format}'", "-p", "source-string"]).returns("myresource 0 1.2.3.4 5.el4 noarch\n")
      expect(provider.latest).to eq("1.2.3.4-5.el4")
    end

    it "raises an error if the rpm command fails" do
      resource.expects(:[]).with(:source).returns('source-string')
      Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", "-q", "--qf", "'#{nevra_format}'", "-p", "source-string"]).raises(Puppet::ExecutionFailure, 'rpm command failed')

      expect {
        provider.latest
      }.to raise_error(Puppet::Error, 'rpm command failed')
    end
  end

  describe "#uninstall" do
    let(:resource) do
      Puppet::Type.type(:package).new(
        :name     => 'myresource',
        :ensure   => :installed
      )
    end

    describe "on a modern RPM" do
      before(:each) do
        Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", "-q", "myresource", '--nosignature', '--nodigest', "--qf", "'#{nevra_format}'"], execute_options).returns("myresource 0 1.2.3.4 5.el4 noarch\n")
      end

      let(:rpm_version) { "RPM version 4.10.0\n" }

      it "includes the architecture in the package name" do
        Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", ["-e"], 'myresource-1.2.3.4-5.el4.noarch'], execute_options).returns('').at_most_once
        provider.uninstall
      end
    end

    describe "on an ancient RPM" do
      before(:each) do
        Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", "-q", "myresource", '', '', '--qf', "'#{nevra_format}'"], execute_options).returns("myresource 0 1.2.3.4 5.el4 noarch\n")
      end

      let(:rpm_version) { "RPM version 3.0.6\n" }

      it "excludes the architecture from the package name" do
        Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", ["-e"], 'myresource-1.2.3.4-5.el4'], execute_options).returns('').at_most_once
        provider.uninstall
      end
    end

    describe "when uninstalled with options" do
      before(:each) do
        Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", "-q", "myresource", '--nosignature', '--nodigest', "--qf", "'#{nevra_format}'"], execute_options).returns("myresource 0 1.2.3.4 5.el4 noarch\n")
      end

      let(:resource) do
        Puppet::Type.type(:package).new(
          :name              => resource_name,
          :ensure            => :absent,
          :provider          => 'rpm',
          :uninstall_options => ['--nodeps']
        )
      end

      it "includes the options" do
        Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", ["-e", "--nodeps"], 'myresource-1.2.3.4-5.el4.noarch'], execute_options)
        provider.uninstall
      end
    end
  end

  describe "parsing" do
    def parser_test(rpm_output_string, gold_hash, number_of_debug_logs = 0)
      Puppet.expects(:debug).times(number_of_debug_logs)
      Puppet::Util::Execution.expects(:execute).with(["/bin/rpm", "-q", resource_name, "--nosignature", "--nodigest", "--qf", "'#{nevra_format}'"], execute_options).returns(rpm_output_string)
      expect(provider.query).to eq(gold_hash)
    end

    let(:resource_name) { 'name' }
    let('delimiter') { ':DESC:' }
    let(:package_hash) do
      {
        :name => 'name',
        :epoch => 'epoch',
        :version => 'version',
        :release => 'release',
        :arch => 'arch',
        :provider => :rpm,
        :ensure => 'epoch:version-release',
      }
    end
    let(:line) { 'name epoch version release arch' }

    ['name', 'epoch', 'version', 'release', 'arch'].each do |field|

      it "still parses if #{field} is replaced by delimiter" do
        parser_test(
          line.gsub(field, delimiter),
          package_hash.merge(
            field.to_sym => delimiter,
            :ensure => 'epoch:version-release'.gsub(field, delimiter)
          )
        )
      end

    end

    it "does not fail if line is unparseable, but issues a debug log" do
      parser_test('bad data', {}, 1)
    end

    describe "when the package is not found" do
      before do
        Puppet.expects(:debug).never
        expected_args = ["/bin/rpm", "-q", resource_name, "--nosignature", "--nodigest", "--qf", "'#{nevra_format}'"]
        Puppet::Util::Execution.expects(:execute).with(expected_args, execute_options).raises Puppet::ExecutionFailure.new("package #{resource_name} is not installed")
      end

      it "does not log or fail if allow_virtual is false" do
        resource[:allow_virtual] = false
        expect(provider.query).to be_nil
      end

      it "does not log or fail if allow_virtual is true" do
        resource[:allow_virtual] = true
        expected_args = ['/bin/rpm', '-q', resource_name, '--nosignature', '--nodigest', '--qf', "'#{nevra_format}'", '--whatprovides']
        Puppet::Util::Execution.expects(:execute).with(expected_args, execute_options).raises Puppet::ExecutionFailure.new("package #{resource_name} is not provided")
        expect(provider.query).to be_nil
      end
    end

    it "parses virtual package" do
      provider.resource[:allow_virtual] = true
      expected_args = ["/bin/rpm", "-q", resource_name, "--nosignature", "--nodigest", "--qf", "'#{nevra_format}'"]
      Puppet::Util::Execution.expects(:execute).with(expected_args, execute_options).raises Puppet::ExecutionFailure.new("package #{resource_name} is not installed")
      Puppet::Util::Execution.expects(:execute).with(expected_args + ["--whatprovides"], execute_options).returns "myresource 0 1.2.3.4 5.el4 noarch\n"
      expect(provider.query).to eq({
        :name     => "myresource",
        :epoch    => "0",
        :version  => "1.2.3.4",
        :release  => "5.el4",
        :arch     => "noarch",
        :provider => :rpm,
        :ensure   => "1.2.3.4-5.el4"
      })
    end
  end

  describe "#install_options" do
    it "returns nil by default" do
      expect(provider.install_options).to eq(nil)
    end

    it "returns install_options when set" do
      provider.resource[:install_options] = ['-n']
      expect(provider.install_options).to eq(['-n'])
    end

    it "returns multiple install_options when set" do
      provider.resource[:install_options] = ['-L', '/opt/puppet']
      expect(provider.install_options).to eq(['-L', '/opt/puppet'])
    end

    it 'returns install_options when set as hash' do
      provider.resource[:install_options] = [{ '-Darch' => 'vax' }]
      expect(provider.install_options).to eq(['-Darch=vax'])
    end

    it 'returns install_options when an array with hashes' do
      provider.resource[:install_options] = [ '-L', { '-Darch' => 'vax' }]
      expect(provider.install_options).to eq(['-L', '-Darch=vax'])
    end
  end

  describe "#uninstall_options" do
    it "returns nil by default" do
      expect(provider.uninstall_options).to eq(nil)
    end

    it "returns uninstall_options when set" do
      provider.resource[:uninstall_options] = ['-n']
      expect(provider.uninstall_options).to eq(['-n'])
    end

    it "returns multiple uninstall_options when set" do
      provider.resource[:uninstall_options] = ['-L', '/opt/puppet']
      expect(provider.uninstall_options).to eq(['-L', '/opt/puppet'])
    end

    it 'returns uninstall_options when set as hash' do
      provider.resource[:uninstall_options] = [{ '-Darch' => 'vax' }]
      expect(provider.uninstall_options).to eq(['-Darch=vax'])
    end
    it 'returns uninstall_options when an array with hashes' do
      provider.resource[:uninstall_options] = [ '-L', { '-Darch' => 'vax' }]
      expect(provider.uninstall_options).to eq(['-L', '-Darch=vax'])
    end
  end

  describe ".nodigest" do
    { '4.0'   => nil,
      '4.0.1' => nil,
      '4.0.2' => '--nodigest',
      '4.0.3' => '--nodigest',
      '4.1'   => '--nodigest',
      '5'     => '--nodigest',
    }.each do |version, expected|
      describe "when current version is #{version}" do
        it "returns #{expected.inspect}" do
          provider_class.stubs(:current_version).returns(version)
          expect(provider_class.nodigest).to eq(expected)
        end
      end
    end
  end

  describe ".nosignature" do
    { '4.0.3' => nil,
      '4.1'   => '--nosignature',
      '4.1.1' => '--nosignature',
      '4.2'   => '--nosignature',
      '5'     => '--nosignature',
    }.each do |version, expected|
      describe "when current version is #{version}" do
        it "returns #{expected.inspect}" do
          provider_class.stubs(:current_version).returns(version)
          expect(provider_class.nosignature).to eq(expected)
        end
      end
    end
  end

  describe 'version comparison' do

    # test cases munged directly from rpm's own
    # tests/rpmvercmp.at
    it { expect(provider.rpmvercmp("1.0", "1.0")).to eq(0) }
    it { expect(provider.rpmvercmp("1.0", "2.0")).to eq(-1) }
    it { expect(provider.rpmvercmp("2.0", "1.0")).to eq(1) }
    it { expect(provider.rpmvercmp("2.0.1", "2.0.1")).to eq(0) }
    it { expect(provider.rpmvercmp("2.0", "2.0.1")).to eq(-1) }
    it { expect(provider.rpmvercmp("2.0.1", "2.0")).to eq(1) }
    it { expect(provider.rpmvercmp("2.0.1a", "2.0.1a")).to eq(0) }
    it { expect(provider.rpmvercmp("2.0.1a", "2.0.1")).to eq(1) }
    it { expect(provider.rpmvercmp("2.0.1", "2.0.1a")).to eq(-1) }
    it { expect(provider.rpmvercmp("5.5p1", "5.5p1")).to eq(0) }
    it { expect(provider.rpmvercmp("5.5p1", "5.5p2")).to eq(-1) }
    it { expect(provider.rpmvercmp("5.5p2", "5.5p1")).to eq(1) }
    it { expect(provider.rpmvercmp("5.5p10", "5.5p10")).to eq(0) }
    it { expect(provider.rpmvercmp("5.5p1", "5.5p10")).to eq(-1) }
    it { expect(provider.rpmvercmp("5.5p10", "5.5p1")).to eq(1) }
    it { expect(provider.rpmvercmp("10xyz", "10.1xyz")).to eq(-1) }
    it { expect(provider.rpmvercmp("10.1xyz", "10xyz")).to eq(1) }
    it { expect(provider.rpmvercmp("xyz10", "xyz10")).to eq(0) }
    it { expect(provider.rpmvercmp("xyz10", "xyz10.1")).to eq(-1) }
    it { expect(provider.rpmvercmp("xyz10.1", "xyz10")).to eq(1) }
    it { expect(provider.rpmvercmp("xyz.4", "xyz.4")).to eq(0) }
    it { expect(provider.rpmvercmp("xyz.4", "8")).to eq(-1) }
    it { expect(provider.rpmvercmp("8", "xyz.4")).to eq(1) }
    it { expect(provider.rpmvercmp("xyz.4", "2")).to eq(-1) }
    it { expect(provider.rpmvercmp("2", "xyz.4")).to eq(1) }
    it { expect(provider.rpmvercmp("5.5p2", "5.6p1")).to eq(-1) }
    it { expect(provider.rpmvercmp("5.6p1", "5.5p2")).to eq(1) }
    it { expect(provider.rpmvercmp("5.6p1", "6.5p1")).to eq(-1) }
    it { expect(provider.rpmvercmp("6.5p1", "5.6p1")).to eq(1) }
    it { expect(provider.rpmvercmp("6.0.rc1", "6.0")).to eq(1) }
    it { expect(provider.rpmvercmp("6.0", "6.0.rc1")).to eq(-1) }
    it { expect(provider.rpmvercmp("10b2", "10a1")).to eq(1) }
    it { expect(provider.rpmvercmp("10a2", "10b2")).to eq(-1) }
    it { expect(provider.rpmvercmp("1.0aa", "1.0aa")).to eq(0) }
    it { expect(provider.rpmvercmp("1.0a", "1.0aa")).to eq(-1) }
    it { expect(provider.rpmvercmp("1.0aa", "1.0a")).to eq(1) }
    it { expect(provider.rpmvercmp("10.0001", "10.0001")).to eq(0) }
    it { expect(provider.rpmvercmp("10.0001", "10.1")).to eq(0) }
    it { expect(provider.rpmvercmp("10.1", "10.0001")).to eq(0) }
    it { expect(provider.rpmvercmp("10.0001", "10.0039")).to eq(-1) }
    it { expect(provider.rpmvercmp("10.0039", "10.0001")).to eq(1) }
    it { expect(provider.rpmvercmp("4.999.9", "5.0")).to eq(-1) }
    it { expect(provider.rpmvercmp("5.0", "4.999.9")).to eq(1) }
    it { expect(provider.rpmvercmp("20101121", "20101121")).to eq(0) }
    it { expect(provider.rpmvercmp("20101121", "20101122")).to eq(-1) }
    it { expect(provider.rpmvercmp("20101122", "20101121")).to eq(1) }
    it { expect(provider.rpmvercmp("2_0", "2_0")).to eq(0) }
    it { expect(provider.rpmvercmp("2.0", "2_0")).to eq(0) }
    it { expect(provider.rpmvercmp("2_0", "2.0")).to eq(0) }
    it { expect(provider.rpmvercmp("a", "a")).to eq(0) }
    it { expect(provider.rpmvercmp("a+", "a+")).to eq(0) }
    it { expect(provider.rpmvercmp("a+", "a_")).to eq(0) }
    it { expect(provider.rpmvercmp("a_", "a+")).to eq(0) }
    it { expect(provider.rpmvercmp("+a", "+a")).to eq(0) }
    it { expect(provider.rpmvercmp("+a", "_a")).to eq(0) }
    it { expect(provider.rpmvercmp("_a", "+a")).to eq(0) }
    it { expect(provider.rpmvercmp("+_", "+_")).to eq(0) }
    it { expect(provider.rpmvercmp("_+", "+_")).to eq(0) }
    it { expect(provider.rpmvercmp("_+", "_+")).to eq(0) }
    it { expect(provider.rpmvercmp("+", "_")).to eq(0) }
    it { expect(provider.rpmvercmp("_", "+")).to eq(0) }
    it { expect(provider.rpmvercmp("1.0~rc1", "1.0~rc1")).to eq(0) }
    it { expect(provider.rpmvercmp("1.0~rc1", "1.0")).to eq(-1) }
    it { expect(provider.rpmvercmp("1.0", "1.0~rc1")).to eq(1) }
    it { expect(provider.rpmvercmp("1.0~rc1", "1.0~rc2")).to eq(-1) }
    it { expect(provider.rpmvercmp("1.0~rc2", "1.0~rc1")).to eq(1) }
    it { expect(provider.rpmvercmp("1.0~rc1~git123", "1.0~rc1~git123")).to eq(0) }
    it { expect(provider.rpmvercmp("1.0~rc1~git123", "1.0~rc1")).to eq(-1) }
    it { expect(provider.rpmvercmp("1.0~rc1", "1.0~rc1~git123")).to eq(1) }
    it { expect(provider.rpmvercmp("1.0~rc1", "1.0arc1")).to eq(-1) }
    it { expect(provider.rpmvercmp("", "~")).to eq(1) }
    it { expect(provider.rpmvercmp("~", "~~")).to eq(1) }
    it { expect(provider.rpmvercmp("~", "~+~")).to eq(1) }
    it { expect(provider.rpmvercmp("~", "~a")).to eq(-1) }

    # non-upstream test cases
    it { expect(provider.rpmvercmp("405", "406")).to eq(-1) }
    it { expect(provider.rpmvercmp("1", "0")).to eq(1) }
  end

  describe 'package evr parsing' do

    it 'should parse full simple evr' do
      v = provider.rpm_parse_evr('0:1.2.3-4.el5')
      expect(v[:epoch]).to eq('0')
      expect(v[:version]).to eq('1.2.3')
      expect(v[:release]).to eq('4.el5')
    end

    it 'should parse version only' do
      v = provider.rpm_parse_evr('1.2.3')
      expect(v[:epoch]).to eq(nil)
      expect(v[:version]).to eq('1.2.3')
      expect(v[:release]).to eq(nil)
    end

    it 'should parse version-release' do
      v = provider.rpm_parse_evr('1.2.3-4.5.el6')
      expect(v[:epoch]).to eq(nil)
      expect(v[:version]).to eq('1.2.3')
      expect(v[:release]).to eq('4.5.el6')
    end

    it 'should parse release with git hash' do
      v = provider.rpm_parse_evr('1.2.3-4.1234aefd')
      expect(v[:epoch]).to eq(nil)
      expect(v[:version]).to eq('1.2.3')
      expect(v[:release]).to eq('4.1234aefd')
    end

    it 'should parse single integer versions' do
      v = provider.rpm_parse_evr('12345')
      expect(v[:epoch]).to eq(nil)
      expect(v[:version]).to eq('12345')
      expect(v[:release]).to eq(nil)
    end

    it 'should parse text in the epoch to 0' do
      v = provider.rpm_parse_evr('foo0:1.2.3-4')
      expect(v[:epoch]).to eq(nil)
      expect(v[:version]).to eq('1.2.3')
      expect(v[:release]).to eq('4')
    end

    it 'should parse revisions with text' do
      v = provider.rpm_parse_evr('1.2.3-SNAPSHOT20140107')
      expect(v[:epoch]).to eq(nil)
      expect(v[:version]).to eq('1.2.3')
      expect(v[:release]).to eq('SNAPSHOT20140107')
    end

    # test cases for PUP-682
    it 'should parse revisions with text and numbers' do
      v = provider.rpm_parse_evr('2.2-SNAPSHOT20121119105647')
      expect(v[:epoch]).to eq(nil)
      expect(v[:version]).to eq('2.2')
      expect(v[:release]).to eq('SNAPSHOT20121119105647')
    end

  end

  describe 'rpm evr comparison' do

    # currently passing tests
    it 'should evaluate identical version-release as equal' do
      v = provider.rpm_compareEVR({:epoch => '0', :version => '1.2.3', :release => '1.el5'},
                                  {:epoch => '0', :version => '1.2.3', :release => '1.el5'})
      expect(v).to eq(0)
    end

    it 'should evaluate identical version as equal' do
      v = provider.rpm_compareEVR({:epoch => '0', :version => '1.2.3', :release => nil},
                                  {:epoch => '0', :version => '1.2.3', :release => nil})
      expect(v).to eq(0)
    end

    it 'should evaluate identical version but older release as less' do
      v = provider.rpm_compareEVR({:epoch => '0', :version => '1.2.3', :release => '1.el5'},
                                  {:epoch => '0', :version => '1.2.3', :release => '2.el5'})
      expect(v).to eq(-1)
    end

    it 'should evaluate identical version but newer release as greater' do
      v = provider.rpm_compareEVR({:epoch => '0', :version => '1.2.3', :release => '3.el5'},
                                  {:epoch => '0', :version => '1.2.3', :release => '2.el5'})
      expect(v).to eq(1)
    end

    it 'should evaluate a newer epoch as greater' do
      v = provider.rpm_compareEVR({:epoch => '1', :version => '1.2.3', :release => '4.5'},
                                  {:epoch => '0', :version => '1.2.3', :release => '4.5'})
      expect(v).to eq(1)
    end

    # these tests describe PUP-1244 logic yet to be implemented
    it 'should evaluate any version as equal to the same version followed by release' do
      v = provider.rpm_compareEVR({:epoch => '0', :version => '1.2.3', :release => nil},
                                  {:epoch => '0', :version => '1.2.3', :release => '2.el5'})
      expect(v).to eq(0)
    end

    # test cases for PUP-682
    it 'should evaluate same-length numeric revisions numerically' do
      expect(provider.rpm_compareEVR({:epoch => '0', :version => '2.2', :release => '405'},
                               {:epoch => '0', :version => '2.2', :release => '406'})).to eq(-1)
    end

  end

  describe 'version segment comparison' do

    it 'should treat two nil values as equal' do
      v = provider.compare_values(nil, nil)
      expect(v).to eq(0)
    end

    it 'should treat a nil value as less than a non-nil value' do
      v = provider.compare_values(nil, '0')
      expect(v).to eq(-1)
    end

    it 'should treat a non-nil value as greater than a nil value' do
      v = provider.compare_values('0', nil)
      expect(v).to eq(1)
    end

    it 'should pass two non-nil values on to rpmvercmp' do
      provider.stubs(:rpmvercmp) { 0 }
      provider.expects(:rpmvercmp).with('s1', 's2')
      provider.compare_values('s1', 's2')
    end

  end

end