Sha256: 4446e46ebe43cc67c7098f279046afe73068ec6db5971eb74bcd3bb025c1d082
Contents?: true
Size: 1.83 KB
Versions: 70
Compression:
Stored size: 1.83 KB
Contents
# frozen_string_literal: true
module RuboCop
module Cop
module Style
# Checks for nested ternary op expressions.
#
# @example
# # bad
# a ? (b ? b1 : b2) : a2
#
# # good
# if a
# b ? b1 : b2
# else
# a2
# end
class NestedTernaryOperator < Base
extend AutoCorrector
include RangeHelp
include IgnoredNode
MSG = 'Ternary operators must not be nested. Prefer `if` or `else` constructs instead.'
def on_if(node)
return unless node.ternary?
node.each_descendant(:if).select(&:ternary?).each do |nested_ternary|
add_offense(nested_ternary) do |corrector|
if_node = if_node(nested_ternary)
next if part_of_ignored_node?(if_node)
autocorrect(corrector, if_node)
ignore_node(if_node)
end
end
end
private
def if_node(node)
node = node.parent
return node if node.if_type?
if_node(node)
end
def autocorrect(corrector, if_node)
replace_loc_and_whitespace(corrector, if_node.loc.question, "\n")
replace_loc_and_whitespace(corrector, if_node.loc.colon, "\nelse\n")
corrector.replace(if_node.if_branch, remove_parentheses(if_node.if_branch.source))
corrector.wrap(if_node, 'if ', "\nend")
end
def remove_parentheses(source)
return source unless source.start_with?('(')
source.delete_prefix('(').delete_suffix(')')
end
def replace_loc_and_whitespace(corrector, range, replacement)
corrector.replace(
range_with_surrounding_space(range: range, whitespace: true),
replacement
)
end
end
end
end
end
Version data entries
70 entries across 63 versions & 11 rubygems